From a17c456b2ccd44566c2395efc90d403cd27a2902 Mon Sep 17 00:00:00 2001 From: Fabrice Fontaine Date: Sun, 14 Aug 2022 20:27:34 +0200 Subject: [PATCH] package/libvirt: fix libvirtd dependency Commit 4dff1be05e90 (package/libvirt: libvirtd needs C++ for nmap-ncat) introduce a recursive dependency (really: a circular dependency): package/busybox/Config.in:33:error: recursive dependency detected! package/busybox/Config.in:33: symbol BR2_PACKAGE_BUSYBOX_SHOW_OTHERS is selected by BR2_PACKAGE_EBTABLES_UTILS_SAVE package/ebtables/Config.in:11: symbol BR2_PACKAGE_EBTABLES_UTILS_SAVE depends on BR2_PACKAGE_EBTABLES package/ebtables/Config.in:1: symbol BR2_PACKAGE_EBTABLES is selected by BR2_PACKAGE_LIBVIRT_DAEMON package/libvirt/Config.in:44: symbol BR2_PACKAGE_LIBVIRT_DAEMON depends on BR2_PACKAGE_NETCAT_OPENBSD package/netcat-openbsd/Config.in:1: symbol BR2_PACKAGE_NETCAT_OPENBSD depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS We can't drop the C++ dependency and switch the netcat-openbsd and nmap-ncat dependencies conditions without adding a glibc dependency. So always mandate C++ even if is only needed by nmap and not netcat-openbsd Signed-off-by: Fabrice Fontaine Signed-off-by: Yann E. MORIN --- package/libvirt/Config.in | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/package/libvirt/Config.in b/package/libvirt/Config.in index 65226af336..f0687cd5db 100644 --- a/package/libvirt/Config.in +++ b/package/libvirt/Config.in @@ -44,7 +44,7 @@ if BR2_PACKAGE_LIBVIRT config BR2_PACKAGE_LIBVIRT_DAEMON bool "libvirtd" default y - depends on BR2_INSTALL_LIBSTDCPP || BR2_PACKAGE_NETCAT_OPENBSD # nmap + depends on BR2_INSTALL_LIBSTDCPP # nmap select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS select BR2_PACKAGE_DNSMASQ select BR2_PACKAGE_EBTABLES @@ -58,6 +58,9 @@ config BR2_PACKAGE_LIBVIRT_DAEMON Build the libvirt daemon (libvirtd) otherwise build only the utility programs. +comment "libvirtd needs a toolchain w/ C++" + depends on !BR2_INSTALL_LIBSTDCPP + # Stateful drivers are useful only when building the daemon. if BR2_PACKAGE_LIBVIRT_DAEMON