From 99c9b0affde4fcc3270425319b98a0e5e32f5964 Mon Sep 17 00:00:00 2001 From: Arnout Vandecappelle Date: Fri, 17 Mar 2017 17:06:14 +0100 Subject: [PATCH] acl: make sure build picks up TARGET_CFLAGS The acl build system doesn't use automake, therefore it is broken. It doesn't use the CFLAGS passed by configure. Work around this by passing CFLAGS in the environment. The makefiles append to CFLAGS, so this works. This issue hasn't led to build failures, but it is visible e.g. when stack protector is enabled: the stack protector options are not applied to acl. Also debug and optimisation options aren't applied. Signed-off-by: Arnout Vandecappelle (Essensium/Mind) Cc: Yegor Yefremov Signed-off-by: Thomas Petazzoni --- package/acl/acl.mk | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/package/acl/acl.mk b/package/acl/acl.mk index cbe5e93961..9fd5de18a4 100644 --- a/package/acl/acl.mk +++ b/package/acl/acl.mk @@ -15,7 +15,13 @@ ACL_LICENSE_FILES = doc/COPYING doc/COPYING.LGPL # While the configuration system uses autoconf, the Makefiles are # hand-written and do not use automake. Therefore, we have to hack -# around their deficiencies by passing installation paths. +# around their deficiencies by: +# - explicitly passing CFLAGS (LDFLAGS are passed on from configure, +# CFLAGS are not). +# - explicitly passing the installation prefix, not using DESTDIR. + +ACL_MAKE_ENV = CFLAGS="$(TARGET_CFLAGS)" + ACL_INSTALL_STAGING_OPTS = \ prefix=$(STAGING_DIR)/usr \ exec_prefix=$(STAGING_DIR)/usr \