NetCube-Systems-Austria/kumquat-buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

valgrind: Force -fno-stack-protector in CFLAGS

Browse Source 
Valgrind must be compiled with no stack protection. Valgrind defaults
CFLAGS to -fno-stack-protector, but Buildroot's CFLAGS may override
if SSP is enabled.

Signed-off-by: Brandon Maier <brandon.maier@rockwellcollins.com>
Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
This commit is contained in:
Brandon Maier 2016-12-21 13:02:16 -06:00 committed by Thomas Petazzoni
parent 5c5077e117
commit 994ac94c57
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
package/valgrind/valgrind.mk
View File

@ -17,6 +17,13 @@ VALGRIND_INSTALL_STAGING = YES
# patch 0004-Fixes-for-musl-libc.patch touching configure.ac # patch 0004-Fixes-for-musl-libc.patch touching configure.ac
VALGRIND_AUTORECONF = YES VALGRIND_AUTORECONF = YES
# Valgrind must be compiled with no stack protection, so forcefully
# pass -fno-stack-protector to override what Buildroot may have in
# TARGET_CFLAGS if BR2_SSP_* support is enabled.
VALGRIND_CFLAGS = \
$(TARGET_CFLAGS) \
-fno-stack-protector
# When Valgrind detects a 32-bit MIPS architecture, it forcibly adds # When Valgrind detects a 32-bit MIPS architecture, it forcibly adds
# -march=mips32 to CFLAGS; when it detects a 64-bit MIPS architecture, # -march=mips32 to CFLAGS; when it detects a 64-bit MIPS architecture,
# it forcibly adds -march=mips64. This causes Valgrind to be built # it forcibly adds -march=mips64. This causes Valgrind to be built
@ -27,9 +34,11 @@ VALGRIND_AUTORECONF = YES
# and pass the right -march option, so they take precedence over # and pass the right -march option, so they take precedence over
# Valgrind's wrongfully detected value. # Valgrind's wrongfully detected value.
ifeq ($(BR2_mips)$(BR2_mipsel)$(BR2_mips64)$(BR2_mips64el),y) ifeq ($(BR2_mips)$(BR2_mipsel)$(BR2_mips64)$(BR2_mips64el),y)
VALGRIND_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -march=$(BR2_GCC_TARGET_ARCH)" VALGRIND_CFLAGS += -march=$(BR2_GCC_TARGET_ARCH)
endif endif
VALGRIND_CONF_ENV = CFLAGS="$(VALGRIND_CFLAGS)"
# On ARM, Valgrind only supports ARMv7, and uses the arch part of the # On ARM, Valgrind only supports ARMv7, and uses the arch part of the
# host tuple to determine whether it's being built for ARMv7 or # host tuple to determine whether it's being built for ARMv7 or
# not. Therefore, we adjust the host tuple to specify we're on # not. Therefore, we adjust the host tuple to specify we're on