NetCube-Systems-Austria/kumquat-buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

package/kmsxx: remove erroneous use of static-libc option

Browse Source 
Currently, for a static-only build, we pass -Dstatic-libc=true. The
reason for that was not recorded when the package was converted to
meson.

The -Dstatic-libc=true option, despite its name, is not about linking
statically against libc, but against libgcc and libstdc++.

In Buildroot, we forcibly pass -static when calling the compiler and
linker, so everything is already linked statically.

For a shared build, -Dstatic-libc=false has no effect at all.

Drop this option altogether, as it is not needed, and is confusing.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
[yann.morin.1998@free.fr: expand commit log]
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
This commit is contained in:
Tomi Valkeinen 2021-08-06 15:50:46 +03:00 committed by Yann E. MORIN
parent 3418a068be
commit 95ad161fe9
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
package/kmsxx/kmsxx.mk
View File

@ -17,12 +17,6 @@ KMSXX_CONF_OPTS = \
-Duse-system-fmt=true \
-Duse-system-pybind11=true
ifeq ($(BR2_STATIC_LIBS),y)
KMSXX_CONF_OPTS += -Dstatic-libc=true
else
KMSXX_CONF_OPTS += -Dstatic-libc=false
endif
ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
KMSXX_CXXFLAGS += $(TARGET_CXXFLAGS) -O0
endif