NetCube-Systems-Austria/kumquat-buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

.gitlab-ci.yml: simplify (and fix) check-DEVELOPERS

Browse Source 
The check-DEVELOPERS test would always fail, because && will return
the exit code of the left-hand side if not 0, so it *always* returns
1.

But in fact, the test can be simplified quite a lot: we can run
getdeveloper directly, without arguments. That should just print
'No action specified', but it will also print any syntax errors it
encountered. So we can just 'grep -v' the expected output away; if
there is anything more, grep will return 0, but if there is nothing
more, it will return 1. So we just need to invert the result.

Incidentally, this also fixes the incorrect remaining reference to
support/scripts.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
This commit is contained in:
Arnout Vandecappelle 2017-07-01 19:28:17 +02:00 committed by Thomas Petazzoni
parent 9c2428616e
commit 91a5ec960b
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.gitlab-ci.yml
View File

@ -36,9 +36,7 @@ check-gitlab-ci.yml:
check-DEVELOPERS:
script:
- PYTHONPATH=$PWD/support/scripts
python -c 'from getdeveloperlib import parse_developers; parse_developers()' |
grep . && exit 1
- ! utils/get-developers | grep -v 'No action specified'
.defconfig: &defconfig
# Running the defconfigs for every push is too much, so limit to

4
.gitlab-ci.yml.in
View File

@ -36,9 +36,7 @@ check-gitlab-ci.yml:
check-DEVELOPERS:
script:
- PYTHONPATH=$PWD/support/scripts
python -c 'from getdeveloperlib import parse_developers; parse_developers()' |
grep . && exit 1
- ! utils/get-developers | grep -v 'No action specified'
.defconfig: &defconfig
# Running the defconfigs for every push is too much, so limit to