NetCube-Systems-Austria/kumquat-buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

support/download: add possibility to not fail on missing hash

Browse Source 
In very constrained cases, it might be needed to not fail if a hash is
missing. This is notably the case for custom external toolchains to be
downloaded, because we do have a .hash file for external toolchains,
but we obviously can not have hashes for all existing custom toolchains
(he, "custom"!).

So, add a way to avoid failing in that case.

>From the Makefile, we export the list of files for which not to check
the hash. Then, from the check-hash script, if no check was done, and
the file we were trying to match in in this exclusion list, we just exit
without error.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

changes v6 -> v7:
  - /beautify/ the pattern in the case clause

Changed v5 -> v6:  (Arnout)
  - fix the pattern in the case clause

Changes v4 -> v5:
  - micro-optimisation, use case-esac instead of a for-loop  (Arnout)
  - typoes  (Arnout)

Changes v3 -> v4:
  - drop the magic value, use a list of excluded files  (Arnout)

Changes v1 -> v2:
  - fix typoes in commit log

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Tested-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
This commit is contained in:
Yann E. MORIN 2015-04-23 00:08:38 +02:00 committed by Thomas Petazzoni
parent 3449a6ee4a
commit 8d2f4e6246
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
package/pkg-download.mk
View File

@ -60,6 +60,9 @@ domainseparator = $(if $(1),$(1),/)
# github(user,package,version): returns site of GitHub repository # github(user,package,version): returns site of GitHub repository
github = https://github.com/$(1)/$(2)/archive/$(3) github = https://github.com/$(1)/$(2)/archive/$(3)
# Expressly do not check hashes for those files
export BR_NO_CHECK_HASH_FOR
################################################################################ ################################################################################
# The DOWNLOAD_* helpers are in charge of getting a working copy # The DOWNLOAD_* helpers are in charge of getting a working copy
# of the source repository for their corresponding SCM, # of the source repository for their corresponding SCM,

6
support/download/check-hash
View File

@ -99,6 +99,12 @@ while read t h f; do
done <"${h_file}" done <"${h_file}"
if [ ${nb_checks} -eq 0 ]; then if [ ${nb_checks} -eq 0 ]; then
case " ${BR_NO_CHECK_HASH_FOR} " in
*" ${base} "*)
# File explicitly has no hash
exit 0
;;
esac
printf "ERROR: No hash found for %s\n" "${base}" >&2 printf "ERROR: No hash found for %s\n" "${base}" >&2
exit 0 exit 0
fi fi