NetCube-Systems-Austria/kumquat-buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dropwatch: fix static link

Browse Source 
Use LDLIBS for the list of libraries, since LDFLAGS appear before the source
files in the link command, and the upstream LDLIBS lacks -lncurses which is a
dependency of readline. We already pass target LDFLAGS in
TARGET_CONFIGURE_OPTS, so drop that part.

Fixes:
http://autobuild.buildroot.net/results/ce4/ce436bdd7e7950c801edac01f311b89110d87d62/
http://autobuild.buildroot.net/results/691/691d61d13849150c3616b1c74c964f50118ff1d9/
http://autobuild.buildroot.net/results/291/2918c75e473c5a2434e72f2e409becc5b4d07908/

Cc: Tzu-Jung Lee <roylee17@gmail.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
This commit is contained in:
Baruch Siach 2017-06-30 07:48:34 +03:00 committed by Thomas Petazzoni
parent eaa3d0e292
commit 8934cb0795
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
package/dropwatch/dropwatch.mk
View File

@ -11,18 +11,17 @@ DROPWATCH_LICENSE = GPL-2.0
DROPWATCH_LICENSE_FILES = COPYING DROPWATCH_LICENSE_FILES = COPYING
# libbfd may be linked to libintl # libbfd may be linked to libintl
# Ugly... but LDFLAGS are hardcoded anyway # Ugly... but LDLIBS are hardcoded anyway
DROPWATCH_LDFLAGS = \ DROPWATCH_LDLIBS = \
$(TARGET_LDFLAGS) -lbfd -lreadline -lnl-3 -lnl-genl-3 \ -lbfd -lreadline -lnl-3 -lnl-genl-3 -lpthread -lncurses -lm
-lpthread -lncurses -lm
ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y) ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y)
DROPWATCH_LDFLAGS += -lintl DROPWATCH_LDLIBS += -lintl
endif endif
define DROPWATCH_BUILD_CMDS define DROPWATCH_BUILD_CMDS
$(TARGET_CONFIGURE_OPTS) $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \ $(TARGET_CONFIGURE_OPTS) $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
LDFLAGS="$(DROPWATCH_LDFLAGS)" build LDLIBS="$(DROPWATCH_LDLIBS)" build
endef endef
define DROPWATCH_INSTALL_TARGET_CMDS define DROPWATCH_INSTALL_TARGET_CMDS