From 8564f1bcca502819f8cc26bbfd3e115fd84e8420 Mon Sep 17 00:00:00 2001 From: Ricardo Martincoski Date: Sun, 24 Jul 2022 02:48:58 -0300 Subject: [PATCH] utils/check-package: improve shellcheck reproducibility shellcheck is already in use to check SysV init scripts. Currently its results can be affected by the existence of a .shellcheckrc file in any parent directory. For instance, in this example: (1) /path/.shellcheckrc (2) /path/to/.shellcheckrc (3) /path/to/buildroot the configs from file (1) are ignored and the configs from file (2) override the default values from the shellcheck binary. So the config file affects the check-package result for SysV scripts. Avoid this reproducibility issue by adding an empty config file to the buildroot topdir. It can also eventually contain configs (different from default values from sheelcheck) that we want as a standard to all shell scripts tested by check-package. Signed-off-by: Ricardo Martincoski Signed-off-by: Arnout Vandecappelle (Essensium/Mind) (cherry picked from commit eaa1a43ab7281f70754405441501712a4e2b9981) Signed-off-by: Peter Korsgaard --- .shellcheckrc | 0 DEVELOPERS | 1 + 2 files changed, 1 insertion(+) create mode 100644 .shellcheckrc diff --git a/.shellcheckrc b/.shellcheckrc new file mode 100644 index 0000000000..e69de29bb2 diff --git a/DEVELOPERS b/DEVELOPERS index 938782b1fd..4682005fb3 100644 --- a/DEVELOPERS +++ b/DEVELOPERS @@ -2408,6 +2408,7 @@ F: package/libhttpparser/ N: Ricardo Martincoski F: .flake8 +F: .shellcheckrc F: package/atop/ F: package/thermald/ F: support/testing/infra/