From 7e7cf7aa7a4a41d4fcfd9a4667d4786078ae49e8 Mon Sep 17 00:00:00 2001 From: Fabrice Fontaine Date: Sun, 18 Sep 2022 12:13:17 +0200 Subject: [PATCH] package/libconfuse: fix CVE-2022-40320 cfg_tilde_expand in confuse.c in libConfuse 3.3 has a heap-based buffer over-read. Signed-off-by: Fabrice Fontaine Signed-off-by: Yann E. MORIN (cherry picked from commit d7561a8c5e107b411d01afa5627cb0bb730abe86) Signed-off-by: Peter Korsgaard --- ...rminated-username-used-with-getpwnam.patch | 43 +++++++++++++++++++ package/libconfuse/libconfuse.mk | 3 ++ 2 files changed, 46 insertions(+) create mode 100644 package/libconfuse/0001-Fix-163-unterminated-username-used-with-getpwnam.patch diff --git a/package/libconfuse/0001-Fix-163-unterminated-username-used-with-getpwnam.patch b/package/libconfuse/0001-Fix-163-unterminated-username-used-with-getpwnam.patch new file mode 100644 index 0000000000..9ff3f5ec1c --- /dev/null +++ b/package/libconfuse/0001-Fix-163-unterminated-username-used-with-getpwnam.patch @@ -0,0 +1,43 @@ +From d73777c2c3566fb2647727bb56d9a2295b81669b Mon Sep 17 00:00:00 2001 +From: Joachim Wiberg +Date: Fri, 2 Sep 2022 16:12:46 +0200 +Subject: [PATCH] Fix #163: unterminated username used with getpwnam() + +Signed-off-by: Joachim Wiberg + +[Retrieved (and backported) from: +https://github.com/libconfuse/libconfuse/commit/d73777c2c3566fb2647727bb56d9a2295b81669b] +Signed-off-by: Fabrice Fontaine +--- + src/confuse.c | 10 ++++++---- + 1 file changed, 6 insertions(+), 4 deletions(-) + +diff --git a/src/confuse.c b/src/confuse.c +index 6d1fdbd..05566b5 100644 +--- a/src/confuse.c ++++ b/src/confuse.c +@@ -1894,18 +1894,20 @@ DLLIMPORT char *cfg_tilde_expand(const char *filename) + passwd = getpwuid(geteuid()); + file = filename + 1; + } else { +- /* ~user or ~user/path */ +- char *user; ++ char *user; /* ~user or ~user/path */ ++ size_t len; + + file = strchr(filename, '/'); + if (file == 0) + file = filename + strlen(filename); + +- user = malloc(file - filename); ++ len = file - filename - 1; ++ user = malloc(len + 1); + if (!user) + return NULL; + +- strncpy(user, filename + 1, file - filename - 1); ++ strncpy(user, &filename[1], len); ++ user[len] = 0; + passwd = getpwnam(user); + free(user); + } diff --git a/package/libconfuse/libconfuse.mk b/package/libconfuse/libconfuse.mk index 2beb0e4fbf..e7c2ef0a84 100644 --- a/package/libconfuse/libconfuse.mk +++ b/package/libconfuse/libconfuse.mk @@ -14,5 +14,8 @@ LIBCONFUSE_LICENSE_FILES = LICENSE LIBCONFUSE_CPE_ID_VENDOR = libconfuse_project LIBCONFUSE_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES) +# 0001-Fix-163-unterminated-username-used-with-getpwnam.patch +LIBCONFUSE_IGNORE_CVES += CVE-2022-40320 + $(eval $(autotools-package)) $(eval $(host-autotools-package))