NetCube-Systems-Austria/kumquat-buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

package/transmission: remove BR2_PACKAGE_TRANSMISSION_REMOTE

Browse Source 
Commit 6e223241e1 ("Add Transmission
package"), which added the transmission package, introduced a
BR2_PACKAGE_TRANSMISSION_REMOTE Config.in option, supposedly matching
the --enable-remote/--disable-remote transmission option.

However, transmission as of version 2.33 packaged by this initial
commit, did not have a --enable-remote/--disable-remote option, and it
was apparently never part of transmission.

Therefore, this commit removes this useless option. Since the
transmission-remote tool is automatically built when the daemon is
enabled, the Config.in.legacy handling selects
BR2_PACKAGE_TRANSMISSION_DAEMON.

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
This commit is contained in:
Bernd Kuhls 2018-05-02 08:05:40 +02:00 committed by Thomas Petazzoni
parent acadbe6393
commit 79a678d774
3 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Config.in.legacy
View File

@ -145,6 +145,17 @@ endif
###############################################################################
comment "Legacy options removed in 2018.05"
config BR2_PACKAGE_TRANSMISSION_REMOTE
bool "transmission remote tool option removed"
select BR2_LEGACY
select BR2_PACKAGE_TRANSMISSION_DAEMON
help
Upstream does not provide a separate configure option for
the tool transmission-remote, it is built when the
transmission daemon has been enabled. Therefore, Buildroot
has automatically enabled BR2_PACKAGE_TRANSMISSION_DAEMON
for you.
config BR2_PACKAGE_LIBKCAPI_APPS
bool "libkcapi test applications removed"
select BR2_LEGACY

5
package/transmission/Config.in
View File

@ -32,11 +32,6 @@ config BR2_PACKAGE_TRANSMISSION_DAEMON
help
Install transmission daemon.
config BR2_PACKAGE_TRANSMISSION_REMOTE
bool "transmission-remote"
help
Install transmission remote management tool.
config BR2_PACKAGE_TRANSMISSION_GTK
bool "transmission-gtk"
depends on BR2_PACKAGE_LIBGTK3 && BR2_SYSTEM_ENABLE_NLS

6
package/transmission/transmission.mk
View File

@ -75,12 +75,6 @@ else
TRANSMISSION_CONF_OPTS += --disable-daemon
endif
ifeq ($(BR2_PACKAGE_TRANSMISSION_REMOTE),y)
TRANSMISSION_CONF_OPTS += --enable-remote
else
TRANSMISSION_CONF_OPTS += --disable-remote
endif
ifeq ($(BR2_PACKAGE_TRANSMISSION_GTK),y)
TRANSMISSION_CONF_OPTS += --with-gtk
TRANSMISSION_DEPENDENCIES += libgtk3