From 7817b9c2a6b4c117895b53accdaca541fa4af06a Mon Sep 17 00:00:00 2001 From: Julien Olivain Date: Thu, 31 Aug 2023 19:37:36 +0200 Subject: [PATCH] support/testing: python-magic-wormhole: fix random failures The magic-wormhole "receive" command can output "waiting" messages when key receival or verification are longer than a predefined timeout: https://github.com/magic-wormhole/magic-wormhole/blob/0.13.0/src/wormhole/cli/cmd_receive.py#L135 The intent is to have an interactive user experience. This behavior makes the runtime test unreliable as the test always expect the sent message as the exact output. When the test execution is slower, it sometimes get the "waiting" message instead of the expected message. Some test jobs are succeeding: https://gitlab.com/buildroot.org/buildroot/-/jobs/4968059737 while some other are failing. magic-wormhole can override those timers with environment variables. See: https://github.com/magic-wormhole/magic-wormhole/blob/0.13.0/src/wormhole/cli/cmd_receive.py#L26 This commit sets those environment variable to larger values (100 seconds instread of 1 by default), to make sure the test will always pass. Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/4962923235 Reported-by: Romain Naour Signed-off-by: Julien Olivain Reviewed-by: Romain Naour Tested-by: Romain Naour Signed-off-by: Thomas Petazzoni (cherry picked from commit d44a888c320bd5fc850bccf5a1e09facb9fdad0d) Signed-off-by: Peter Korsgaard --- support/testing/tests/package/test_python_magic_wormhole.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/support/testing/tests/package/test_python_magic_wormhole.py b/support/testing/tests/package/test_python_magic_wormhole.py index d6541a2480..d1a37acbc6 100644 --- a/support/testing/tests/package/test_python_magic_wormhole.py +++ b/support/testing/tests/package/test_python_magic_wormhole.py @@ -56,7 +56,9 @@ class TestPythonPy3MagicWormhole(TestPythonPackageBase): cmd += "sleep 25" self.assertRunOk(cmd, timeout=30) - cmd = wormhole_cmd + " receive {}".format(code) + wormhole_env = "_MAGIC_WORMHOLE_TEST_KEY_TIMER=100 " + wormhole_env += "_MAGIC_WORMHOLE_TEST_VERIFY_TIMER=100 " + cmd = wormhole_env + wormhole_cmd + " receive {}".format(code) output, exit_code = self.emulator.run(cmd, timeout=35) self.assertEqual(exit_code, 0) self.assertEqual(output[0], text)