From 75c81a12f68f943af2966e737f882b3f4fc7a909 Mon Sep 17 00:00:00 2001 From: Serj Kalichev Date: Thu, 15 Nov 2018 18:45:42 +0300 Subject: [PATCH] package/pkg-generic.mk: fix show-build-order stdout pollution The commands like "make show-build-order" or "make -show-build-order" show the build order and then print "make[1]: Nothing to be done for 'show-build-order'" to stdout. It pollutes output. Technically this message is true but it's not true for user because he gets an information. The -show-build-order targets use $(info) for package name printing. The make utility doesn't consider the internal directive as a command so it think that it's "Nothing to be done". The patch adds the empty command to -show-build-order to inform make utility that taget makes some real actions. Signed-off-by: Serj Kalichev Acked-by: "Yann E. MORIN" [Thomas: invert $(info) and @:, as suggested by Yann.] Signed-off-by: Thomas Petazzoni --- package/pkg-generic.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk index f34f46afc8..7a95ea19cc 100644 --- a/package/pkg-generic.mk +++ b/package/pkg-generic.mk @@ -818,6 +818,7 @@ $(1)-show-recursive-rdepends: $$(TOPDIR)/support/scripts/graph-depends -p $(1) --reverse -f -q $(1)-show-build-order: $$(patsubst %,%-show-build-order,$$($(2)_FINAL_ALL_DEPENDENCIES)) + @: $$(info $(1)) $(1)-graph-depends: graph-depends-requirements