From 72c06e17641da8f3404e5969b78d000d508a0c2d Mon Sep 17 00:00:00 2001 From: Fabrice Fontaine Date: Wed, 18 Jan 2023 19:23:33 +0100 Subject: [PATCH] package/xxhash: set XXH_NO_INLINE_HINTS Set XXH_NO_INLINE_HINTS to marks all internal functions as static, giving the compiler full control on whether to inline or not. This will fix the following build failure raised since bump to version 0.8.1 in commit 5dbdb2535c649ee617595b8c4ae3cbba0ee37b97: In file included from xxhash.c:43: In function 'XXH3_accumulate', inlined from 'XXH3_hashLong_internal_loop' at xxhash.h:4390:9, inlined from 'XXH3_hashLong_64b_internal' at xxhash.h:4453:5, inlined from 'XXH3_hashLong_64b_withSecret' at xxhash.h:4473:12, inlined from 'XXH3_64bits_internal' at xxhash.h:4554:12, inlined from 'XXH3_64bits_withSecret' at xxhash.h:4570:12: xxhash.h:4196:1: error: inlining failed in call to 'always_inline' 'XXH3_accumulate_512_scalar': function not considered for inlining 4196 | XXH3_accumulate_512_scalar(void* XXH_RESTRICT acc, | ^~~~~~~~~~~~~~~~~~~~~~~~~~ Fixes: - http://autobuild.buildroot.org/results/f2c52238df97cc4c13117d8dc1423235231a094c Signed-off-by: Fabrice Fontaine Signed-off-by: Yann E. MORIN (cherry picked from commit 94b66fb49cd57d0863245fbe0a3dc0833e76aad0) Signed-off-by: Peter Korsgaard --- package/xxhash/xxhash.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/package/xxhash/xxhash.mk b/package/xxhash/xxhash.mk index 04bc98690f..40e3c2696c 100644 --- a/package/xxhash/xxhash.mk +++ b/package/xxhash/xxhash.mk @@ -28,6 +28,7 @@ endif define XXHASH_BUILD_CMDS $(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \ + CFLAGS="$(TARGET_CFLAGS) -DXXH_NO_INLINE_HINTS" \ $(XXHASH_TARGETS) endef