diff --git a/utils/checkpackagelib/lib_mk.py b/utils/checkpackagelib/lib_mk.py index d21e409b4c..5d48e8929c 100644 --- a/utils/checkpackagelib/lib_mk.py +++ b/utils/checkpackagelib/lib_mk.py @@ -317,8 +317,8 @@ class TypoInPackageVariable(_CheckFunction): if self.ALLOWED.match(variable): return if self.REGEX.search(variable) is None: - return ["{}:{}: possible typo: {} -> *{}*" - .format(self.filename, lineno, variable, self.package), + return ["{}:{}: possible typo, variable not properly prefixed: {} -> *{}_XXXX* ({}#_tips_and_tricks)" + .format(self.filename, lineno, variable, self.package, self.url_to_manual), text] diff --git a/utils/checkpackagelib/test_lib_mk.py b/utils/checkpackagelib/test_lib_mk.py index 208b1ecdc2..c86c55b9cb 100644 --- a/utils/checkpackagelib/test_lib_mk.py +++ b/utils/checkpackagelib/test_lib_mk.py @@ -546,27 +546,27 @@ TypoInPackageVariable = [ ('bad =', 'any.mk', 'OTHER_VAR = \n', - [['any.mk:1: possible typo: OTHER_VAR -> *ANY*', + [['any.mk:1: possible typo, variable not properly prefixed: OTHER_VAR -> *ANY_XXXX* (url#_tips_and_tricks)', 'OTHER_VAR = \n']]), ('bad +=', 'any.mk', 'OTHER_VAR += \n', - [['any.mk:1: possible typo: OTHER_VAR -> *ANY*', + [['any.mk:1: possible typo, variable not properly prefixed: OTHER_VAR -> *ANY_XXXX* (url#_tips_and_tricks)', 'OTHER_VAR += \n']]), ('ignore missing space', 'any.mk', 'OTHER_VAR= \n', - [['any.mk:1: possible typo: OTHER_VAR -> *ANY*', + [['any.mk:1: possible typo, variable not properly prefixed: OTHER_VAR -> *ANY_XXXX* (url#_tips_and_tricks)', 'OTHER_VAR= \n']]), ('use path in the warning', './any.mk', 'OTHER_VAR = \n', - [['./any.mk:1: possible typo: OTHER_VAR -> *ANY*', + [['./any.mk:1: possible typo, variable not properly prefixed: OTHER_VAR -> *ANY_XXXX* (url#_tips_and_tricks)', 'OTHER_VAR = \n']]), ('another name', 'other.mk', 'ANY_VAR = \n', - [['other.mk:1: possible typo: ANY_VAR -> *OTHER*', + [['other.mk:1: possible typo, variable not properly prefixed: ANY_VAR -> *OTHER_XXXX* (url#_tips_and_tricks)', 'ANY_VAR = \n']]), ('libc exception', './any.mk', @@ -583,7 +583,7 @@ TypoInPackageVariable = [ ('host (bad)', 'any.mk', 'HOST_OTHER_VAR = \n', - [['any.mk:1: possible typo: HOST_OTHER_VAR -> *ANY*', + [['any.mk:1: possible typo, variable not properly prefixed: HOST_OTHER_VAR -> *ANY_XXXX* (url#_tips_and_tricks)', 'HOST_OTHER_VAR = \n']]), ('provides', 'any.mk', @@ -599,13 +599,14 @@ TypoInPackageVariable = [ 'any.mk', 'ANY_PROVIDES = other\n' 'OTHERS_VAR = \n', - [['any.mk:2: possible typo: OTHERS_VAR -> *ANY*', + [['any.mk:2: possible typo, variable not properly prefixed: OTHERS_VAR -> *ANY_XXXX* (url#_tips_and_tricks)', 'OTHERS_VAR = \n']]), ('linux tool', 'package/linux-tools/linux-tool-cpupower.mk.in', 'CPUPOWER_DEPENDENCIES =\n' 'POWER_DEPENDENCIES +=\n', - [['package/linux-tools/linux-tool-cpupower.mk.in:2: possible typo: POWER_DEPENDENCIES -> *CPUPOWER*', + [['package/linux-tools/linux-tool-cpupower.mk.in:2: possible typo, variable not properly prefixed: ' + 'POWER_DEPENDENCIES -> *CPUPOWER_XXXX* (url#_tips_and_tricks)', 'POWER_DEPENDENCIES +=\n']]), ]