NetCube-Systems-Austria/kumquat-buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

toolchain/helpers: make sure we bail out when kernel headers check fails

Browse Source 
In commit 6136765b23 ("toolchain:
generate check-headers program under $(BUILD_DIR)"), the
check_kernel_headers_version function was simplified to not check the
return value of the check-kernel-headers.sh script, assuming that
"make" does bail out on the first failing command.

However, check_kernel_headers_version when used in $(2)_CONFIGURE_CMDS
from pkg-toolchain-external.mk, is called in a sequence of commands,
where the return value of each command is not checked. Therefore, a
failure of check-kernel-headers.sh no longer aborts the build.

Since all other macros are using this principle of calling "exit 1",
we revert back to the same for check_kernel_headers_version, as it was
done prior to 6136765b23.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Carlos Santos <unixmania@gmail.com>
Reviewed-by: Carlos Santos <unixmania@gmail.com>
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
This commit is contained in:
Thomas Petazzoni 2019-11-12 21:21:17 +01:00 committed by Yann E. MORIN
parent a7c4fce808
commit 68a0ec3758
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
toolchain/helpers.mk
View File

@ -163,7 +163,9 @@ copy_toolchain_sysroot = \
# $3: kernel version string, in the form: X.Y
#
check_kernel_headers_version = \
support/scripts/check-kernel-headers.sh $(1) $(2) $(3)
if ! support/scripts/check-kernel-headers.sh $(1) $(2) $(3); then \
exit 1; \
fi
#
# Check the specific gcc version actually matches the version in the