NetCube-Systems-Austria/kumquat-buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

package/racehound: fix comment

Browse Source 
racehound requires a kernel >= 3.14 to be built and to run.

However, the current conditions on the corresponding comments are wrong:
  - the comment about the kernel has a dependency on the requested
    headers
  - the comment on the toolchain features does not have this condition.

Thus, the comments are not shown/hidden under the appropriate
conditions, like in this situation:
  - toolchain with headers < 3.14 (e.g. Sourcery CodeBench x86/x86_64
    2012.09 with headers 3.5)
  - kernel 4.5 enabled

this comment is shown:
    racehound needs an Linux kernel >= 3.14 to be built

So, this is incorrect, because:
 1- a kernel >= 3.14 is indeed to be built
 2- the headers version mismatch is not reported

Fix that by moving the dependency on the kernel headers to the
appropriate comment and enhance it.

Since there is no way we can know the kernel version to be built, we can
not add such a condition; still, we leave the kernel message as-is.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
This commit is contained in:
Yann E. MORIN 2016-04-12 19:20:50 +02:00 committed by Peter Korsgaard
parent 4bcc4f3e6d
commit 64870d1828
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
package/racehound/Config.in
View File

@ -27,10 +27,11 @@ config BR2_PACKAGE_RACEHOUND
https://github.com/winnukem/racehound
comment "racehound needs an Linux kernel >= 3.14 to be built"
depends on !BR2_LINUX_KERNEL || !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_14
depends on !BR2_LINUX_KERNEL
depends on BR2_i386 || BR2_x86_64
comment "racehound needs a uClibc or (e)glibc toolchain w/ C++, wchar, dynamic library"
comment "racehound needs a uClibc or (e)glibc toolchain w/ C++, wchar, dynamic library, headers >= 3.14"
depends on BR2_i386 || BR2_x86_64
depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || BR2_STATIC_LIBS \
|| !(BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_GLIBC)
|| !(BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_GLIBC) \
|| !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_14