NetCube-Systems-Austria/kumquat-buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

utils/checkpackagelib: CommentsMenusPackagesOrder: only apply to top-level

Browse Source 
The CommentsMenusPackagesOrder test is broken in various ways for files
other than package/Config.in and package/Config.in.host. Therefore, the
script gives bogus errors for various other Config.in files.

However, we don't really want to check those other files. Indeed, many
of them have a non-alphabetical ordering for good reasons.

Therefore, skip the check for files other than package/Config.in and
package/Config.in.host.

Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/251214899

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Cc: Jerzy Grzegorek <jerzy.m.grzegorek@gmail.com>
Cc: Yann E. MORIN <yann.morin.1998@free.fr>
Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>
This commit is contained in:
Arnout Vandecappelle (Essensium/Mind) 2019-08-01 01:02:20 +02:00
parent 34e98c379f
commit 5603406bd1
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
utils/checkpackagelib/lib_config.py
View File

@ -72,6 +72,11 @@ class CommentsMenusPackagesOrder(_CheckFunction):
return len(self.state.split('-')) - 1
def check_line(self, lineno, text):
# We only want to force sorting for the top-level menus
if self.filename not in ["package/Config.in",
"package/Config.in.host"]:
return
if text.startswith("comment") or text.startswith("if") or \
text.startswith("menu"):