NetCube-Systems-Austria/kumquat-buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

support/testing: rename check_broken_links to has_broken_links

Browse Source 
has_broken_links makes it self-explanatory that this is a predicate
function, and that the return value tells whether there _are_ broken
links, not the opposite.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
This commit is contained in:
Luca Ceresoli 2017-05-16 22:45:29 +02:00 committed by Thomas Petazzoni
parent f8e1fdbe97
commit 52258901ec
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
support/testing/tests/toolchain/test_external.py
View File

@ -7,7 +7,7 @@ BR2_TARGET_ROOTFS_CPIO=y
# BR2_TARGET_ROOTFS_TAR is not set
"""
def check_broken_links(path):
def has_broken_links(path):
for root, dirs, files in os.walk(path):
for f in files:
fpath = os.path.join(root, f)
@ -20,9 +20,9 @@ class TestExternalToolchain(infra.basetest.BRTest):
# Check for broken symlinks
for d in ["lib", "usr/lib"]:
path = os.path.join(self.builddir, "staging", d)
self.assertFalse(check_broken_links(path))
self.assertFalse(has_broken_links(path))
path = os.path.join(self.builddir, "target", d)
self.assertFalse(check_broken_links(path))
self.assertFalse(has_broken_links(path))
interp = infra.get_elf_prog_interpreter(self.builddir,
self.toolchain_prefix,