From 4edfb8fef84d64a62d14d485e7cead3ab9e0b8b5 Mon Sep 17 00:00:00 2001 From: Jonathan Borne Date: Thu, 27 Jan 2022 14:53:39 +0100 Subject: [PATCH] package/binutils: remove libiberty from target install In BINUTILS_INSTALL_TARGET_CMDS (target!), libiberty is installed to STAGING_DIR. This is not necessary since libiberty is already unconditionally installed to staging in BINUTILS_INSTALL_STAGING_CMDS. Furthermore the presence of STAGING_DIR path in TARGET_CMDS is confusing and incorrect. Moreover libiberty is static only. Static libraries are only used at build time, not at run time so we do not need to install libiberty in target. This commit removes the incorrect libiberty install in TARGET_CMDS and adds a comment to clarify why we do not see libiberty installed on target. Signed-off-by: Jonathan Borne [yann.morin.1998@free.fr: - reword comment, move it toward the _INSTALL_TARGET_CMDS - rewrap and slightly reword commit log ] Signed-off-by: Yann E. MORIN --- package/binutils/binutils.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/binutils/binutils.mk b/package/binutils/binutils.mk index 13f61be035..8c4a1371ca 100644 --- a/package/binutils/binutils.mk +++ b/package/binutils/binutils.mk @@ -103,10 +103,10 @@ endef # If we don't want full binutils on target ifneq ($(BR2_PACKAGE_BINUTILS_TARGET),y) +# libiberty is static-only, so it is only installed to staging, above. define BINUTILS_INSTALL_TARGET_CMDS $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/bfd DESTDIR=$(TARGET_DIR) install $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/opcodes DESTDIR=$(TARGET_DIR) install - $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/libiberty DESTDIR=$(STAGING_DIR) install endef endif