From 4533e42622e46f2b8e0ce4d1936c6534393d3aa1 Mon Sep 17 00:00:00 2001 From: Sen Hastings Date: Tue, 13 Feb 2024 12:07:14 +0000 Subject: [PATCH] support/scripts/pkg-stats: make current version cell scrollable Currently, when the version string is "too long", it is arbitrarily truncated. This works well for commit hashes, because usually the truncation is long enough to provide a short hash that is still unique in the upstream VCS. However, there are non-hash-like versions strings that get truncated and wihch the discriminant part is toward the end. Yet, adapting the version cell to the widest versions string (most probably a git hash) is not very interesting; the table is already very large. Make the cell with the version string scrollable: we get to keep the best of both worlds: a narrow version cell, and a full-length version string that can be copy-pasted if needed. Signed-off-by: Sen Hastings [yann.morin.1998@free.fr: reword commit log] Signed-off-by: Yann E. MORIN --- support/scripts/pkg-stats | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/support/scripts/pkg-stats b/support/scripts/pkg-stats index 7835cb3d62..9307992d29 100755 --- a/support/scripts/pkg-stats +++ b/support/scripts/pkg-stats @@ -845,6 +845,13 @@ function expandField(fieldId){ .centered { text-align: center; } + + .current_version { + overflow: scroll; + width: 21ch; + padding: 10px 2px 10px 2px; + } + .correct, .nopatches, .good_url, .version-good, .cpe-ok, .cve-ok { background: #d2ffc4; } @@ -964,10 +971,7 @@ def dump_html_pkg(f, pkg): # Current version data_field_id = f'current_version__{pkg_css_class}' - if len(pkg.current_version) > 20: - current_version = pkg.current_version[:20] + "..." - else: - current_version = pkg.current_version + current_version = pkg.current_version f.write(f'
{current_version}
\n')