NetCube-Systems-Austria/kumquat-buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

jffs2: let makedevs create device files

Browse Source 
The common filesystem infrastructure in fs/common.mk uses a smart
combination of makedevs and fakeroot to create the device files in the
target filesystem images without being root. This technique is applied
to all filesystem formats that rely on this common infrastructure, and
JFFS2 is one of them.

Therefore, using the -D option of mkfs.jffs2, which allows to specify
a device table, is redundant with the usage of makedevs. And it is
worst than redundant: for some reason, -D does not create all device
files with the correct major and minor numbers, as reported in
bug #1771.

For coherence, we just remove the usage of mkfs.jffs2 -D option, and
rely on makedevs/fakeroot to create the device files.

This commit fixes bug #1771.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
This commit is contained in:
Thomas Petazzoni 2010-06-05 17:18:40 +02:00 committed by Peter Korsgaard
parent 2b42aae784
commit 3754c51560
2 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGES
View File

@ -8,6 +8,7 @@
Issues resolved (http://bugs.uclibc.org): Issues resolved (http://bugs.uclibc.org):
#1771: Fakeroot and the target/generic/device_table.txt create bad...
#1909: netperf-2.4.5 fails to build because of undeclared SOCK_DCCP #1909: netperf-2.4.5 fails to build because of undeclared SOCK_DCCP
2010.05, Released May 30th, 2010: 2010.05, Released May 30th, 2010:

4
fs/jffs2/jffs2.mk
View File

@ -32,10 +32,6 @@ JFFS2_OPTS += -n
SUMTOOL_OPTS += -n SUMTOOL_OPTS += -n
endif endif
ifneq ($(ROOTFS_DEVICE_TABLE),)
JFFS2_OPTS += -D $(ROOTFS_DEVICE_TABLE)
endif
ROOTFS_JFFS2_DEPENDENCIES = host-mtd ROOTFS_JFFS2_DEPENDENCIES = host-mtd
ifneq ($(BR2_TARGET_ROOTFS_JFFS2_SUMMARY),) ifneq ($(BR2_TARGET_ROOTFS_JFFS2_SUMMARY),)