From 2e32330c4a49f2422e88689b653f9d5ffb94077e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Guido=20Mart=C3=ADnez?= Date: Sat, 25 Jul 2015 16:07:39 -0300 Subject: [PATCH] Makefile: unexport O MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit After bee5745ccc2 ("Makefile: don't depend on the umask"), any use of "make O=" would leak $O into the enviroment for submakes, and it's inherited by package makefiles. Some package makefiles have protections to make sure they don't use the value of $O if it comes from the enviroment (Linux), but some don't (uClibc). This caused build failures when using a different output dir. Fix this by unconditionally unexporting the O variable, since we never need to have it set in the environment for packages, it should be only internally used by BR. Signed-off-by: Guido Martínez Acked-by: "Yann E. MORIN" Acked-by: Romain Naour Signed-off-by: Thomas Petazzoni --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 8b9c5d9141..90598844e2 100644 --- a/Makefile +++ b/Makefile @@ -329,6 +329,7 @@ unexport CONFIG_SITE unexport QMAKESPEC unexport TERMINFO unexport MACHINE +unexport O GNU_HOST_NAME := $(shell support/gnuconfig/config.guess)