NetCube-Systems-Austria/kumquat-buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

package/pkg-cmake.mk: add note about BUILD_STATIC_LIBS

Browse Source 
As BUILD_STATIC_LIBS is not a standard cmake variable (while
BUILD_SHARED_LIBS is) we shouldn't add it in pkg-cmake.mk, although
for some packages that would make sense. Therefore, add a note so we
don't forget about this abnormality.

See: https://cmake.org/cmake/help/v3.8/manual/cmake-variables.7.html#variables-that-change-behavior

Signed-off-by: Jan Heylen <jan.heylen@nokia.com>
[Thomas: rework the comment in the code.]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
This commit is contained in:
Jan Heylen 2018-01-04 13:28:29 +01:00 committed by Thomas Petazzoni
parent 7022190c4b
commit 2d0058e2d3
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
package/pkg-cmake.mk
View File

@ -80,6 +80,14 @@ ifndef $(2)_CONFIGURE_CMDS
ifeq ($(4),target)
# Configure package for target
#
# - We are passing BUILD_SHARED_LIBS because it is documented as a
# standard CMake variable to control the build of shared libraries
# (see https://cmake.org/cmake/help/v3.8/manual/cmake-variables.7.html#variables-that-change-behavior)
# - We are not passing BUILD_STATIC_LIBS because it is *not*
# documented as a standard CMake variable. If a package supports it,
# it must handle it explicitly.
#
define $(2)_CONFIGURE_CMDS
(mkdir -p $$($$(PKG)_BUILDDIR) && \
cd $$($$(PKG)_BUILDDIR) && \