From 2b7b68cfe56459f24684cdc2237b35b6c240cbf8 Mon Sep 17 00:00:00 2001 From: Adam Duskett Date: Wed, 17 Jan 2024 15:50:41 -0700 Subject: [PATCH] package/depot-tools: bump version to 8d14454ba4a35fd9d2483842b08815a2357ec86f The current depot-tools version is from Jul 13 2023, and there is a bug where when building with PPD enabled, building a Flutter application on my laptop running Fedora 39 or even in the Debian 11 container fails due to permission issues when running rsync such as: /usr/bin/sed: couldn't open temporary file [...]/output/per-package/flutter-gallery/host/share/flutter/sdk/.vpython-root/0e1e32/lib/python3.8/sed763MrF: Permission denied make: *** [package/pkg-generic.mk:267: [...]/output/build/flutter-gallery-2.10.2/.stamp_configured] Error 123 After several hours of attempting to find the exact cause of the issue by parsing git logs of the depot_tools repository and cross-referencing bugs on https://bugs.chromium.org/p/chromium/issues I am unable to determine the exact reason why the problem occurs or the exact commit that fixes the issue. However, updating depot-tools does indeed fix the issue, and looking at the source code between 4e87f5bf and 8d14454b shows improvements to several bash scripts, such as gclient, vpython3, and spid. All of which could be culprits of this bug. As flutter-engine is the only package that uses host-depot-tools, it is safe to update. This permission bug is present on PPD and normal builds, but causes a build to crash only on PPD because of rsyncing. On non-ppd builds, the bug only causes some minor annoyance when trying to run `make clean` because permission denials crop up when trying to remove the .vpython-root directory. Signed-off-by: Adam Duskett [yann.morin.1998@free.fr: - copy the cover-letter description as commit log ] Signed-off-by: Yann E. MORIN --- package/depot-tools/depot-tools.hash | 2 +- package/depot-tools/depot-tools.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package/depot-tools/depot-tools.hash b/package/depot-tools/depot-tools.hash index 2109096901..70218e4658 100644 --- a/package/depot-tools/depot-tools.hash +++ b/package/depot-tools/depot-tools.hash @@ -1,3 +1,3 @@ # Locally calculated -sha256 8e0bccdd6b1231f58d5453dc14a5e1d195295ac8d466dec34961e951e946b50b depot-tools-4e87f5bfe244e903f712408ea68dc3c3a6fe2d00-br1.tar.gz +sha256 5da23d7558975093c6a732f5743c7f224d16dd3f878a6a1b577b1b127a4098cc depot-tools-8d14454ba4a35fd9d2483842b08815a2357ec86f-br1.tar.gz sha256 984523ee987f4e8b72d61df37d8f1189a7077cd4b77e41a397e35593b297a29d LICENSE diff --git a/package/depot-tools/depot-tools.mk b/package/depot-tools/depot-tools.mk index e3b840f29a..634258ffbb 100644 --- a/package/depot-tools/depot-tools.mk +++ b/package/depot-tools/depot-tools.mk @@ -4,7 +4,7 @@ # ################################################################################ -DEPOT_TOOLS_VERSION = 4e87f5bfe244e903f712408ea68dc3c3a6fe2d00 +DEPOT_TOOLS_VERSION = 8d14454ba4a35fd9d2483842b08815a2357ec86f DEPOT_TOOLS_SITE = https://chromium.googlesource.com/chromium/tools/depot_tools DEPOT_TOOLS_SITE_METHOD = git DEPOT_TOOLS_LICENSE = BSD-3-Clause