graph-depends: rename the variable to pass the max depth

There will soon be new options to the graph-depends script, which we
can only sanely pass via environment variables.

Currently, we use such an environment variable to pass the maximum depth
of the dependency graph; the name of that variable is explicit that it
contains just the depth.

However, there has been so far no release of Buildroot which would make
use of that variable, so no user should have come to rely on it.

Rename that variable so it is less specific, and more generic, so it can
be used to pass more options to graph-depends.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
Cc: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
This commit is contained in:
Yann E. MORIN 2014-05-16 23:05:13 +02:00 committed by Peter Korsgaard
parent 3ab9774f23
commit 287a88286b
4 changed files with 14 additions and 5 deletions

View File

@ -150,7 +150,6 @@ endif
# Need that early, before we scan packages # Need that early, before we scan packages
# Avoids doing the $(or...) everytime # Avoids doing the $(or...) everytime
BR_GRAPH_OUT := $(or $(BR2_GRAPH_OUT),pdf) BR_GRAPH_OUT := $(or $(BR2_GRAPH_OUT),pdf)
BR_GRAPH_DEPTH := $(or $(BR2_GRAPH_DEPTH),0)
BUILD_DIR := $(BASE_DIR)/build BUILD_DIR := $(BASE_DIR)/build
BINARIES_DIR := $(BASE_DIR)/images BINARIES_DIR := $(BASE_DIR)/images
@ -675,7 +674,7 @@ graph-build: $(O)/build/build-time.log
graph-depends: graph-depends:
@$(INSTALL) -d $(O)/graphs @$(INSTALL) -d $(O)/graphs
@cd "$(CONFIG_DIR)"; \ @cd "$(CONFIG_DIR)"; \
$(TOPDIR)/support/scripts/graph-depends -d $(BR_GRAPH_DEPTH) \ $(TOPDIR)/support/scripts/graph-depends $(BR2_GRAPH_DEPS_OPTS) \
|tee $(O)/graphs/$(@).dot \ |tee $(O)/graphs/$(@).dot \
|dot -T$(BR_GRAPH_OUT) -o $(O)/graphs/$(@).$(BR_GRAPH_OUT) |dot -T$(BR_GRAPH_OUT) -o $(O)/graphs/$(@).$(BR_GRAPH_OUT)

View File

@ -92,8 +92,8 @@ to +make+ or set in the environment:
build-time graphs build-time graphs
* +BR2_GRAPH_OUT+ to set the filetype of generated graphs, either +pdf+ (the * +BR2_GRAPH_OUT+ to set the filetype of generated graphs, either +pdf+ (the
default), or +png+. default), or +png+.
* +BR2_GRAPH_DEPTH+ (an integer) to limit the depth of the dependency graph. * +BR2_GRAPH_DEPS_OPTS+ to pass extra options to the dependency graph; see
The default, +0+, is to not limit the depth. xref:graph-depends[] for the accepted options
An example that uses config files located in the toplevel directory and An example that uses config files located in the toplevel directory and
in your $HOME: in your $HOME:
@ -198,6 +198,16 @@ supported.
BR2_GRAPH_OUT=svg make graph-depends BR2_GRAPH_OUT=svg make graph-depends
-------------------------------- --------------------------------
The +graph-depends+ behaviour can be controlled by setting options in the
+BR2_GRAPH_DEPS_OPTS+ environment variable. The accepted options are:
* +--depth N+, +-d N+, to limit the dependency depth to +N+ levels. The
default, +0+, means no limit.
--------------------------------
BR2_GRAPH_DEPS_OPTS='-d 3' make graph-depends
--------------------------------
=== Graphing the build duration === Graphing the build duration
[[graph-duration]] [[graph-duration]]

0
foo Normal file
View File

View File

@ -512,7 +512,7 @@ $(1)-show-depends:
$(1)-graph-depends: $(1)-graph-depends:
@$(INSTALL) -d $(O)/graphs @$(INSTALL) -d $(O)/graphs
@cd "$(CONFIG_DIR)"; \ @cd "$(CONFIG_DIR)"; \
$(TOPDIR)/support/scripts/graph-depends -p $(1) -d $(BR_GRAPH_DEPTH) \ $(TOPDIR)/support/scripts/graph-depends -p $(1) $(BR2_GRAPH_DEPS_OPTS) \
|tee $(O)/graphs/$$(@).dot \ |tee $(O)/graphs/$$(@).dot \
|dot -T$(BR_GRAPH_OUT) -o $(O)/graphs/$$(@).$(BR_GRAPH_OUT) |dot -T$(BR_GRAPH_OUT) -o $(O)/graphs/$$(@).$(BR_GRAPH_OUT)