NetCube-Systems-Austria/kumquat-buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

package/sysrepo: fix SysV init script

Browse Source 
The current script (S51sysrepo-plugind) is not able to stop the daemon.

Possible options to fix the problem:

A) By adding the "-m -p $PIDFILE" option to start the pid file will be
   created but it will not contain the correct PID used by the daemon.
   This is obviously because the daemon forks.
B) By not starting the daemon in background (sysrepo-plugind -d) and
   let do it by start-stop-daemon with "-b" option. But then the log
   messages of the daemon will not longer ends in the syslog but to stderr.
C) Start the daemon without a pidfile and stop the daemon with the
   "-x" option.

The only valid option is C to fix that.

Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
[yann.morin.1998@free.fr: introduce EXECUTABLE]
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
(cherry picked from commit 1a14a838ea)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
This commit is contained in:
Heiko Thiery 2020-05-27 09:11:13 +02:00 committed by Peter Korsgaard
parent 5b076d0ea2
commit 1f0116e448
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
package/sysrepo/S51sysrepo-plugind
View File

@ -1,7 +1,7 @@
#!/bin/sh
DAEMON="sysrepo-plugind"
PIDFILE="/var/run/$DAEMON.pid"
EXECUTABLE="/usr/bin/$DAEMON"
SYSREPO_PLUGIND_ARGS=""
@ -10,7 +10,7 @@ SYSREPO_PLUGIND_ARGS=""
start() {
printf 'Starting %s: ' "$DAEMON"
start-stop-daemon -S -q -x "/usr/bin/$DAEMON" \
start-stop-daemon -S -q -x "$EXECUTABLE" \
-- $SYSREPO_PLUGIND_ARGS
status=$?
if [ "$status" -eq 0 ]; then
@ -23,7 +23,7 @@ start() {
stop() {
printf 'Stopping %s: ' "$DAEMON"
start-stop-daemon -K -q -p $PIDFILE
start-stop-daemon -K -q -x "$EXECUTABLE"
status=$?
if [ "$status" -eq 0 ]; then
echo "OK"