NetCube-Systems-Austria/kumquat-buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libftdi: remove BR2_ARCH_HAS_ATOMICS dependency

Browse Source 
In commit 669ce8c75e ("libftdi: add
dependency on atomic operations"), a dependency on
BR2_ARCH_HAS_ATOMICS was added to the libftdi package to fix a build
failure occuring on the ARC architecture due to the missing
__sync_fetch_and_add_4 function:

../ftdipp/.libs/libftdipp.so: undefined reference to `__sync_fetch_and_add_4'

However, today, even on the SPARC architecture that does not implement
any of the __sync built-ins, libftdi and its C++ binding libftdipp
build fine. ARC was also tested and builds fine.

Therefore, we remove the BR2_ARCH_HAS_ATOMICS dependency from libftdi,
and also from flashrom, in which it was only present due to the
selection of libftdi. Note that anyway flashrom is available only for
i386 and x86_64, both of which implement all the __sync built-ins.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
This commit is contained in:
Thomas Petazzoni 2016-01-25 00:07:48 +01:00
parent f1550e3eb0
commit 1e1333fd8f
2 changed files with 0 additions and 4 deletions
package
flashrom
Config.in
libftdi
Config.in

2
package/flashrom/Config.in
View File

@ -8,7 +8,6 @@ config BR2_PACKAGE_FLASHROM
select BR2_PACKAGE_DMIDECODE
depends on BR2_i386 || BR2_x86_64
depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
depends on BR2_ARCH_HAS_ATOMICS # libftdi
help
flashrom is a utility for identifying, reading, writing,
verifying and erasing flash chips. It is designed to flash
@ -20,5 +19,4 @@ config BR2_PACKAGE_FLASHROM
comment "flashrom needs a toolchain w/ threads"
depends on BR2_i386 || BR2_x86_64
depends on BR2_ARCH_HAS_ATOMICS
depends on !BR2_TOOLCHAIN_HAS_THREADS

2
package/libftdi/Config.in
View File

@ -1,7 +1,6 @@
config BR2_PACKAGE_LIBFTDI
bool "libftdi"
depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
depends on BR2_ARCH_HAS_ATOMICS
select BR2_PACKAGE_LIBUSB
select BR2_PACKAGE_LIBUSB_COMPAT
help
@ -27,5 +26,4 @@ comment "libftdi C++ bindings need a toolchain w/ wchar, C++"
endif # BR2_PACKAGE_LIBFTDI
comment "libftdi needs a toolchain w/ threads"
depends on BR2_ARCH_HAS_ATOMICS
depends on !BR2_TOOLCHAIN_HAS_THREADS