From 1c4dd7bb5d96f4529a83ae7061c32062904b5b3c Mon Sep 17 00:00:00 2001 From: "Yann E. MORIN" Date: Sat, 27 Apr 2019 18:06:14 +0200 Subject: [PATCH] package/binutils: don't override the build command In 1d42d0acca (binutils: ensure TARGET_CONFIGURE_ARGS is taken into consideration for subdirs), the whole BUILD_CMDS was overriden in an attempt to ensure that the target configure args (in fact, environment variables) are indeed passed in the environment of the build command. However, there is no reason to override the whole command, when we can simply specify additional environment variables, as supported by the autotools infra. Signed-off-by: Yann E. MORIN Cc: Peter Korsgaard Signed-off-by: Peter Korsgaard --- package/binutils/binutils.mk | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/package/binutils/binutils.mk b/package/binutils/binutils.mk index 6798356ff2..c70ba13b04 100644 --- a/package/binutils/binutils.mk +++ b/package/binutils/binutils.mk @@ -91,9 +91,7 @@ HOST_BINUTILS_CONF_OPTS = \ # binutils run configure script of subdirs at make time, so ensure # our TARGET_CONFIGURE_ARGS are taken into consideration for those -define BINUTILS_BUILD_CMDS - $(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_ARGS) $(MAKE) $(BINUTILS_MAKE_OPTS) -C $(@D) -endef +BINUTILS_MAKE_ENV = $(TARGET_CONFIGURE_ARGS) # We just want libbfd, libiberty and libopcodes, # not the full-blown binutils in staging