From 138328309dec336250bc5e7cf3403462d5a68ecd Mon Sep 17 00:00:00 2001 From: "Yann E. MORIN" Date: Sat, 13 Nov 2021 14:28:14 +0100 Subject: [PATCH] support/dependencies: avoid spurious warning on print-vars When calling 'printvars', the 'suitable-host-package' macro is printed (a macro is just a variable like the others, after all, just with some parameters). Because it is printed as a variable, it is missing its parameters, but it still tries to evaluate the $(shell) construct. This causes spurious warning: make[1]: support/dependencies/check-host-.sh: Command not found Only try and call the script if there is actually a tool to check for. Signed-off-by: Yann E. MORIN (cherry picked from commit 77304e5143bf77e9fd2f8125807bbf9665cda8bc) Signed-off-by: Peter Korsgaard --- support/dependencies/dependencies.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/support/dependencies/dependencies.mk b/support/dependencies/dependencies.mk index 4fac5c731b..a7bb1a6080 100644 --- a/support/dependencies/dependencies.mk +++ b/support/dependencies/dependencies.mk @@ -15,7 +15,7 @@ else # script should use 'which' to find a candidate. The script should return # the path to the suitable host tool, or nothing if no suitable tool was found. define suitable-host-package -$(shell support/dependencies/check-host-$(1).sh $(2)) +$(if $(1),$(shell support/dependencies/check-host-$(1).sh $(2))) endef endif # host utilities needs host-tar to extract the source code tarballs, so