From 0bc221581c9f9781c1f053210ee43a2da71cf2f3 Mon Sep 17 00:00:00 2001 From: "Yann E. MORIN" Date: Fri, 1 Jun 2018 20:01:57 +0200 Subject: [PATCH] linux: may fail to boot for binutils 2.29+ even without armv7m Commit f13477b (linux: config.in: add comment for Arm Cortex-M) added a comment so that the user that the linux kernel may miscompile with binutils 2.29+, when the target is an armv7m CPU. However, the real trigger is a compilation in thumb2 mode, which happens to be the only option for armv7m CPUs. We can't know whether the kernel will be built in arm or thumb2 mode, though, because we do not have that information: it is only available in the Linux' .config file, which we don;t have access to at the time we run our menuconfig. So, relax the conditions under which the comment is made, so that it appears as soon as binutils are >= 2.29 (i.e. not 2.28, which is the oldest we support) for ARM CPUs. [Peter: reword comment] Signed-off-by: "Yann E. MORIN" Cc: Christophe Priouzeau Cc: Laurent GONZALEZ Cc: Peter Korsgaard Cc: Thomas Petazzoni Cc: Arnout Vandecappelle Signed-off-by: Peter Korsgaard (cherry picked from commit c2c0623bff4a93120642d68dcec247ac2729fa09) Signed-off-by: Peter Korsgaard --- linux/Config.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux/Config.in b/linux/Config.in index 2ebddb403b..8007271cb7 100644 --- a/linux/Config.in +++ b/linux/Config.in @@ -8,8 +8,8 @@ config BR2_LINUX_KERNEL if BR2_LINUX_KERNEL -comment "Linux kernel will not boot with binutils >= 2.29" - depends on BR2_ARM_CPU_ARMV7M +comment "Linux kernel may fail to boot with binutils >= 2.29" + depends on BR2_arm || BR2_armeb depends on !BR2_BINUTILS_VERSION_2_28_X # Packages that need to have a kernel with support for loadable modules,