NetCube-Systems-Austria/kumquat-buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

package/ne10: install shared libraries only when built

Browse Source 
The install to staging commands of the ne10 package are careful to
install the shared libraries only if they are built, but we forgot to
use the same care for the install to target commands, causing a build
failure on BR2_STATIC_LIBS=y configurations as no shared library was
built:

cp: cannot stat '/home/autobuild/autobuild/instance-15/output-1/build/ne10-1.2.1/modules/libNE10*.so*': No such file or directory

This commit fixes this by guarding the target installation commands to
BR2_STATIC_LIBS being empty.

The problem exists since the package was introduced in commit
318f3db0dc ("ne10: new package"), a good
10 years ago. Most likely it was not seen for many years as this
package is only available for ARM with NEON and AArch64, and we were
not testing fully static builds, except for ARMv5 that don't have
NEON. Now that we are doing more random testing, the problem started
being visible.

Fixes:

  http://autobuild.buildroot.net/results/45b2c1af052271bc2f1bb96544f138d29e4f7dfd/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: Arnout Vandecappelle <arnout@mind.be>
This commit is contained in:
Thomas Petazzoni 2023-09-21 12:28:56 +02:00 committed by Arnout Vandecappelle
parent 9a9a41f8df
commit 0b764a7d1e
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package/ne10/ne10.mk
View File

@ -42,8 +42,10 @@ define NE10_INSTALL_STAGING_CMDS
$(NE10_INSTALL_STAGING_SHARED_LIB)
endef
ifeq ($(BR2_STATIC_LIBS),)
define NE10_INSTALL_TARGET_CMDS
cp -dpf $(@D)/modules/libNE10*.so* $(TARGET_DIR)/usr/lib/
endef
endif
$(eval $(cmake-package))