NetCube-Systems-Austria/kumquat-buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

testing/tests/download: test case for git refs

Browse Source 
All upcoming tests for git refs will rely on the return code of make to
determine whether a git ref can be downloaded or not and also to
determine whether the downloaded content is correct (all of this taking
advantage of the check-hash mechanism already in place for git
packages).
So to avoid false results i.e. in the case the check-hash mechanism
become broken in the master branch, add some sanity checks before the
actual test of download git refs.

Add the minimum test case for git refs containing only sanity checks.
Reuse the commit in the static repo.
Add a br2-external with two packages to check that:
 - trying to download an invalid sha1 generates an error;
 - downloading a valid sha1 that contains unexpected content generates
   an error.

In order to ease the maintenance and review, each upcoming patch adding
checks to this test case will add at same time the commits to the static
repo, the equivalent packages to the br2-external and code to the test
case.

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@datacom.ind.br>
Cc: Arnout Vandecappelle <arnout@mind.be>
Tested-by: Matthew Weber <matthew.weber@rockwellcollins.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
This commit is contained in:
Ricardo Martincoski 2018-05-11 23:58:28 -03:00 committed by Arnout Vandecappelle (Essensium/Mind)
parent a2dd1bf25d
commit 0a90740488
8 changed files with 49 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.gitlab-ci.yml
View File

@ -292,6 +292,7 @@ tests.core.test_timezone.TestGlibcAllTimezone: *runtime_test
tests.core.test_timezone.TestGlibcNonDefaultLimitedTimezone: *runtime_test
tests.core.test_timezone.TestNoTimezone: *runtime_test
tests.download.test_git.TestGitHash: *runtime_test
tests.download.test_git.TestGitRefs: *runtime_test
tests.fs.test_ext.TestExt2: *runtime_test
tests.fs.test_ext.TestExt2r1: *runtime_test
tests.fs.test_ext.TestExt3: *runtime_test

0
support/testing/tests/download/br2-external/git-refs/Config.in Normal file
View File

1
support/testing/tests/download/br2-external/git-refs/external.desc Normal file
View File

@ -0,0 +1 @@
name: GIT_REFS

4
support/testing/tests/download/br2-external/git-refs/external.mk Normal file
View File

@ -0,0 +1,4 @@
include $(sort $(wildcard $(BR2_EXTERNAL_GIT_REFS_PATH)/package/*/*.mk))
# Get the git server port number from the test infra
GITREMOTE_PORT_NUMBER ?= 9418

2
support/testing/tests/download/br2-external/git-refs/package/git-wrong-content/git-wrong-content.hash Normal file
View File

@ -0,0 +1,2 @@
sha256 04715901977503d1df650e0959f4d31d8e7b105e2ac99a2182e0652b8f13baa1 git-wrong-content-a238b1dfcd825d47d834af3c5223417c8411d90d.tar.gz
sha256 0000000000000000000000000000000000000000000000000000000000000000 file

11
support/testing/tests/download/br2-external/git-refs/package/git-wrong-content/git-wrong-content.mk Normal file
View File

@ -0,0 +1,11 @@
################################################################################
#
# git-wrong-content
#
################################################################################
GIT_WRONG_CONTENT_VERSION = a238b1dfcd825d47d834af3c5223417c8411d90d
GIT_WRONG_CONTENT_SITE = git://localhost:$(GITREMOTE_PORT_NUMBER)/repo.git
GIT_WRONG_CONTENT_LICENSE_FILES = file
$(eval $(generic-package))

11
support/testing/tests/download/br2-external/git-refs/package/git-wrong-sha1/git-wrong-sha1.mk Normal file
View File

@ -0,0 +1,11 @@
################################################################################
#
# git-wrong-sha1
#
################################################################################
GIT_WRONG_SHA1_VERSION = 0000000000000000000000000000000000000000
GIT_WRONG_SHA1_SITE = git://localhost:$(GITREMOTE_PORT_NUMBER)/repo.git
GIT_WRONG_SHA1_LICENSE_FILES = file
$(eval $(generic-package))

19
support/testing/tests/download/test_git.py
View File

@ -33,6 +33,15 @@ class GitTestBase(infra.basetest.BRTest):
"{}-source".format(package)],
env)
def check_download(self, package):
# store downloaded tarball inside the output dir so the test infra
# cleans it up at the end
env = {"BR2_DL_DIR": os.path.join(self.builddir, "dl"),
"GITREMOTE_PORT_NUMBER": str(self.gitremote.port)}
self.b.build(["{}-dirclean".format(package),
"{}-legal-info".format(package)],
env)
class TestGitHash(GitTestBase):
br2_external = [infra.filepath("tests/download/br2-external/git-hash")]
@ -42,3 +51,13 @@ class TestGitHash(GitTestBase):
self.check_hash("bad")
self.check_hash("good")
self.check_hash("nohash")
class TestGitRefs(GitTestBase):
br2_external = [infra.filepath("tests/download/br2-external/git-refs")]
def test_run(self):
with self.assertRaises(SystemError):
self.check_download("git-wrong-content")
with self.assertRaises(SystemError):
self.check_download("git-wrong-sha1")