From 0610de14901e5ad0f6c9b4db488477db47d2ff57 Mon Sep 17 00:00:00 2001 From: James Knight Date: Thu, 3 Sep 2015 11:00:09 -0400 Subject: [PATCH] package/bash: indicate getcwd is malloc-supported When Bash attempts to find the current working directory, it uses a C library call `getcwd` to resolve it. When cross-compiling, the configuration process cannot determine if the target system's C library can support an "unfixed" path length. Therefore, Bash will fallback to a size of `PATH_MAX` for determining the current working directory. When using OverlayFS (and possible other file systems), this becomes an issue since file paths can commonly exceed standard `PATH_MAX` length. This typically results in the following error appearing: error retrieving current directory: [...] Common C library `getcwd` calls can default to a higher limit (usually the system's page size). The current configurable C libraries (as of at least 2015.08) support a zero (0) size buffer length. Most use the system's page size; musl, being an exception, which defaults to `PATH_MAX` (as Bash was doing). Since these C libraries support allocating buffer space with a zero (0) provided size, the following configuration change allows Bash to support getting a larger-length'ed working directory on target's that support it. Signed-off-by: James Knight Acked-by: Arnout Vandecappelle (Essensium/Mind) Signed-off-by: Peter Korsgaard --- package/bash/bash.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/package/bash/bash.mk b/package/bash/bash.mk index 9865e1971d..97d7182e2f 100644 --- a/package/bash/bash.mk +++ b/package/bash/bash.mk @@ -16,6 +16,7 @@ BASH_LICENSE_FILES = COPYING BASH_CONF_ENV += \ ac_cv_rl_prefix="$(STAGING_DIR)" \ ac_cv_rl_version="$(READLINE_VERSION)" \ + bash_cv_getcwd_malloc=yes \ bash_cv_job_control_missing=present \ bash_cv_sys_named_pipes=present \ bash_cv_func_sigsetjmp=present \