From 01cb02cfaecb34fd7d413775673e78272c68f85f Mon Sep 17 00:00:00 2001 From: Ricardo Martincoski Date: Sun, 27 Nov 2022 10:07:22 -0300 Subject: [PATCH] package/pugixml: unconditionally set BUILD_DEFINES The ifdef construct intended to avoid passing -DBUILD_DEFINES="" was never needed, because even upstream version v1.9 used in 2019 when the configuration options were added, can handle an empty string for BUILD_DEFINES. In fact an empty string is the default for v1.9 if it is not passed during configure. Also, the host variant already sets BUILD_DEFINES unconditionally. So remove the unneeded conditional. Cc: Arnout Vandecappelle Cc: Theo Debrouwere Signed-off-by: Ricardo Martincoski Signed-off-by: Peter Korsgaard --- package/pugixml/pugixml.mk | 2 -- 1 file changed, 2 deletions(-) diff --git a/package/pugixml/pugixml.mk b/package/pugixml/pugixml.mk index c796186827..7d4f47c6fa 100644 --- a/package/pugixml/pugixml.mk +++ b/package/pugixml/pugixml.mk @@ -29,9 +29,7 @@ ifeq ($(BR2_PACKAGE_PUGIXML_HEADER_ONLY),y) PUGIXML_BUILD_DEFINES += PUGIXML_HEADER_ONLY endif -ifdef PUGIXML_BUILD_DEFINES PUGIXML_CONF_OPTS += -DBUILD_DEFINES="$(subst $(space),;,$(PUGIXML_BUILD_DEFINES))" -endif HOST_PUGIXML_CONF_OPTS += \ -DBUILD_PKGCONFIG=ON \