2011-01-26 22:18:43 +01:00
|
|
|
################################################################################
|
|
|
|
|
# CMake package infrastructure
|
|
|
|
|
#
|
|
|
|
|
# This file implements an infrastructure that eases development of
|
|
|
|
|
# package .mk files for CMake packages. It should be used for all
|
|
|
|
|
# packages that use CMake as their build system.
|
|
|
|
|
#
|
|
|
|
|
# See the Buildroot documentation for details on the usage of this
|
|
|
|
|
# infrastructure
|
|
|
|
|
#
|
|
|
|
|
# In terms of implementation, this CMake infrastructure requires
|
2014-07-24 20:07:02 +02:00
|
|
|
# the .mk file to only specify metadata information about the
|
2011-01-26 22:18:43 +01:00
|
|
|
# package: name, version, download URL, etc.
|
|
|
|
|
#
|
|
|
|
|
# We still allow the package .mk file to override what the different
|
|
|
|
|
# steps are doing, if needed. For example, if <PKG>_BUILD_CMDS is
|
|
|
|
|
# already defined, it is used as the list of commands to perform to
|
|
|
|
|
# build the package, instead of the default CMake behaviour. The
|
|
|
|
|
# package can also define some post operation hooks.
|
|
|
|
|
#
|
|
|
|
|
################################################################################
|
|
|
|
|
|
2014-12-14 20:12:01 +01:00
|
|
|
# Set compiler variables.
|
|
|
|
|
ifeq ($(BR2_CCACHE),y)
|
2015-01-23 21:17:04 +01:00
|
|
|
CMAKE_HOST_C_COMPILER = $(HOST_DIR)/usr/bin/ccache
|
|
|
|
|
CMAKE_HOST_CXX_COMPILER = $(HOST_DIR)/usr/bin/ccache
|
|
|
|
|
CMAKE_HOST_C_COMPILER_ARG1 = $(HOSTCC_NOCCACHE)
|
|
|
|
|
CMAKE_HOST_CXX_COMPILER_ARG1 = $(HOSTCXX_NOCCACHE)
|
2014-12-14 20:12:01 +01:00
|
|
|
else
|
2015-01-23 21:17:04 +01:00
|
|
|
CMAKE_HOST_C_COMPILER = $(HOSTCC)
|
|
|
|
|
CMAKE_HOST_CXX_COMPILER = $(HOSTCXX)
|
2014-12-14 20:12:01 +01:00
|
|
|
endif
|
|
|
|
|
|
2015-02-11 18:52:21 +01:00
|
|
|
ifneq ($(QUIET),)
|
|
|
|
|
CMAKE_QUIET = -DCMAKE_RULE_MESSAGES=OFF -DCMAKE_INSTALL_MESSAGE=NEVER
|
|
|
|
|
endif
|
|
|
|
|
|
2011-01-26 22:18:43 +01:00
|
|
|
################################################################################
|
2012-07-03 00:07:08 +02:00
|
|
|
# inner-cmake-package -- defines how the configuration, compilation and
|
2011-01-26 22:18:43 +01:00
|
|
|
# installation of a CMake package should be done, implements a few hooks to
|
|
|
|
|
# tune the build process and calls the generic package infrastructure to
|
|
|
|
|
# generate the necessary make targets
|
|
|
|
|
#
|
|
|
|
|
# argument 1 is the lowercase package name
|
2014-07-24 20:57:41 +02:00
|
|
|
# argument 2 is the uppercase package name, including a HOST_ prefix
|
2011-01-26 22:18:43 +01:00
|
|
|
# for host packages
|
|
|
|
|
# argument 3 is the uppercase package name, without the HOST_ prefix
|
|
|
|
|
# for host packages
|
2014-02-05 10:44:03 +01:00
|
|
|
# argument 4 is the type (target or host)
|
2011-01-26 22:18:43 +01:00
|
|
|
################################################################################
|
|
|
|
|
|
2012-07-03 00:07:08 +02:00
|
|
|
define inner-cmake-package
|
2011-01-26 22:18:43 +01:00
|
|
|
|
|
|
|
|
$(2)_CONF_ENV ?=
|
2014-09-27 21:32:44 +02:00
|
|
|
$(2)_CONF_OPTS ?=
|
infra: consistently use double dollar signs inside inner-xxx-targets
The inner-xxx-targets in the buildroot package infrastructures are
evaluated using $(eval) which causes variable references to be a bit
different than in regular make code. As we want most references to be
expanded only at the time of the $(eval) we should not use standard
references $(VAR) but rather use double dollar signs $$(VAR). This includes
function references like $(call), $(subst), etc. The only exception is the
reference to pkgdir/pkgname and numbered variables, which are parameters to
the inner block: $(1), $(2), etc.
This patch introduces consistent usage of double-dollar signs throughout the
different inner-xxx-targets blocks.
In some cases, this would potentially cause circular references, in
particular when the value of HOST_FOO_VAR would be obtained from the
corresponding FOO_VAR if HOST_FOO_VAR is not defined. In these cases, a test
is added to check for a host package (the only case where such constructions
are relevant; these are not circular).
Benefits of these changes are:
- behavior of variables is now again as expected. For example, setting
$(2)_VERSION = virtual in pkg-virtual.mk will effectively work, while
originally it would cause very odd results.
- The output of 'make printvars' is now much more useful. This target shows
the value of all variables, and the expression that led to that value.
However, if the expression was coming from an inner-xxx-targets block, and
was using single dollar signs, it would show in printvars as
VAR = value (value)
while if double dollar signs are used, it would effectively look like
VAR = value (actual expression)
as is intended.
This improvement is for example effective for FOO_DL_VERSION, FOO_RAWNAME,
FOO_SITE_METHOD and FOO_MAKE.
The correctness of this patch has been verified using 'make printvars',
'make manual' and 'make legal-info' before and after applying this patch,
and comparing the output.
Insight-provided-by: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-06-11 21:12:24 +02:00
|
|
|
$(2)_MAKE ?= $$(MAKE)
|
2011-01-26 22:18:43 +01:00
|
|
|
$(2)_MAKE_ENV ?=
|
2014-09-27 21:32:38 +02:00
|
|
|
$(2)_MAKE_OPTS ?=
|
2014-10-04 19:32:12 +02:00
|
|
|
$(2)_INSTALL_OPTS ?= install
|
pkg-cmake: Skip compilation in installation step
With CMake build system, the "make install" command always compiles
before installing, to make sure that everything is up-to-date.
In Buildroot environment, this is quite useless, because the package
has always already been compiled, either at first build, or when
invoking "make <package>-rebuild".
In all cases, when it comes to staging or target installation step, the
package has just been compiled.
Using "make install/fast" - in order to skip the compilation step - is
therefore more appropriate, more consistent with what other build
systems do, and saves time when you need to rebuild your package.
Signed-off-by: Cédric Marie <cedric.marie@openmailbox.org>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2015-04-22 22:11:56 +02:00
|
|
|
$(2)_INSTALL_STAGING_OPTS ?= DESTDIR=$$(STAGING_DIR) install/fast
|
|
|
|
|
$(2)_INSTALL_TARGET_OPTS ?= DESTDIR=$$(TARGET_DIR) install/fast
|
2011-01-26 22:18:43 +01:00
|
|
|
|
infra: consistently use double dollar signs inside inner-xxx-targets
The inner-xxx-targets in the buildroot package infrastructures are
evaluated using $(eval) which causes variable references to be a bit
different than in regular make code. As we want most references to be
expanded only at the time of the $(eval) we should not use standard
references $(VAR) but rather use double dollar signs $$(VAR). This includes
function references like $(call), $(subst), etc. The only exception is the
reference to pkgdir/pkgname and numbered variables, which are parameters to
the inner block: $(1), $(2), etc.
This patch introduces consistent usage of double-dollar signs throughout the
different inner-xxx-targets blocks.
In some cases, this would potentially cause circular references, in
particular when the value of HOST_FOO_VAR would be obtained from the
corresponding FOO_VAR if HOST_FOO_VAR is not defined. In these cases, a test
is added to check for a host package (the only case where such constructions
are relevant; these are not circular).
Benefits of these changes are:
- behavior of variables is now again as expected. For example, setting
$(2)_VERSION = virtual in pkg-virtual.mk will effectively work, while
originally it would cause very odd results.
- The output of 'make printvars' is now much more useful. This target shows
the value of all variables, and the expression that led to that value.
However, if the expression was coming from an inner-xxx-targets block, and
was using single dollar signs, it would show in printvars as
VAR = value (value)
while if double dollar signs are used, it would effectively look like
VAR = value (actual expression)
as is intended.
This improvement is for example effective for FOO_DL_VERSION, FOO_RAWNAME,
FOO_SITE_METHOD and FOO_MAKE.
The correctness of this patch has been verified using 'make printvars',
'make manual' and 'make legal-info' before and after applying this patch,
and comparing the output.
Insight-provided-by: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-06-11 21:12:24 +02:00
|
|
|
$(2)_SRCDIR = $$($(2)_DIR)/$$($(2)_SUBDIR)
|
2015-03-13 09:24:08 +01:00
|
|
|
|
|
|
|
|
$(3)_SUPPORTS_IN_SOURCE_BUILD ?= YES
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
ifeq ($$($(3)_SUPPORTS_IN_SOURCE_BUILD),YES)
|
2011-01-26 22:18:43 +01:00
|
|
|
$(2)_BUILDDIR = $$($(2)_SRCDIR)
|
2015-03-13 09:24:08 +01:00
|
|
|
else
|
|
|
|
|
$(2)_BUILDDIR = $$($(2)_SRCDIR)/buildroot-build
|
|
|
|
|
endif
|
2011-01-26 22:18:43 +01:00
|
|
|
|
|
|
|
|
#
|
|
|
|
|
# Configure step. Only define it if not already defined by the package
|
|
|
|
|
# .mk file. And take care of the differences between host and target
|
|
|
|
|
# packages.
|
|
|
|
|
#
|
|
|
|
|
ifndef $(2)_CONFIGURE_CMDS
|
2014-02-05 10:44:03 +01:00
|
|
|
ifeq ($(4),target)
|
2011-01-26 22:18:43 +01:00
|
|
|
|
|
|
|
|
# Configure package for target
|
|
|
|
|
define $(2)_CONFIGURE_CMDS
|
2015-03-13 09:24:08 +01:00
|
|
|
(mkdir -p $$($$(PKG)_BUILDDIR) && \
|
|
|
|
|
cd $$($$(PKG)_BUILDDIR) && \
|
2011-01-26 22:18:43 +01:00
|
|
|
rm -f CMakeCache.txt && \
|
infra: consistently use double dollar signs inside inner-xxx-targets
The inner-xxx-targets in the buildroot package infrastructures are
evaluated using $(eval) which causes variable references to be a bit
different than in regular make code. As we want most references to be
expanded only at the time of the $(eval) we should not use standard
references $(VAR) but rather use double dollar signs $$(VAR). This includes
function references like $(call), $(subst), etc. The only exception is the
reference to pkgdir/pkgname and numbered variables, which are parameters to
the inner block: $(1), $(2), etc.
This patch introduces consistent usage of double-dollar signs throughout the
different inner-xxx-targets blocks.
In some cases, this would potentially cause circular references, in
particular when the value of HOST_FOO_VAR would be obtained from the
corresponding FOO_VAR if HOST_FOO_VAR is not defined. In these cases, a test
is added to check for a host package (the only case where such constructions
are relevant; these are not circular).
Benefits of these changes are:
- behavior of variables is now again as expected. For example, setting
$(2)_VERSION = virtual in pkg-virtual.mk will effectively work, while
originally it would cause very odd results.
- The output of 'make printvars' is now much more useful. This target shows
the value of all variables, and the expression that led to that value.
However, if the expression was coming from an inner-xxx-targets block, and
was using single dollar signs, it would show in printvars as
VAR = value (value)
while if double dollar signs are used, it would effectively look like
VAR = value (actual expression)
as is intended.
This improvement is for example effective for FOO_DL_VERSION, FOO_RAWNAME,
FOO_SITE_METHOD and FOO_MAKE.
The correctness of this patch has been verified using 'make printvars',
'make manual' and 'make legal-info' before and after applying this patch,
and comparing the output.
Insight-provided-by: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-06-11 21:12:24 +02:00
|
|
|
PATH=$$(BR_PATH) \
|
core: don't build host-cmake if it is available on the build host
Currently all cmake packages depend on host-cmake. Unfortunately
host-cmake takes a long time to configure and build: almost 7 minutes
on a dual-core i5 with SSD. The time does not change even with ccache
enabled.
Indeed, building host-cmake is avoidable if it is already installed on
the build host: CMake is supposed to be quite portable, and the only
patch in Buildroot for the CMake package seems to only affect
target-cmake.
Thus we automatically skip building host-cmake and use the one on the
system if:
- cmake is available on the system and
- it is recent enough.
First, we leverage the existing infrastructure in
support/dependencies/dependencies.mk to find out whether there's a
suitable cmake executable on the system. Its path can be passed in the
BR2_CMAKE environment variable, otherwise it defaults to "cmake". If
it is enabled, found and suitable then we set BR2_CMAKE_HOST_DEPENDENCY
to empty; otherwise we set BR2_CMAKE_HOST_DEPENDENCY to 'host-cmake' and
override BR2_CMAKE with "$(HOST_DIR)/usr/bin/cmake" to revert to using
our own cmake (the old behaviour).
Then in pkg-cmake.mk we replace the hard-coded dependency on host-cmake
to using the BR2_CMAKE_HOST_DEPENDENCY variable, and we use $(BR2_CMAKE)
instead of $(HOST_DIR)/usr/bin/cmake.
Unlike what we do for host-tar and host-xzcat, for host-cmake we do
not add host-cmake to DEPENDENCIES_HOST_PREREQ. If we did, host-cmake
would be a dependency for _any_ package when it's not installed on the
host, even when no cmake package is selected.
Cmake versions older than 3.0 are affected by the bug described and
fixed in Buildroot in ef2c1970e4bf ("cmake: add patch to fix Qt mkspecs
detection"). The bug was fixed in upstream CMake in version 3.0 [0].
Amongst all the cmake packages currently in Buildroot, the currently
highest version mentioned in cmake_minimum_required() is 3.1 (grantlee
and opencv3).
Thus we use 3.1 as the lowest required cmake for now, until a package is
bumped, or a new package added, with a higher required version.
[0] https://cmake.org/gitweb?p=cmake.git;h=e8b8b37ef6fef094940d3384df5a1d421b9fa568
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Samuel Martin <s.martin49@gmail.com>
Cc: Davide Viti <zinosat@tiscali.it>
Cc: Arnout Vandecappelle <arnout@mind.be>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reviewed-by: Romain Naour <romain.naour@gmail.com>
Tested-by: Romain Naour <romain.naour@gmail.com>
[yann.morin.1998@free.fr:
- simplify logic in check-host-cmake.mk;
- set and use BR2_CMAKE_HOST_DEPENDENCY, drop USE_SYSTEM_CMAKE;
- bump to cmake 3.1 for grantlee and opencv;
]
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2016-09-12 23:59:19 +02:00
|
|
|
$$($$(PKG)_CONF_ENV) $$(BR2_CMAKE) $$($$(PKG)_SRCDIR) \
|
2012-02-25 23:18:03 +01:00
|
|
|
-DCMAKE_TOOLCHAIN_FILE="$$(HOST_DIR)/usr/share/buildroot/toolchainfile.cmake" \
|
2011-01-26 22:18:43 +01:00
|
|
|
-DCMAKE_INSTALL_PREFIX="/usr" \
|
2014-01-26 18:37:02 +01:00
|
|
|
-DCMAKE_COLOR_MAKEFILE=OFF \
|
2014-10-19 20:04:37 +02:00
|
|
|
-DBUILD_DOC=OFF \
|
|
|
|
|
-DBUILD_DOCS=OFF \
|
|
|
|
|
-DBUILD_EXAMPLE=OFF \
|
|
|
|
|
-DBUILD_EXAMPLES=OFF \
|
|
|
|
|
-DBUILD_TEST=OFF \
|
|
|
|
|
-DBUILD_TESTS=OFF \
|
2014-06-01 11:24:28 +02:00
|
|
|
-DBUILD_TESTING=OFF \
|
2014-12-03 22:41:29 +01:00
|
|
|
-DBUILD_SHARED_LIBS=$$(if $$(BR2_STATIC_LIBS),OFF,ON) \
|
2015-02-11 18:52:21 +01:00
|
|
|
$$(CMAKE_QUIET) \
|
2014-09-27 21:32:44 +02:00
|
|
|
$$($$(PKG)_CONF_OPTS) \
|
2011-01-26 22:18:43 +01:00
|
|
|
)
|
|
|
|
|
endef
|
|
|
|
|
else
|
|
|
|
|
|
|
|
|
|
# Configure package for host
|
|
|
|
|
define $(2)_CONFIGURE_CMDS
|
2015-03-13 09:24:08 +01:00
|
|
|
(mkdir -p $$($$(PKG)_BUILDDIR) && \
|
|
|
|
|
cd $$($$(PKG)_BUILDDIR) && \
|
2011-01-26 22:18:43 +01:00
|
|
|
rm -f CMakeCache.txt && \
|
infra: consistently use double dollar signs inside inner-xxx-targets
The inner-xxx-targets in the buildroot package infrastructures are
evaluated using $(eval) which causes variable references to be a bit
different than in regular make code. As we want most references to be
expanded only at the time of the $(eval) we should not use standard
references $(VAR) but rather use double dollar signs $$(VAR). This includes
function references like $(call), $(subst), etc. The only exception is the
reference to pkgdir/pkgname and numbered variables, which are parameters to
the inner block: $(1), $(2), etc.
This patch introduces consistent usage of double-dollar signs throughout the
different inner-xxx-targets blocks.
In some cases, this would potentially cause circular references, in
particular when the value of HOST_FOO_VAR would be obtained from the
corresponding FOO_VAR if HOST_FOO_VAR is not defined. In these cases, a test
is added to check for a host package (the only case where such constructions
are relevant; these are not circular).
Benefits of these changes are:
- behavior of variables is now again as expected. For example, setting
$(2)_VERSION = virtual in pkg-virtual.mk will effectively work, while
originally it would cause very odd results.
- The output of 'make printvars' is now much more useful. This target shows
the value of all variables, and the expression that led to that value.
However, if the expression was coming from an inner-xxx-targets block, and
was using single dollar signs, it would show in printvars as
VAR = value (value)
while if double dollar signs are used, it would effectively look like
VAR = value (actual expression)
as is intended.
This improvement is for example effective for FOO_DL_VERSION, FOO_RAWNAME,
FOO_SITE_METHOD and FOO_MAKE.
The correctness of this patch has been verified using 'make printvars',
'make manual' and 'make legal-info' before and after applying this patch,
and comparing the output.
Insight-provided-by: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-06-11 21:12:24 +02:00
|
|
|
PATH=$$(BR_PATH) \
|
2017-02-26 18:42:48 +01:00
|
|
|
$$($$(PKG)_CONF_ENV) $$(BR2_CMAKE) $$($$(PKG)_SRCDIR) \
|
2011-01-26 22:18:43 +01:00
|
|
|
-DCMAKE_INSTALL_SO_NO_EXE=0 \
|
|
|
|
|
-DCMAKE_FIND_ROOT_PATH="$$(HOST_DIR)" \
|
|
|
|
|
-DCMAKE_FIND_ROOT_PATH_MODE_PROGRAM="BOTH" \
|
|
|
|
|
-DCMAKE_FIND_ROOT_PATH_MODE_LIBRARY="BOTH" \
|
|
|
|
|
-DCMAKE_FIND_ROOT_PATH_MODE_INCLUDE="BOTH" \
|
|
|
|
|
-DCMAKE_INSTALL_PREFIX="$$(HOST_DIR)/usr" \
|
2014-08-21 22:45:17 +02:00
|
|
|
-DCMAKE_C_FLAGS="$$(HOST_CFLAGS)" \
|
|
|
|
|
-DCMAKE_CXX_FLAGS="$$(HOST_CXXFLAGS)" \
|
|
|
|
|
-DCMAKE_EXE_LINKER_FLAGS="$$(HOST_LDFLAGS)" \
|
2014-12-14 20:12:01 +01:00
|
|
|
-DCMAKE_ASM_COMPILER="$$(HOSTAS)" \
|
|
|
|
|
-DCMAKE_C_COMPILER="$$(CMAKE_HOST_C_COMPILER)" \
|
|
|
|
|
-DCMAKE_CXX_COMPILER="$$(CMAKE_HOST_CXX_COMPILER)" \
|
|
|
|
|
$(if $$(CMAKE_HOST_C_COMPILER_ARG1),\
|
|
|
|
|
-DCMAKE_C_COMPILER_ARG1="$$(CMAKE_HOST_C_COMPILER_ARG1)" \
|
|
|
|
|
-DCMAKE_CXX_COMPILER_ARG1="$$(CMAKE_HOST_CXX_COMPILER_ARG1)" \
|
|
|
|
|
) \
|
2014-10-19 20:04:38 +02:00
|
|
|
-DCMAKE_COLOR_MAKEFILE=OFF \
|
2014-10-19 20:04:37 +02:00
|
|
|
-DBUILD_DOC=OFF \
|
|
|
|
|
-DBUILD_DOCS=OFF \
|
|
|
|
|
-DBUILD_EXAMPLE=OFF \
|
|
|
|
|
-DBUILD_EXAMPLES=OFF \
|
|
|
|
|
-DBUILD_TEST=OFF \
|
|
|
|
|
-DBUILD_TESTS=OFF \
|
2014-06-01 11:24:28 +02:00
|
|
|
-DBUILD_TESTING=OFF \
|
2015-02-11 18:52:21 +01:00
|
|
|
$$(CMAKE_QUIET) \
|
2014-09-27 21:32:44 +02:00
|
|
|
$$($$(PKG)_CONF_OPTS) \
|
2011-01-26 22:18:43 +01:00
|
|
|
)
|
|
|
|
|
endef
|
|
|
|
|
endif
|
|
|
|
|
endif
|
|
|
|
|
|
2016-07-01 17:53:28 +02:00
|
|
|
# Since some CMake modules (even upstream ones) use pgk_check_modules
|
|
|
|
|
# primitives to find {C,LD}FLAGS, add it to the dependency list.
|
|
|
|
|
$(2)_DEPENDENCIES += host-pkgconf
|
|
|
|
|
|
core: don't build host-cmake if it is available on the build host
Currently all cmake packages depend on host-cmake. Unfortunately
host-cmake takes a long time to configure and build: almost 7 minutes
on a dual-core i5 with SSD. The time does not change even with ccache
enabled.
Indeed, building host-cmake is avoidable if it is already installed on
the build host: CMake is supposed to be quite portable, and the only
patch in Buildroot for the CMake package seems to only affect
target-cmake.
Thus we automatically skip building host-cmake and use the one on the
system if:
- cmake is available on the system and
- it is recent enough.
First, we leverage the existing infrastructure in
support/dependencies/dependencies.mk to find out whether there's a
suitable cmake executable on the system. Its path can be passed in the
BR2_CMAKE environment variable, otherwise it defaults to "cmake". If
it is enabled, found and suitable then we set BR2_CMAKE_HOST_DEPENDENCY
to empty; otherwise we set BR2_CMAKE_HOST_DEPENDENCY to 'host-cmake' and
override BR2_CMAKE with "$(HOST_DIR)/usr/bin/cmake" to revert to using
our own cmake (the old behaviour).
Then in pkg-cmake.mk we replace the hard-coded dependency on host-cmake
to using the BR2_CMAKE_HOST_DEPENDENCY variable, and we use $(BR2_CMAKE)
instead of $(HOST_DIR)/usr/bin/cmake.
Unlike what we do for host-tar and host-xzcat, for host-cmake we do
not add host-cmake to DEPENDENCIES_HOST_PREREQ. If we did, host-cmake
would be a dependency for _any_ package when it's not installed on the
host, even when no cmake package is selected.
Cmake versions older than 3.0 are affected by the bug described and
fixed in Buildroot in ef2c1970e4bf ("cmake: add patch to fix Qt mkspecs
detection"). The bug was fixed in upstream CMake in version 3.0 [0].
Amongst all the cmake packages currently in Buildroot, the currently
highest version mentioned in cmake_minimum_required() is 3.1 (grantlee
and opencv3).
Thus we use 3.1 as the lowest required cmake for now, until a package is
bumped, or a new package added, with a higher required version.
[0] https://cmake.org/gitweb?p=cmake.git;h=e8b8b37ef6fef094940d3384df5a1d421b9fa568
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Samuel Martin <s.martin49@gmail.com>
Cc: Davide Viti <zinosat@tiscali.it>
Cc: Arnout Vandecappelle <arnout@mind.be>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reviewed-by: Romain Naour <romain.naour@gmail.com>
Tested-by: Romain Naour <romain.naour@gmail.com>
[yann.morin.1998@free.fr:
- simplify logic in check-host-cmake.mk;
- set and use BR2_CMAKE_HOST_DEPENDENCY, drop USE_SYSTEM_CMAKE;
- bump to cmake 3.1 for grantlee and opencv;
]
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2016-09-12 23:59:19 +02:00
|
|
|
$(2)_DEPENDENCIES += $(BR2_CMAKE_HOST_DEPENDENCY)
|
2011-01-26 22:18:43 +01:00
|
|
|
|
|
|
|
|
#
|
|
|
|
|
# Build step. Only define it if not already defined by the package .mk
|
|
|
|
|
# file.
|
|
|
|
|
#
|
|
|
|
|
ifndef $(2)_BUILD_CMDS
|
2014-02-05 10:44:03 +01:00
|
|
|
ifeq ($(4),target)
|
2011-01-26 22:18:43 +01:00
|
|
|
define $(2)_BUILD_CMDS
|
2014-09-27 21:32:38 +02:00
|
|
|
$$(TARGET_MAKE_ENV) $$($$(PKG)_MAKE_ENV) $$($$(PKG)_MAKE) $$($$(PKG)_MAKE_OPTS) -C $$($$(PKG)_BUILDDIR)
|
2011-01-26 22:18:43 +01:00
|
|
|
endef
|
|
|
|
|
else
|
|
|
|
|
define $(2)_BUILD_CMDS
|
2014-09-27 21:32:38 +02:00
|
|
|
$$(HOST_MAKE_ENV) $$($$(PKG)_MAKE_ENV) $$($$(PKG)_MAKE) $$($$(PKG)_MAKE_OPTS) -C $$($$(PKG)_BUILDDIR)
|
2011-01-26 22:18:43 +01:00
|
|
|
endef
|
|
|
|
|
endif
|
|
|
|
|
endif
|
|
|
|
|
|
|
|
|
|
#
|
|
|
|
|
# Host installation step. Only define it if not already defined by the
|
|
|
|
|
# package .mk file.
|
|
|
|
|
#
|
|
|
|
|
ifndef $(2)_INSTALL_CMDS
|
|
|
|
|
define $(2)_INSTALL_CMDS
|
2014-10-04 19:32:12 +02:00
|
|
|
$$(HOST_MAKE_ENV) $$($$(PKG)_MAKE_ENV) $$($$(PKG)_MAKE) $$($$(PKG)_MAKE_OPTS) $$($$(PKG)_INSTALL_OPTS) -C $$($$(PKG)_BUILDDIR)
|
2011-01-26 22:18:43 +01:00
|
|
|
endef
|
|
|
|
|
endif
|
|
|
|
|
|
|
|
|
|
#
|
|
|
|
|
# Staging installation step. Only define it if not already defined by
|
|
|
|
|
# the package .mk file.
|
|
|
|
|
#
|
|
|
|
|
ifndef $(2)_INSTALL_STAGING_CMDS
|
|
|
|
|
define $(2)_INSTALL_STAGING_CMDS
|
2014-09-27 21:32:41 +02:00
|
|
|
$$(TARGET_MAKE_ENV) $$($$(PKG)_MAKE_ENV) $$($$(PKG)_MAKE) $$($$(PKG)_MAKE_OPTS) $$($$(PKG)_INSTALL_STAGING_OPTS) -C $$($$(PKG)_BUILDDIR)
|
2011-01-26 22:18:43 +01:00
|
|
|
endef
|
|
|
|
|
endif
|
|
|
|
|
|
|
|
|
|
#
|
|
|
|
|
# Target installation step. Only define it if not already defined by
|
|
|
|
|
# the package .mk file.
|
|
|
|
|
#
|
|
|
|
|
ifndef $(2)_INSTALL_TARGET_CMDS
|
|
|
|
|
define $(2)_INSTALL_TARGET_CMDS
|
2014-09-27 21:32:40 +02:00
|
|
|
$$(TARGET_MAKE_ENV) $$($$(PKG)_MAKE_ENV) $$($$(PKG)_MAKE) $$($$(PKG)_MAKE_OPTS) $$($$(PKG)_INSTALL_TARGET_OPTS) -C $$($$(PKG)_BUILDDIR)
|
2011-01-26 22:18:43 +01:00
|
|
|
endef
|
|
|
|
|
endif
|
|
|
|
|
|
|
|
|
|
# Call the generic package infrastructure to generate the necessary
|
|
|
|
|
# make targets
|
2014-02-05 10:44:03 +01:00
|
|
|
$(call inner-generic-package,$(1),$(2),$(3),$(4))
|
2011-01-26 22:18:43 +01:00
|
|
|
|
|
|
|
|
endef
|
|
|
|
|
|
|
|
|
|
################################################################################
|
2012-07-03 00:07:08 +02:00
|
|
|
# cmake-package -- the target generator macro for CMake packages
|
2011-01-26 22:18:43 +01:00
|
|
|
################################################################################
|
|
|
|
|
|
2014-02-05 10:44:03 +01:00
|
|
|
cmake-package = $(call inner-cmake-package,$(pkgname),$(call UPPERCASE,$(pkgname)),$(call UPPERCASE,$(pkgname)),target)
|
|
|
|
|
host-cmake-package = $(call inner-cmake-package,host-$(pkgname),$(call UPPERCASE,host-$(pkgname)),$(call UPPERCASE,$(pkgname)),host)
|
2012-04-17 16:45:23 +02:00
|
|
|
|
|
|
|
|
################################################################################
|
|
|
|
|
# Generation of the CMake toolchain file
|
|
|
|
|
################################################################################
|
|
|
|
|
|
2014-11-17 21:02:41 +01:00
|
|
|
# CMAKE_SYSTEM_PROCESSOR should match uname -m
|
|
|
|
|
ifeq ($(BR2_ARM_CPU_ARMV4),y)
|
|
|
|
|
CMAKE_SYSTEM_PROCESSOR_ARM_VARIANT = armv4
|
|
|
|
|
else ifeq ($(BR2_ARM_CPU_ARMV5),y)
|
|
|
|
|
CMAKE_SYSTEM_PROCESSOR_ARM_VARIANT = armv5
|
|
|
|
|
else ifeq ($(BR2_ARM_CPU_ARMV6),y)
|
|
|
|
|
CMAKE_SYSTEM_PROCESSOR_ARM_VARIANT = armv6
|
|
|
|
|
else ifeq ($(BR2_ARM_CPU_ARMV7A),y)
|
|
|
|
|
CMAKE_SYSTEM_PROCESSOR_ARM_VARIANT = armv7
|
|
|
|
|
endif
|
|
|
|
|
|
|
|
|
|
ifeq ($(BR2_arm),y)
|
|
|
|
|
CMAKE_SYSTEM_PROCESSOR = $(CMAKE_SYSTEM_PROCESSOR_ARM_VARIANT)l
|
|
|
|
|
else ifeq ($(BR2_armeb),y)
|
2015-02-16 09:24:52 +01:00
|
|
|
CMAKE_SYSTEM_PROCESSOR = $(CMAKE_SYSTEM_PROCESSOR_ARM_VARIANT)b
|
2017-03-09 01:57:10 +01:00
|
|
|
else ifeq ($(call qstrip,$(BR2_ARCH)),powerpc64)
|
|
|
|
|
CMAKE_SYSTEM_PROCESSOR = ppc64
|
|
|
|
|
else ifeq ($(call qstrip,$(BR2_ARCH)),powerpc64le)
|
|
|
|
|
CMAKE_SYSTEM_PROCESSOR = ppc64le
|
2014-11-17 21:02:41 +01:00
|
|
|
else
|
|
|
|
|
CMAKE_SYSTEM_PROCESSOR = $(BR2_ARCH)
|
|
|
|
|
endif
|
|
|
|
|
|
2014-06-01 11:24:24 +02:00
|
|
|
# In order to allow the toolchain to be relocated, we calculate the HOST_DIR
|
|
|
|
|
# based on the toolchainfile.cmake file's location: $(HOST_DIR)/usr/share/buildroot
|
|
|
|
|
# In all the other variables, HOST_DIR will be replaced by RELOCATED_HOST_DIR,
|
|
|
|
|
# so we have to strip "$(HOST_DIR)/" from the paths that contain it.
|
2012-04-17 16:45:23 +02:00
|
|
|
$(HOST_DIR)/usr/share/buildroot/toolchainfile.cmake:
|
|
|
|
|
@mkdir -p $(@D)
|
2014-06-01 11:24:23 +02:00
|
|
|
sed \
|
2015-09-21 20:57:36 +02:00
|
|
|
-e 's#@@STAGING_SUBDIR@@#$(call qstrip,$(STAGING_SUBDIR))#' \
|
|
|
|
|
-e 's#@@TARGET_CFLAGS@@#$(call qstrip,$(TARGET_CFLAGS))#' \
|
|
|
|
|
-e 's#@@TARGET_CXXFLAGS@@#$(call qstrip,$(TARGET_CXXFLAGS))#' \
|
2016-07-03 15:47:43 +02:00
|
|
|
-e 's#@@TARGET_FCFLAGS@@#$(call qstrip,$(TARGET_FCFLAGS))#' \
|
2015-09-21 20:57:36 +02:00
|
|
|
-e 's#@@TARGET_LDFLAGS@@#$(call qstrip,$(TARGET_LDFLAGS))#' \
|
2015-10-04 14:28:53 +02:00
|
|
|
-e 's#@@TARGET_CC@@#$(subst $(HOST_DIR)/,,$(call qstrip,$(TARGET_CC)))#' \
|
|
|
|
|
-e 's#@@TARGET_CXX@@#$(subst $(HOST_DIR)/,,$(call qstrip,$(TARGET_CXX)))#' \
|
2016-07-03 15:47:43 +02:00
|
|
|
-e 's#@@TARGET_FC@@#$(subst $(HOST_DIR)/,,$(call qstrip,$(TARGET_FC)))#' \
|
2015-09-21 20:57:36 +02:00
|
|
|
-e 's#@@CMAKE_SYSTEM_PROCESSOR@@#$(call qstrip,$(CMAKE_SYSTEM_PROCESSOR))#' \
|
2016-07-03 15:47:43 +02:00
|
|
|
-e 's#@@TOOLCHAIN_HAS_FORTRAN@@#$(if $(BR2_TOOLCHAIN_HAS_FORTRAN),1,0)#' \
|
2016-10-16 13:12:38 +02:00
|
|
|
-e 's#@@CMAKE_BUILD_TYPE@@#$(if $(BR2_ENABLE_DEBUG),Debug,Release)#' \
|
2014-06-01 11:24:23 +02:00
|
|
|
$(TOPDIR)/support/misc/toolchainfile.cmake.in \
|
|
|
|
|
> $@
|
core/pkg-cmake: provide our own platform description
The handling of RPATH in cmake-3.7 has changed drastically, causing a
slew of build failures dues to libraries from the host being pulled in:
- domoticz : http://autobuild.buildroot.org/results/fd0/fd0ba54c7abf973691b39a0ca1bb4e07d749593a/
- freerdp : http://autobuild.buildroot.org/results/5d4/5d429d0e288754a541ee5d8be515454c5fccd28b/
- libcec : http://autobuild.buildroot.org/results/3f3/3f3593bab7734dd274faf5b5690895e9424cbb89/
- and so on...
The bug was reported upstream [0], which dismissed it altogether [1] as
being expected behaviour, quoting:
I don't think there is anything wrong with that change on its own.
It merely exposed some existing behavior in a new case.
Instead, upstream suggested in that same message that a platform
definition be used instead, quoting:
If a toolchain file specifies CMAKE_SYSTEM_NAME such that a custom
`Platform/MySystem.cmake` file is loaded then the latter can set
them as needed for the target platform.
So here we are doing so:
- we add a new platfom definitions that inherits from the Linux one,
then overrides the problematic settings;
- we change our toolchain file to use that platform instead;
- we tell cmake where to find additional modules, so that it can find
our custom platform file.
This has been tested to work in the following conditions:
- pre-installed host cmake, versions 3.5.1 (Ubuntu 16.04) and 3.7.2
(manually built)
- internal cmake, versions 3.6.3 (the current version as of this
patch) and 3.7.2 (with the followup patches).
Thanks to Jörg, Ben and Baruch for the help investigating the issue.
Special thanks to Jörg for handling the discussion with upstream and
pointing to the relevant messages! :-)
[0] http://public.kitware.com/pipermail/cmake/2017-February/064970.html
[1] http://public.kitware.com/pipermail/cmake/2017-February/065063.html
To be noted: Thomas suggested we set these directly in the toolchain
file. Unfortunately, wherever we put those settings in the toolchain
file, this does not work.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Jörg Krause <joerg.krause@embedded.rocks>
Cc: Ben Boeckel <mathstuf@gmail.com>
Cc: Baruch Siach <baruch@tkos.co.il>
Cc: Samuel Martin <s.martin49@gmail.com>
Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Peter Korsgaard <peter@korsgaard.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2017-02-28 19:07:22 +01:00
|
|
|
|
|
|
|
|
$(HOST_DIR)/usr/share/buildroot/Platform/Buildroot.cmake:
|
|
|
|
|
$(Q)$(INSTALL) -D -m 0644 support/misc/Buildroot.cmake $(@)
|
