kumquat-buildroot/package/libgit2/libgit2.mk

52 lines
1.4 KiB
Makefile
Raw Normal View History

################################################################################
#
# libgit2
#
################################################################################
package/libgit2: security bump to version 0.27.8 Fixing the following list of issues (fixed in 0.27.6 and 0.27.5): The function family git__strtol is used to parse integers from a buffer. As the functions do not take a buffer length as argument, they will scan either until the end of the current number or until a NUL byte is encountered. Many callers have been misusing the function and called it on potentially non-NUL-terminated buffers, resulting in possible out-of-bounds reads. Callers have been fixed to use git__strntol functions instead and git__strtol functions were removed. The function git__strntol64 relied on the undefined behavior of signed integer overflows. While the code tried to detect such overflows after they have happened, this is unspecified behavior and may lead to weird behavior on uncommon platforms. In the case where git__strntol32 was unable to parse an integer because it doesn't fit into an int32_t, it printed an error message containing the string that is currently being parsed. The code didn't truncate the string though, which caused it to print the complete string until a NUL byte is encountered and not only the currently parsed number. In case where the string was not NUL terminated, this could have lead to an out-of-bounds read. When parsing tags, all unknown fields that appear before the tag message are skipped. This skipping is done by using a plain strstr(buffer, "\n\n") to search for the two newlines that separate tag fields from tag message. As it is not possible to supply a buffer length to strstr, this call may skip over the buffer's end and thus result in an out of bounds read. As strstr may return a pointer that is out of bounds, the following computation of buffer_end - buffer will overflow and result in an allocation of an invalid length. Note that when reading objects from the object database, we make sure to always NUL terminate them, making the use of strstr safe. When parsing the "encoding" field of a commit, we may perform an out of bounds read due to using git__prefixcmp instead of git__prefixncmp. This can result in the parsed commit object containing uninitialized data in both its message encoding and message fields. Note that when reading objects from the object database, we make sure to always NUL terminate them, making the use of strstr safe. Submodule URLs and paths with a leading "-" are now ignored. This is due to the recently discovered CVE-2018-17456, which can lead to arbitrary code execution in upstream git. While libgit2 itself is not vulnerable, it can be used to inject options in an implementation which performs a recursive clone by executing an external command. When running repack while doing repo writes, packfile_load__cb() could see some temporary files in the directory that were bigger than the usual, and makes memcmp overflow on the p->pack_name string. This issue was reported and fixed by bisho. The configuration file parser used unbounded recursion to parse multiline variables, which could lead to a stack overflow. The issue was reported by the oss-fuzz project, issue 10048 and fixed by Nelson Elhage. The fix to the unbounded recursion introduced a memory leak in the config parser. While this leak was never in a public release, the oss-fuzz project reported this as issue 10127. The fix was implemented by Nelson Elhage and Patrick Steinhardt. When parsing "ok" packets received via the smart protocol, our parsing code did not correctly verify the bounds of the packets, which could result in a heap-buffer overflow. The issue was reported by the oss-fuzz project, issue 9749 and fixed by Patrick Steinhardt. The parsing code for the smart protocol has been tightened in general, fixing heap-buffer overflows when parsing the packet type as well as for "ACK" and "unpack" packets. The issue was discovered and fixed by Patrick Steinhardt. Fixed potential integer overflows on platforms with 16 bit integers when parsing packets for the smart protocol. The issue was discovered and fixed by Patrick Steinhardt. Fixed potential NULL pointer dereference when parsing configuration files which have "include.path" or "includeIf..path" statements without a value. Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
2019-06-10 11:03:28 +02:00
LIBGIT2_VERSION = v0.27.8
LIBGIT2_SITE = $(call github,libgit2,libgit2,$(LIBGIT2_VERSION))
LIBGIT2_LICENSE = GPL-2.0 with linking exception
LIBGIT2_LICENSE_FILES = COPYING
LIBGIT2_INSTALL_STAGING = YES
LIBGIT2_CONF_OPTS = \
-DUSE_GSSAPI=OFF \
-DBUILD_CLAR=OFF \
-DUSE_ICONV=ON \
-DTHREADSAFE=$(if $(BR2_TOOLCHAIN_HAS_THREADS),ON,OFF)
LIBGIT2_DEPENDENCIES = zlib
# If libiconv is available (for !locale toolchains), then we can use
# it for iconv support. Note that USE_ICONV=ON is still correct even
# without libiconv because (1) most toolchain have iconv support
# without libiconv and (2) even if USE_ICONV=ON but iconv support is
# not available, libgit2 simply avoids using iconv.
ifeq ($(BR2_PACKAGE_LIBICONV),y)
LIBGIT2_DEPENDENCIES += libiconv
endif
ifeq ($(BR2_PACKAGE_LIBSSH2),y)
LIBGIT2_DEPENDENCIES += libssh2
LIBGIT2_CONF_OPTS += -DUSE_SSH=ON
else
LIBGIT2_CONF_OPTS += -DUSE_SSH=OFF
endif
ifeq ($(BR2_PACKAGE_OPENSSL),y)
LIBGIT2_DEPENDENCIES += openssl
LIBGIT2_CONF_OPTS += -DUSE_HTTPS=OpenSSL
else
LIBGIT2_CONF_OPTS += -DUSE_HTTPS=OFF
endif
ifeq ($(BR2_PACKAGE_LIBCURL),y)
LIBGIT2_DEPENDENCIES += libcurl
LIBGIT2_CONF_OPTS += -DCURL=ON
else
LIBGIT2_CONF_OPTS += -DCURL=OFF
endif
$(eval $(cmake-package))