2018-11-08 12:32:07 +01:00
|
|
|
From 7d1e6ed1d57e839207e0ece7561bd4709032de9f Mon Sep 17 00:00:00 2001
|
2016-05-10 23:05:04 +02:00
|
|
|
From: Romain Naour <romain.naour@gmail.com>
|
|
|
|
Date: Fri, 25 Dec 2015 11:45:38 +0100
|
|
|
|
Subject: [PATCH] poison-system-directories
|
|
|
|
|
|
|
|
Patch adapted to binutils 2.23.2 and extended to use
|
2014-12-10 23:53:50 +01:00
|
|
|
BR_COMPILER_PARANOID_UNSAFE_PATH by Thomas Petazzoni.
|
|
|
|
|
2016-05-10 23:05:04 +02:00
|
|
|
[Romain: rebase on top of 2.26]
|
|
|
|
Signed-off-by: Romain Naour <romain.naour@gmail.com>
|
|
|
|
[Gustavo: adapt to binutils 2.25]
|
2014-12-10 23:53:50 +01:00
|
|
|
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
|
2016-05-10 23:05:04 +02:00
|
|
|
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
|
2014-12-10 23:53:50 +01:00
|
|
|
|
|
|
|
Upstream-Status: Inappropriate [distribution: codesourcery]
|
|
|
|
|
|
|
|
Patch originally created by Mark Hatle, forward-ported to
|
|
|
|
binutils 2.21 by Scott Garman.
|
|
|
|
|
|
|
|
purpose: warn for uses of system directories when cross linking
|
|
|
|
|
|
|
|
Code Merged from Sourcery G++ binutils 2.19 - 4.4-277
|
|
|
|
|
|
|
|
2008-07-02 Joseph Myers <joseph@codesourcery.com>
|
|
|
|
|
|
|
|
ld/
|
|
|
|
* ld.h (args_type): Add error_poison_system_directories.
|
|
|
|
* ld.texinfo (--error-poison-system-directories): Document.
|
|
|
|
* ldfile.c (ldfile_add_library_path): Check
|
|
|
|
command_line.error_poison_system_directories.
|
|
|
|
* ldmain.c (main): Initialize
|
|
|
|
command_line.error_poison_system_directories.
|
|
|
|
* lexsup.c (enum option_values): Add
|
|
|
|
OPTION_ERROR_POISON_SYSTEM_DIRECTORIES.
|
|
|
|
(ld_options): Add --error-poison-system-directories.
|
|
|
|
(parse_args): Handle new option.
|
|
|
|
|
|
|
|
2007-06-13 Joseph Myers <joseph@codesourcery.com>
|
|
|
|
|
|
|
|
ld/
|
|
|
|
* config.in: Regenerate.
|
|
|
|
* ld.h (args_type): Add poison_system_directories.
|
|
|
|
* ld.texinfo (--no-poison-system-directories): Document.
|
|
|
|
* ldfile.c (ldfile_add_library_path): Check
|
|
|
|
command_line.poison_system_directories.
|
|
|
|
* ldmain.c (main): Initialize
|
|
|
|
command_line.poison_system_directories.
|
|
|
|
* lexsup.c (enum option_values): Add
|
|
|
|
OPTION_NO_POISON_SYSTEM_DIRECTORIES.
|
|
|
|
(ld_options): Add --no-poison-system-directories.
|
|
|
|
(parse_args): Handle new option.
|
|
|
|
|
|
|
|
2007-04-20 Joseph Myers <joseph@codesourcery.com>
|
|
|
|
|
|
|
|
Merge from Sourcery G++ binutils 2.17:
|
|
|
|
|
|
|
|
2007-03-20 Joseph Myers <joseph@codesourcery.com>
|
|
|
|
Based on patch by Mark Hatle <mark.hatle@windriver.com>.
|
|
|
|
ld/
|
2016-05-10 23:05:04 +02:00
|
|
|
* configure.ac (--enable-poison-system-directories): New option.
|
2014-12-10 23:53:50 +01:00
|
|
|
* configure, config.in: Regenerate.
|
|
|
|
* ldfile.c (ldfile_add_library_path): If
|
|
|
|
ENABLE_POISON_SYSTEM_DIRECTORIES defined, warn for use of /lib,
|
|
|
|
/usr/lib, /usr/local/lib or /usr/X11R6/lib.
|
|
|
|
|
|
|
|
Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
|
|
|
|
Signed-off-by: Scott Garman <scott.a.garman@intel.com>
|
2016-05-10 23:05:04 +02:00
|
|
|
---
|
|
|
|
ld/config.in | 3 +++
|
|
|
|
ld/configure | 14 ++++++++++++++
|
|
|
|
ld/configure.ac | 10 ++++++++++
|
|
|
|
ld/ld.h | 8 ++++++++
|
2018-11-08 12:32:07 +01:00
|
|
|
ld/ld.texi | 12 ++++++++++++
|
2016-05-10 23:05:04 +02:00
|
|
|
ld/ldfile.c | 17 +++++++++++++++++
|
|
|
|
ld/ldlex.h | 2 ++
|
|
|
|
ld/ldmain.c | 2 ++
|
|
|
|
ld/lexsup.c | 21 +++++++++++++++++++++
|
|
|
|
9 files changed, 89 insertions(+)
|
2014-12-10 23:53:50 +01:00
|
|
|
|
2016-05-10 23:05:04 +02:00
|
|
|
diff --git a/ld/config.in b/ld/config.in
|
2018-11-08 12:32:07 +01:00
|
|
|
index d93c9b0..5da2742 100644
|
2014-12-10 23:53:50 +01:00
|
|
|
--- a/ld/config.in
|
|
|
|
+++ b/ld/config.in
|
2018-11-08 12:32:07 +01:00
|
|
|
@@ -31,6 +31,9 @@
|
2014-12-10 23:53:50 +01:00
|
|
|
language is requested. */
|
|
|
|
#undef ENABLE_NLS
|
|
|
|
|
|
|
|
+/* Define to warn for use of native system library directories */
|
|
|
|
+#undef ENABLE_POISON_SYSTEM_DIRECTORIES
|
|
|
|
+
|
|
|
|
/* Additional extension a shared object might have. */
|
|
|
|
#undef EXTRA_SHLIB_EXTENSION
|
|
|
|
|
2016-05-10 23:05:04 +02:00
|
|
|
diff --git a/ld/configure b/ld/configure
|
2018-11-08 12:32:07 +01:00
|
|
|
index 300a272..d68890f 100755
|
2014-12-10 23:53:50 +01:00
|
|
|
--- a/ld/configure
|
|
|
|
+++ b/ld/configure
|
2018-11-08 12:32:07 +01:00
|
|
|
@@ -822,6 +822,7 @@ with_lib_path
|
2014-12-10 23:53:50 +01:00
|
|
|
enable_targets
|
|
|
|
enable_64_bit_bfd
|
|
|
|
with_sysroot
|
|
|
|
+enable_poison_system_directories
|
|
|
|
enable_gold
|
|
|
|
enable_got
|
2016-05-10 23:05:04 +02:00
|
|
|
enable_compressed_debug_sections
|
2018-11-08 12:32:07 +01:00
|
|
|
@@ -1486,6 +1487,8 @@ Optional Features:
|
2016-05-10 23:05:04 +02:00
|
|
|
--disable-largefile omit support for large files
|
2014-12-10 23:53:50 +01:00
|
|
|
--enable-targets alternative target configurations
|
|
|
|
--enable-64-bit-bfd 64-bit support (on hosts with narrower word sizes)
|
|
|
|
+ --enable-poison-system-directories
|
|
|
|
+ warn for use of native system library directories
|
|
|
|
--enable-gold[=ARG] build gold [ARG={default,yes,no}]
|
|
|
|
--enable-got=<type> GOT handling scheme (target, single, negative,
|
|
|
|
multigot)
|
2018-11-08 12:32:07 +01:00
|
|
|
@@ -15803,7 +15806,18 @@ else
|
2014-12-10 23:53:50 +01:00
|
|
|
fi
|
|
|
|
|
|
|
|
|
|
|
|
+# Check whether --enable-poison-system-directories was given.
|
|
|
|
+if test "${enable_poison_system_directories+set}" = set; then :
|
|
|
|
+ enableval=$enable_poison_system_directories;
|
|
|
|
+else
|
|
|
|
+ enable_poison_system_directories=no
|
|
|
|
+fi
|
|
|
|
+
|
|
|
|
+if test "x${enable_poison_system_directories}" = "xyes"; then
|
|
|
|
|
|
|
|
+$as_echo "#define ENABLE_POISON_SYSTEM_DIRECTORIES 1" >>confdefs.h
|
|
|
|
+
|
|
|
|
+fi
|
|
|
|
|
|
|
|
# Check whether --enable-got was given.
|
|
|
|
if test "${enable_got+set}" = set; then :
|
2016-05-10 23:05:04 +02:00
|
|
|
diff --git a/ld/configure.ac b/ld/configure.ac
|
2018-11-08 12:32:07 +01:00
|
|
|
index d10c553..9f1b57b 100644
|
2016-05-10 23:05:04 +02:00
|
|
|
--- a/ld/configure.ac
|
|
|
|
+++ b/ld/configure.ac
|
2018-11-08 12:32:07 +01:00
|
|
|
@@ -94,6 +94,16 @@ AC_SUBST(use_sysroot)
|
2014-12-10 23:53:50 +01:00
|
|
|
AC_SUBST(TARGET_SYSTEM_ROOT)
|
|
|
|
AC_SUBST(TARGET_SYSTEM_ROOT_DEFINE)
|
|
|
|
|
|
|
|
+AC_ARG_ENABLE([poison-system-directories],
|
|
|
|
+ AS_HELP_STRING([--enable-poison-system-directories],
|
|
|
|
+ [warn for use of native system library directories]),,
|
|
|
|
+ [enable_poison_system_directories=no])
|
|
|
|
+if test "x${enable_poison_system_directories}" = "xyes"; then
|
|
|
|
+ AC_DEFINE([ENABLE_POISON_SYSTEM_DIRECTORIES],
|
|
|
|
+ [1],
|
|
|
|
+ [Define to warn for use of native system library directories])
|
|
|
|
+fi
|
|
|
|
+
|
|
|
|
dnl Use --enable-gold to decide if this linker should be the default.
|
|
|
|
dnl "install_as_default" is set to false if gold is the default linker.
|
|
|
|
dnl "installed_linker" is the installed BFD linker name.
|
2016-05-10 23:05:04 +02:00
|
|
|
diff --git a/ld/ld.h b/ld/ld.h
|
2018-11-08 12:32:07 +01:00
|
|
|
index ba914b9..9df17da 100644
|
2016-05-10 23:05:04 +02:00
|
|
|
--- a/ld/ld.h
|
|
|
|
+++ b/ld/ld.h
|
2018-11-08 12:32:07 +01:00
|
|
|
@@ -180,6 +180,14 @@ typedef struct
|
2017-09-21 20:28:28 +02:00
|
|
|
in the linker script. */
|
|
|
|
bfd_boolean force_group_allocation;
|
2016-05-10 23:05:04 +02:00
|
|
|
|
|
|
|
+ /* If TRUE (the default) warn for uses of system directories when
|
|
|
|
+ cross linking. */
|
|
|
|
+ bfd_boolean poison_system_directories;
|
|
|
|
+
|
|
|
|
+ /* If TRUE (default FALSE) give an error for uses of system
|
|
|
|
+ directories when cross linking instead of a warning. */
|
|
|
|
+ bfd_boolean error_poison_system_directories;
|
|
|
|
+
|
|
|
|
/* Big or little endian as set on command line. */
|
|
|
|
enum endian_enum endian;
|
|
|
|
|
2018-11-08 12:32:07 +01:00
|
|
|
diff --git a/ld/ld.texi b/ld/ld.texi
|
|
|
|
index 40d79dd..137d46c 100644
|
|
|
|
--- a/ld/ld.texi
|
|
|
|
+++ b/ld/ld.texi
|
|
|
|
@@ -2479,6 +2479,18 @@ string identifying the original linked file does not change.
|
2016-05-10 23:05:04 +02:00
|
|
|
|
|
|
|
Passing @code{none} for @var{style} disables the setting from any
|
|
|
|
@code{--build-id} options earlier on the command line.
|
|
|
|
+
|
|
|
|
+@kindex --no-poison-system-directories
|
|
|
|
+@item --no-poison-system-directories
|
|
|
|
+Do not warn for @option{-L} options using system directories such as
|
|
|
|
+@file{/usr/lib} when cross linking. This option is intended for use
|
|
|
|
+in chroot environments when such directories contain the correct
|
|
|
|
+libraries for the target system rather than the host.
|
|
|
|
+
|
|
|
|
+@kindex --error-poison-system-directories
|
|
|
|
+@item --error-poison-system-directories
|
|
|
|
+Give an error instead of a warning for @option{-L} options using
|
|
|
|
+system directories when cross linking.
|
|
|
|
@end table
|
|
|
|
|
|
|
|
@c man end
|
|
|
|
diff --git a/ld/ldfile.c b/ld/ldfile.c
|
2018-11-08 12:32:07 +01:00
|
|
|
index b3d166c..3dcbf66 100644
|
2014-12-10 23:53:50 +01:00
|
|
|
--- a/ld/ldfile.c
|
|
|
|
+++ b/ld/ldfile.c
|
2017-09-21 20:28:28 +02:00
|
|
|
@@ -116,6 +116,23 @@ ldfile_add_library_path (const char *name, bfd_boolean cmdline)
|
|
|
|
new_dirs->name = concat (ld_sysroot, name + strlen ("$SYSROOT"), (const char *) NULL);
|
2014-12-10 23:53:50 +01:00
|
|
|
else
|
|
|
|
new_dirs->name = xstrdup (name);
|
|
|
|
+
|
|
|
|
+#ifdef ENABLE_POISON_SYSTEM_DIRECTORIES
|
|
|
|
+ if (command_line.poison_system_directories
|
|
|
|
+ && ((!strncmp (name, "/lib", 4))
|
|
|
|
+ || (!strncmp (name, "/usr/lib", 8))
|
|
|
|
+ || (!strncmp (name, "/usr/local/lib", 14))
|
|
|
|
+ || (!strncmp (name, "/usr/X11R6/lib", 14))))
|
|
|
|
+ {
|
|
|
|
+ if (command_line.error_poison_system_directories)
|
|
|
|
+ einfo (_("%X%P: error: library search path \"%s\" is unsafe for "
|
|
|
|
+ "cross-compilation\n"), name);
|
|
|
|
+ else
|
|
|
|
+ einfo (_("%P: warning: library search path \"%s\" is unsafe for "
|
|
|
|
+ "cross-compilation\n"), name);
|
|
|
|
+ }
|
|
|
|
+#endif
|
|
|
|
+
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Try to open a BFD for a lang_input_statement. */
|
2016-05-10 23:05:04 +02:00
|
|
|
diff --git a/ld/ldlex.h b/ld/ldlex.h
|
2018-11-08 12:32:07 +01:00
|
|
|
index 04d6fd5..d7df005 100644
|
2016-05-10 23:05:04 +02:00
|
|
|
--- a/ld/ldlex.h
|
|
|
|
+++ b/ld/ldlex.h
|
2018-11-08 12:32:07 +01:00
|
|
|
@@ -148,6 +148,8 @@ enum option_values
|
2016-05-10 23:05:04 +02:00
|
|
|
OPTION_REQUIRE_DEFINED_SYMBOL,
|
|
|
|
OPTION_ORPHAN_HANDLING,
|
2017-09-21 20:28:28 +02:00
|
|
|
OPTION_FORCE_GROUP_ALLOCATION,
|
2016-05-10 23:05:04 +02:00
|
|
|
+ OPTION_NO_POISON_SYSTEM_DIRECTORIES,
|
|
|
|
+ OPTION_ERROR_POISON_SYSTEM_DIRECTORIES,
|
|
|
|
};
|
2014-12-10 23:53:50 +01:00
|
|
|
|
2016-05-10 23:05:04 +02:00
|
|
|
/* The initial parser states. */
|
|
|
|
diff --git a/ld/ldmain.c b/ld/ldmain.c
|
2018-11-08 12:32:07 +01:00
|
|
|
index f31eeb2..25f8497 100644
|
2014-12-10 23:53:50 +01:00
|
|
|
--- a/ld/ldmain.c
|
|
|
|
+++ b/ld/ldmain.c
|
2018-11-08 12:32:07 +01:00
|
|
|
@@ -268,6 +268,8 @@ main (int argc, char **argv)
|
2016-05-10 23:05:04 +02:00
|
|
|
command_line.warn_mismatch = TRUE;
|
2014-12-10 23:53:50 +01:00
|
|
|
command_line.warn_search_mismatch = TRUE;
|
|
|
|
command_line.check_section_addresses = -1;
|
|
|
|
+ command_line.poison_system_directories = TRUE;
|
|
|
|
+ command_line.error_poison_system_directories = FALSE;
|
|
|
|
|
|
|
|
/* We initialize DEMANGLING based on the environment variable
|
|
|
|
COLLECT_NO_DEMANGLE. The gcc collect2 program will demangle the
|
2016-05-10 23:05:04 +02:00
|
|
|
diff --git a/ld/lexsup.c b/ld/lexsup.c
|
2018-11-08 12:32:07 +01:00
|
|
|
index 86a033a..f07f095 100644
|
2014-12-10 23:53:50 +01:00
|
|
|
--- a/ld/lexsup.c
|
|
|
|
+++ b/ld/lexsup.c
|
2018-11-08 12:32:07 +01:00
|
|
|
@@ -543,6 +543,14 @@ static const struct ld_option ld_options[] =
|
2016-05-10 23:05:04 +02:00
|
|
|
{ {"orphan-handling", required_argument, NULL, OPTION_ORPHAN_HANDLING},
|
|
|
|
'\0', N_("=MODE"), N_("Control how orphan sections are handled."),
|
2014-12-10 23:53:50 +01:00
|
|
|
TWO_DASHES },
|
|
|
|
+ { {"no-poison-system-directories", no_argument, NULL,
|
2016-05-10 23:05:04 +02:00
|
|
|
+ OPTION_NO_POISON_SYSTEM_DIRECTORIES},
|
2014-12-10 23:53:50 +01:00
|
|
|
+ '\0', NULL, N_("Do not warn for -L options using system directories"),
|
|
|
|
+ TWO_DASHES },
|
|
|
|
+ { {"error-poison-system-directories", no_argument, NULL,
|
2016-05-10 23:05:04 +02:00
|
|
|
+ OPTION_ERROR_POISON_SYSTEM_DIRECTORIES},
|
2014-12-10 23:53:50 +01:00
|
|
|
+ '\0', NULL, N_("Give an error for -L options using system directories"),
|
|
|
|
+ TWO_DASHES },
|
|
|
|
};
|
|
|
|
|
|
|
|
#define OPTION_COUNT ARRAY_SIZE (ld_options)
|
2018-11-08 12:32:07 +01:00
|
|
|
@@ -555,6 +563,7 @@ parse_args (unsigned argc, char **argv)
|
2014-12-10 23:53:50 +01:00
|
|
|
int ingroup = 0;
|
|
|
|
char *default_dirlist = NULL;
|
|
|
|
char *shortopts;
|
|
|
|
+ char *BR_paranoid_env;
|
|
|
|
struct option *longopts;
|
|
|
|
struct option *really_longopts;
|
|
|
|
int last_optind;
|
2018-11-08 12:32:07 +01:00
|
|
|
@@ -1543,6 +1552,14 @@ parse_args (unsigned argc, char **argv)
|
|
|
|
}
|
|
|
|
break;
|
2016-05-10 23:05:04 +02:00
|
|
|
|
|
|
|
+ case OPTION_NO_POISON_SYSTEM_DIRECTORIES:
|
|
|
|
+ command_line.poison_system_directories = FALSE;
|
|
|
|
+ break;
|
2014-12-10 23:53:50 +01:00
|
|
|
+
|
2016-05-10 23:05:04 +02:00
|
|
|
+ case OPTION_ERROR_POISON_SYSTEM_DIRECTORIES:
|
|
|
|
+ command_line.error_poison_system_directories = TRUE;
|
|
|
|
+ break;
|
2014-12-10 23:53:50 +01:00
|
|
|
+
|
2016-05-10 23:05:04 +02:00
|
|
|
case OPTION_PUSH_STATE:
|
|
|
|
input_flags.pushed = xmemdup (&input_flags,
|
|
|
|
sizeof (input_flags),
|
2018-11-08 12:32:07 +01:00
|
|
|
@@ -1586,6 +1603,10 @@ parse_args (unsigned argc, char **argv)
|
2016-05-10 23:05:04 +02:00
|
|
|
command_line.soname = NULL;
|
2014-12-10 23:53:50 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
+ BR_paranoid_env = getenv("BR_COMPILER_PARANOID_UNSAFE_PATH");
|
|
|
|
+ if (BR_paranoid_env && strlen(BR_paranoid_env) > 0)
|
|
|
|
+ command_line.error_poison_system_directories = TRUE;
|
|
|
|
+
|
|
|
|
while (ingroup)
|
|
|
|
{
|
|
|
|
lang_leave_group ();
|
2016-05-10 23:05:04 +02:00
|
|
|
--
|
2018-11-08 12:32:07 +01:00
|
|
|
2.7.4
|
2016-05-10 23:05:04 +02:00
|
|
|
|