153 lines
6.0 KiB
Diff
153 lines
6.0 KiB
Diff
|
From 4af4a4a71827c0bc5e0ec67af23edef4f15cee8e Mon Sep 17 00:00:00 2001
|
||
|
From: Paul Eggert <eggert@cs.ucla.edu>
|
||
|
Date: Mon, 5 Mar 2018 10:56:29 -0800
|
||
|
Subject: [PATCH] fflush: adjust to glibc 2.28 libio.h removal
|
||
|
MIME-Version: 1.0
|
||
|
Content-Type: text/plain; charset=utf8
|
||
|
Content-Transfer-Encoding: 8bit
|
||
|
|
||
|
Problem reported by Daniel P. Berrangé in:
|
||
|
https://lists.gnu.org/r/bug-gnulib/2018-03/msg00000.html
|
||
|
* lib/fbufmode.c (fbufmode):
|
||
|
* lib/fflush.c (clear_ungetc_buffer_preserving_position)
|
||
|
(disable_seek_optimization, rpl_fflush):
|
||
|
* lib/fpending.c (__fpending):
|
||
|
* lib/fpurge.c (fpurge):
|
||
|
* lib/freadable.c (freadable):
|
||
|
* lib/freadahead.c (freadahead):
|
||
|
* lib/freading.c (freading):
|
||
|
* lib/freadptr.c (freadptr):
|
||
|
* lib/freadseek.c (freadptrinc):
|
||
|
* lib/fseeko.c (fseeko):
|
||
|
* lib/fseterr.c (fseterr):
|
||
|
* lib/fwritable.c (fwritable):
|
||
|
* lib/fwriting.c (fwriting):
|
||
|
Check _IO_EOF_SEEN instead of _IO_ftrylockfile.
|
||
|
* lib/stdio-impl.h (_IO_IN_BACKUP) [_IO_EOF_SEEN]:
|
||
|
Define if not already defined.
|
||
|
|
||
|
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
|
||
|
[Backported in version 4.6 after being retrieved from
|
||
|
http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=patch;h=4af4a4a7]
|
||
|
---
|
||
|
gl/lib/fflush.c | 6 +++---
|
||
|
gl/lib/fpurge.c | 2 +-
|
||
|
gl/lib/freadahead.c | 2 +-
|
||
|
gl/lib/freading.c | 2 +-
|
||
|
gl/lib/fseeko.c | 4 ++--
|
||
|
gl/lib/stdio-impl.h | 6 ++++++
|
||
|
6 files changed, 14 insertions(+), 8 deletions(-)
|
||
|
|
||
|
diff --git a/gl/lib/fflush.c b/gl/lib/fflush.c
|
||
|
index 983ade0..a6edfa1 100644
|
||
|
--- a/gl/lib/fflush.c
|
||
|
+++ b/gl/lib/fflush.c
|
||
|
@@ -33,7 +33,7 @@
|
||
|
#undef fflush
|
||
|
|
||
|
|
||
|
-#if defined _IO_ftrylockfile || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */
|
||
|
+#if defined _IO_EOF_SEEN || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */
|
||
|
|
||
|
/* Clear the stream's ungetc buffer, preserving the value of ftello (fp). */
|
||
|
static void
|
||
|
@@ -72,7 +72,7 @@ clear_ungetc_buffer (FILE *fp)
|
||
|
|
||
|
#endif
|
||
|
|
||
|
-#if ! (defined _IO_ftrylockfile || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */)
|
||
|
+#if ! (defined _IO_EOF_SEEN || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */)
|
||
|
|
||
|
# if (defined __sferror || defined __DragonFly__ || defined __ANDROID__) && defined __SNPT
|
||
|
/* FreeBSD, NetBSD, OpenBSD, DragonFly, Mac OS X, Cygwin, Minix 3, Android */
|
||
|
@@ -148,7 +148,7 @@ rpl_fflush (FILE *stream)
|
||
|
if (stream == NULL || ! freading (stream))
|
||
|
return fflush (stream);
|
||
|
|
||
|
-#if defined _IO_ftrylockfile || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */
|
||
|
+#if defined _IO_EOF_SEEN || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */
|
||
|
|
||
|
clear_ungetc_buffer_preserving_position (stream);
|
||
|
|
||
|
diff --git a/gl/lib/fpurge.c b/gl/lib/fpurge.c
|
||
|
index b1d417c..3aedcc3 100644
|
||
|
--- a/gl/lib/fpurge.c
|
||
|
+++ b/gl/lib/fpurge.c
|
||
|
@@ -62,7 +62,7 @@ fpurge (FILE *fp)
|
||
|
/* Most systems provide FILE as a struct and the necessary bitmask in
|
||
|
<stdio.h>, because they need it for implementing getc() and putc() as
|
||
|
fast macros. */
|
||
|
-# if defined _IO_ftrylockfile || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */
|
||
|
+# if defined _IO_EOF_SEEN || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */
|
||
|
fp->_IO_read_end = fp->_IO_read_ptr;
|
||
|
fp->_IO_write_ptr = fp->_IO_write_base;
|
||
|
/* Avoid memory leak when there is an active ungetc buffer. */
|
||
|
diff --git a/gl/lib/freadahead.c b/gl/lib/freadahead.c
|
||
|
index c2ecb5b..23ec76e 100644
|
||
|
--- a/gl/lib/freadahead.c
|
||
|
+++ b/gl/lib/freadahead.c
|
||
|
@@ -30,7 +30,7 @@ extern size_t __sreadahead (FILE *);
|
||
|
size_t
|
||
|
freadahead (FILE *fp)
|
||
|
{
|
||
|
-#if defined _IO_ftrylockfile || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */
|
||
|
+#if defined _IO_EOF_SEEN || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */
|
||
|
if (fp->_IO_write_ptr > fp->_IO_write_base)
|
||
|
return 0;
|
||
|
return (fp->_IO_read_end - fp->_IO_read_ptr)
|
||
|
diff --git a/gl/lib/freading.c b/gl/lib/freading.c
|
||
|
index 73c28ac..c24d0c8 100644
|
||
|
--- a/gl/lib/freading.c
|
||
|
+++ b/gl/lib/freading.c
|
||
|
@@ -31,7 +31,7 @@ freading (FILE *fp)
|
||
|
/* Most systems provide FILE as a struct and the necessary bitmask in
|
||
|
<stdio.h>, because they need it for implementing getc() and putc() as
|
||
|
fast macros. */
|
||
|
-# if defined _IO_ftrylockfile || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */
|
||
|
+# if defined _IO_EOF_SEEN || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */
|
||
|
return ((fp->_flags & _IO_NO_WRITES) != 0
|
||
|
|| ((fp->_flags & (_IO_NO_READS | _IO_CURRENTLY_PUTTING)) == 0
|
||
|
&& fp->_IO_read_base != NULL));
|
||
|
diff --git a/gl/lib/fseeko.c b/gl/lib/fseeko.c
|
||
|
index 0101ab5..193f4e8 100644
|
||
|
--- a/gl/lib/fseeko.c
|
||
|
+++ b/gl/lib/fseeko.c
|
||
|
@@ -47,7 +47,7 @@ fseeko (FILE *fp, off_t offset, int whence)
|
||
|
#endif
|
||
|
|
||
|
/* These tests are based on fpurge.c. */
|
||
|
-#if defined _IO_ftrylockfile || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */
|
||
|
+#if defined _IO_EOF_SEEN || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */
|
||
|
if (fp->_IO_read_end == fp->_IO_read_ptr
|
||
|
&& fp->_IO_write_ptr == fp->_IO_write_base
|
||
|
&& fp->_IO_save_base == NULL)
|
||
|
@@ -123,7 +123,7 @@ fseeko (FILE *fp, off_t offset, int whence)
|
||
|
return -1;
|
||
|
}
|
||
|
|
||
|
-#if defined _IO_ftrylockfile || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */
|
||
|
+#if defined _IO_EOF_SEEN || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */
|
||
|
fp->_flags &= ~_IO_EOF_SEEN;
|
||
|
fp->_offset = pos;
|
||
|
#elif defined __sferror || defined __DragonFly__ || defined __ANDROID__
|
||
|
diff --git a/gl/lib/stdio-impl.h b/gl/lib/stdio-impl.h
|
||
|
index 78d896e..05c5752 100644
|
||
|
--- a/gl/lib/stdio-impl.h
|
||
|
+++ b/gl/lib/stdio-impl.h
|
||
|
@@ -18,6 +18,12 @@
|
||
|
the same implementation of stdio extension API, except that some fields
|
||
|
have different naming conventions, or their access requires some casts. */
|
||
|
|
||
|
+/* Glibc 2.28 made _IO_IN_BACKUP private. For now, work around this
|
||
|
+ problem by defining it ourselves. FIXME: Do not rely on glibc
|
||
|
+ internals. */
|
||
|
+#if !defined _IO_IN_BACKUP && defined _IO_EOF_SEEN
|
||
|
+# define _IO_IN_BACKUP 0x100
|
||
|
+#endif
|
||
|
|
||
|
/* BSD stdio derived implementations. */
|
||
|
|
||
|
--
|
||
|
1.9.1
|
||
|
|