2012-11-11 04:14:56 +01:00
|
|
|
// -*- mode:doc; -*-
|
2013-02-13 13:59:02 +01:00
|
|
|
// vim: set syntax=asciidoc:
|
2012-11-11 04:14:56 +01:00
|
|
|
|
|
|
|
|
[[patch-policy]]
|
|
|
|
|
|
manual: use one-line titles instead of two-line titles (trivial)
Asciidoc supports two syntaxes for section titles: two-line titles (title
plus underline consisting of a particular symbol), and one-line titles
(title prefixed with a specific number of = signs).
The two-line title underlines are:
Level 0 (top level): ======================
Level 1: ----------------------
Level 2: ~~~~~~~~~~~~~~~~~~~~~~
Level 3: ^^^^^^^^^^^^^^^^^^^^^^
Level 4 (bottom level): ++++++++++++++++++++++
and the one-line title prefixes:
= Document Title (level 0) =
== Section title (level 1) ==
=== Section title (level 2) ===
==== Section title (level 3) ====
===== Section title (level 4) =====
The buildroot manual is currenly using the two-line titles, but this has
multiple disadvantages:
- asciidoc also uses some of the underline symbols for other purposes (like
preformatted code, example blocks, ...), which makes it difficult to do
mass replacements, such as a planned follow-up patch that needs to move
all sections one level down.
- it is difficult to remember which level a given underline symbol (=-~^+)
corresponds to, while counting = signs is easy.
This patch changes all two-level titles to one-level titles in the manual.
The bulk of the change was done with the following Python script, except for
the level 1 titles (-----) as these underlines are also used for literal
code blocks.
This patch only changes the titles, no other changes. In
adding-packages-directory.txt, I did add missing newlines between some
titles and their content.
----------------------------------------------------------------------------
#!/usr/bin/env python
import sys
import mmap
import re
for input in sys.argv[1:]:
f = open(input, 'r+')
f.flush()
s = mmap.mmap(f.fileno(), 0)
# Level 0 (top level): ====================== =
# Level 1: ---------------------- ==
# Level 2: ~~~~~~~~~~~~~~~~~~~~~~ ===
# Level 3: ^^^^^^^^^^^^^^^^^^^^^^ ====
# Level 4 (bottom level): ++++++++++++++++++++++ =====
def replace_title(s, symbol, replacement):
pattern = re.compile(r'(.+\n)\%s{2,}\n' % symbol, re.MULTILINE)
return pattern.sub(r'%s \1' % replacement, s)
new = s
new = replace_title(new, '=', '=')
new = replace_title(new, '+', '=====')
new = replace_title(new, '^', '====')
new = replace_title(new, '~', '===')
#new = replace_title(new, '-', '==')
s.seek(0)
s.write(new)
s.resize(s.tell())
s.close()
f.close()
----------------------------------------------------------------------------
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2014-05-02 07:47:30 +02:00
|
|
|
== Patching a package
|
2012-11-11 04:14:56 +01:00
|
|
|
|
|
|
|
|
While integrating a new package or updating an existing one, it may be
|
2012-11-27 12:59:16 +01:00
|
|
|
necessary to patch the source of the software to get it cross-built within
|
2012-11-11 04:14:56 +01:00
|
|
|
Buildroot.
|
|
|
|
|
|
|
|
|
|
Buildroot offers an infrastructure to automatically handle this during
|
rework patch model
At the Buildroot Developers Meeting (4-5 February 2013, in Brussels) a change
to the patch logic was discussed. See
http://elinux.org/Buildroot:DeveloperDaysFOSDEM2013
for details. In summary:
* For patches stored in the package directory, if
package/<pkg>/<version>/ does exist, apply package/<pkg>/<version>/*.patch,
otherwise, apply package/<pkg>/*.patch
* For patches stored in the global patches directory, if
$(GLOBAL_PATCH_DIR)/<pkg>/<version>/ does exist, apply
$(GLOBAL_PATCH_DIR)/<pkg>/<version>/*.patch, otherwise, apply
$(GLOBAL_PATCH_DIR)/<pkg>/*.patch
This patch adds the new BR2_GLOBAL_PATCH_DIR configuration item, and reworks
the generic package infrastructure to implement the new patch logic.
[Peter: fixup doc nits as pointed out by Thomas]
Signed-off-by: Simon Dawson <spdawson@gmail.com>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Tested-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
2013-03-18 00:13:47 +01:00
|
|
|
the builds. It supports three ways of applying patch sets: downloaded patches,
|
|
|
|
|
patches supplied within buildroot and patches located in a user-defined
|
|
|
|
|
global patch directory.
|
2012-11-11 04:14:56 +01:00
|
|
|
|
manual: use one-line titles instead of two-line titles (trivial)
Asciidoc supports two syntaxes for section titles: two-line titles (title
plus underline consisting of a particular symbol), and one-line titles
(title prefixed with a specific number of = signs).
The two-line title underlines are:
Level 0 (top level): ======================
Level 1: ----------------------
Level 2: ~~~~~~~~~~~~~~~~~~~~~~
Level 3: ^^^^^^^^^^^^^^^^^^^^^^
Level 4 (bottom level): ++++++++++++++++++++++
and the one-line title prefixes:
= Document Title (level 0) =
== Section title (level 1) ==
=== Section title (level 2) ===
==== Section title (level 3) ====
===== Section title (level 4) =====
The buildroot manual is currenly using the two-line titles, but this has
multiple disadvantages:
- asciidoc also uses some of the underline symbols for other purposes (like
preformatted code, example blocks, ...), which makes it difficult to do
mass replacements, such as a planned follow-up patch that needs to move
all sections one level down.
- it is difficult to remember which level a given underline symbol (=-~^+)
corresponds to, while counting = signs is easy.
This patch changes all two-level titles to one-level titles in the manual.
The bulk of the change was done with the following Python script, except for
the level 1 titles (-----) as these underlines are also used for literal
code blocks.
This patch only changes the titles, no other changes. In
adding-packages-directory.txt, I did add missing newlines between some
titles and their content.
----------------------------------------------------------------------------
#!/usr/bin/env python
import sys
import mmap
import re
for input in sys.argv[1:]:
f = open(input, 'r+')
f.flush()
s = mmap.mmap(f.fileno(), 0)
# Level 0 (top level): ====================== =
# Level 1: ---------------------- ==
# Level 2: ~~~~~~~~~~~~~~~~~~~~~~ ===
# Level 3: ^^^^^^^^^^^^^^^^^^^^^^ ====
# Level 4 (bottom level): ++++++++++++++++++++++ =====
def replace_title(s, symbol, replacement):
pattern = re.compile(r'(.+\n)\%s{2,}\n' % symbol, re.MULTILINE)
return pattern.sub(r'%s \1' % replacement, s)
new = s
new = replace_title(new, '=', '=')
new = replace_title(new, '+', '=====')
new = replace_title(new, '^', '====')
new = replace_title(new, '~', '===')
#new = replace_title(new, '-', '==')
s.seek(0)
s.write(new)
s.resize(s.tell())
s.close()
f.close()
----------------------------------------------------------------------------
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2014-05-02 07:47:30 +02:00
|
|
|
=== Providing patches
|
2012-11-11 04:14:56 +01:00
|
|
|
|
manual: use one-line titles instead of two-line titles (trivial)
Asciidoc supports two syntaxes for section titles: two-line titles (title
plus underline consisting of a particular symbol), and one-line titles
(title prefixed with a specific number of = signs).
The two-line title underlines are:
Level 0 (top level): ======================
Level 1: ----------------------
Level 2: ~~~~~~~~~~~~~~~~~~~~~~
Level 3: ^^^^^^^^^^^^^^^^^^^^^^
Level 4 (bottom level): ++++++++++++++++++++++
and the one-line title prefixes:
= Document Title (level 0) =
== Section title (level 1) ==
=== Section title (level 2) ===
==== Section title (level 3) ====
===== Section title (level 4) =====
The buildroot manual is currenly using the two-line titles, but this has
multiple disadvantages:
- asciidoc also uses some of the underline symbols for other purposes (like
preformatted code, example blocks, ...), which makes it difficult to do
mass replacements, such as a planned follow-up patch that needs to move
all sections one level down.
- it is difficult to remember which level a given underline symbol (=-~^+)
corresponds to, while counting = signs is easy.
This patch changes all two-level titles to one-level titles in the manual.
The bulk of the change was done with the following Python script, except for
the level 1 titles (-----) as these underlines are also used for literal
code blocks.
This patch only changes the titles, no other changes. In
adding-packages-directory.txt, I did add missing newlines between some
titles and their content.
----------------------------------------------------------------------------
#!/usr/bin/env python
import sys
import mmap
import re
for input in sys.argv[1:]:
f = open(input, 'r+')
f.flush()
s = mmap.mmap(f.fileno(), 0)
# Level 0 (top level): ====================== =
# Level 1: ---------------------- ==
# Level 2: ~~~~~~~~~~~~~~~~~~~~~~ ===
# Level 3: ^^^^^^^^^^^^^^^^^^^^^^ ====
# Level 4 (bottom level): ++++++++++++++++++++++ =====
def replace_title(s, symbol, replacement):
pattern = re.compile(r'(.+\n)\%s{2,}\n' % symbol, re.MULTILINE)
return pattern.sub(r'%s \1' % replacement, s)
new = s
new = replace_title(new, '=', '=')
new = replace_title(new, '+', '=====')
new = replace_title(new, '^', '====')
new = replace_title(new, '~', '===')
#new = replace_title(new, '-', '==')
s.seek(0)
s.write(new)
s.resize(s.tell())
s.close()
f.close()
----------------------------------------------------------------------------
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2014-05-02 07:47:30 +02:00
|
|
|
==== Downloaded
|
2012-11-11 04:14:56 +01:00
|
|
|
|
2013-09-16 09:00:15 +02:00
|
|
|
If it is necessary to apply a patch that is available for download, then add it
|
2017-09-14 16:47:42 +02:00
|
|
|
to the +<packagename>_PATCH+ variable. If an entry contains +://+,
|
|
|
|
|
then Buildroot will assume it is a full URL and download the patch
|
|
|
|
|
from this location. Otherwise, Buildroot will assume that the patch should be
|
|
|
|
|
downloaded from +<packagename>_SITE+. It can be a single patch,
|
|
|
|
|
or a tarball containing a patch series.
|
|
|
|
|
|
|
|
|
|
Like for all downloads, a hash should be added to the +<packagename>.hash+
|
|
|
|
|
file.
|
2012-11-11 04:14:56 +01:00
|
|
|
|
2012-11-27 12:59:17 +01:00
|
|
|
This method is typically used for packages from Debian.
|
2012-11-11 04:14:56 +01:00
|
|
|
|
manual: use one-line titles instead of two-line titles (trivial)
Asciidoc supports two syntaxes for section titles: two-line titles (title
plus underline consisting of a particular symbol), and one-line titles
(title prefixed with a specific number of = signs).
The two-line title underlines are:
Level 0 (top level): ======================
Level 1: ----------------------
Level 2: ~~~~~~~~~~~~~~~~~~~~~~
Level 3: ^^^^^^^^^^^^^^^^^^^^^^
Level 4 (bottom level): ++++++++++++++++++++++
and the one-line title prefixes:
= Document Title (level 0) =
== Section title (level 1) ==
=== Section title (level 2) ===
==== Section title (level 3) ====
===== Section title (level 4) =====
The buildroot manual is currenly using the two-line titles, but this has
multiple disadvantages:
- asciidoc also uses some of the underline symbols for other purposes (like
preformatted code, example blocks, ...), which makes it difficult to do
mass replacements, such as a planned follow-up patch that needs to move
all sections one level down.
- it is difficult to remember which level a given underline symbol (=-~^+)
corresponds to, while counting = signs is easy.
This patch changes all two-level titles to one-level titles in the manual.
The bulk of the change was done with the following Python script, except for
the level 1 titles (-----) as these underlines are also used for literal
code blocks.
This patch only changes the titles, no other changes. In
adding-packages-directory.txt, I did add missing newlines between some
titles and their content.
----------------------------------------------------------------------------
#!/usr/bin/env python
import sys
import mmap
import re
for input in sys.argv[1:]:
f = open(input, 'r+')
f.flush()
s = mmap.mmap(f.fileno(), 0)
# Level 0 (top level): ====================== =
# Level 1: ---------------------- ==
# Level 2: ~~~~~~~~~~~~~~~~~~~~~~ ===
# Level 3: ^^^^^^^^^^^^^^^^^^^^^^ ====
# Level 4 (bottom level): ++++++++++++++++++++++ =====
def replace_title(s, symbol, replacement):
pattern = re.compile(r'(.+\n)\%s{2,}\n' % symbol, re.MULTILINE)
return pattern.sub(r'%s \1' % replacement, s)
new = s
new = replace_title(new, '=', '=')
new = replace_title(new, '+', '=====')
new = replace_title(new, '^', '====')
new = replace_title(new, '~', '===')
#new = replace_title(new, '-', '==')
s.seek(0)
s.write(new)
s.resize(s.tell())
s.close()
f.close()
----------------------------------------------------------------------------
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2014-05-02 07:47:30 +02:00
|
|
|
==== Within Buildroot
|
2012-11-11 04:14:56 +01:00
|
|
|
|
2012-11-16 05:54:19 +01:00
|
|
|
Most patches are provided within Buildroot, in the package
|
2012-11-27 12:59:16 +01:00
|
|
|
directory; these typically aim to fix cross-compilation, libc support,
|
2012-11-16 05:54:19 +01:00
|
|
|
or other such issues.
|
2012-11-11 04:14:56 +01:00
|
|
|
|
2014-12-05 19:06:24 +01:00
|
|
|
These patch files should be named +<number>-<description>.patch+.
|
2012-11-11 04:14:56 +01:00
|
|
|
|
2013-02-28 12:24:26 +01:00
|
|
|
.Notes
|
|
|
|
|
- The patch files coming with Buildroot should not contain any package version
|
2014-12-05 19:06:24 +01:00
|
|
|
reference in their filename.
|
|
|
|
|
- The field +<number>+ in the patch file name refers to the 'apply order',
|
|
|
|
|
and shall start at 1; It is preferred to pad the number with zeros up to 4
|
|
|
|
|
digits, like 'git-format-patch' does. E.g.: +0001-foobar-the-buz.patch+
|
2022-08-28 11:24:30 +02:00
|
|
|
- The patch email subject prefix shall not be numbered. Patches shall
|
|
|
|
|
be generated with the +git format-patch -N+ command, since this
|
|
|
|
|
numbering is automatically added for series. For example, the patch
|
|
|
|
|
subject line should look like +Subject: [PATCH] foobar the buz+ rather
|
|
|
|
|
than +Subject: [PATCH n/m] foobar the buz+.
|
2014-12-05 19:06:24 +01:00
|
|
|
- Previously, it was mandatory for patches to be prefixed with the name of
|
|
|
|
|
the package, like +<package>-<number>-<description>.patch+, but that is
|
|
|
|
|
no longer the case. Existing packages will be fixed as time passes. 'Do
|
|
|
|
|
not prefix patches with the package name.'
|
|
|
|
|
- Previously, a +series+ file, as used by +quilt+, could also be added in
|
|
|
|
|
the package directory. In that case, the +series+ file defines the patch
|
|
|
|
|
application order. This is deprecated, and will be removed in the future.
|
|
|
|
|
'Do not use a series file.'
|
|
|
|
|
|
2013-02-28 12:24:26 +01:00
|
|
|
|
manual: use one-line titles instead of two-line titles (trivial)
Asciidoc supports two syntaxes for section titles: two-line titles (title
plus underline consisting of a particular symbol), and one-line titles
(title prefixed with a specific number of = signs).
The two-line title underlines are:
Level 0 (top level): ======================
Level 1: ----------------------
Level 2: ~~~~~~~~~~~~~~~~~~~~~~
Level 3: ^^^^^^^^^^^^^^^^^^^^^^
Level 4 (bottom level): ++++++++++++++++++++++
and the one-line title prefixes:
= Document Title (level 0) =
== Section title (level 1) ==
=== Section title (level 2) ===
==== Section title (level 3) ====
===== Section title (level 4) =====
The buildroot manual is currenly using the two-line titles, but this has
multiple disadvantages:
- asciidoc also uses some of the underline symbols for other purposes (like
preformatted code, example blocks, ...), which makes it difficult to do
mass replacements, such as a planned follow-up patch that needs to move
all sections one level down.
- it is difficult to remember which level a given underline symbol (=-~^+)
corresponds to, while counting = signs is easy.
This patch changes all two-level titles to one-level titles in the manual.
The bulk of the change was done with the following Python script, except for
the level 1 titles (-----) as these underlines are also used for literal
code blocks.
This patch only changes the titles, no other changes. In
adding-packages-directory.txt, I did add missing newlines between some
titles and their content.
----------------------------------------------------------------------------
#!/usr/bin/env python
import sys
import mmap
import re
for input in sys.argv[1:]:
f = open(input, 'r+')
f.flush()
s = mmap.mmap(f.fileno(), 0)
# Level 0 (top level): ====================== =
# Level 1: ---------------------- ==
# Level 2: ~~~~~~~~~~~~~~~~~~~~~~ ===
# Level 3: ^^^^^^^^^^^^^^^^^^^^^^ ====
# Level 4 (bottom level): ++++++++++++++++++++++ =====
def replace_title(s, symbol, replacement):
pattern = re.compile(r'(.+\n)\%s{2,}\n' % symbol, re.MULTILINE)
return pattern.sub(r'%s \1' % replacement, s)
new = s
new = replace_title(new, '=', '=')
new = replace_title(new, '+', '=====')
new = replace_title(new, '^', '====')
new = replace_title(new, '~', '===')
#new = replace_title(new, '-', '==')
s.seek(0)
s.write(new)
s.resize(s.tell())
s.close()
f.close()
----------------------------------------------------------------------------
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2014-05-02 07:47:30 +02:00
|
|
|
==== Global patch directory
|
rework patch model
At the Buildroot Developers Meeting (4-5 February 2013, in Brussels) a change
to the patch logic was discussed. See
http://elinux.org/Buildroot:DeveloperDaysFOSDEM2013
for details. In summary:
* For patches stored in the package directory, if
package/<pkg>/<version>/ does exist, apply package/<pkg>/<version>/*.patch,
otherwise, apply package/<pkg>/*.patch
* For patches stored in the global patches directory, if
$(GLOBAL_PATCH_DIR)/<pkg>/<version>/ does exist, apply
$(GLOBAL_PATCH_DIR)/<pkg>/<version>/*.patch, otherwise, apply
$(GLOBAL_PATCH_DIR)/<pkg>/*.patch
This patch adds the new BR2_GLOBAL_PATCH_DIR configuration item, and reworks
the generic package infrastructure to implement the new patch logic.
[Peter: fixup doc nits as pointed out by Thomas]
Signed-off-by: Simon Dawson <spdawson@gmail.com>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Tested-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
2013-03-18 00:13:47 +01:00
|
|
|
|
|
|
|
|
The +BR2_GLOBAL_PATCH_DIR+ configuration file option can be
|
2013-12-18 11:25:02 +01:00
|
|
|
used to specify a space separated list of one or more directories
|
2014-09-18 21:39:31 +02:00
|
|
|
containing global package patches. See xref:customize-patches[] for
|
2013-12-18 11:25:02 +01:00
|
|
|
details.
|
2013-02-28 12:24:26 +01:00
|
|
|
|
2013-12-18 11:25:02 +01:00
|
|
|
[[patch-apply-order]]
|
manual: use one-line titles instead of two-line titles (trivial)
Asciidoc supports two syntaxes for section titles: two-line titles (title
plus underline consisting of a particular symbol), and one-line titles
(title prefixed with a specific number of = signs).
The two-line title underlines are:
Level 0 (top level): ======================
Level 1: ----------------------
Level 2: ~~~~~~~~~~~~~~~~~~~~~~
Level 3: ^^^^^^^^^^^^^^^^^^^^^^
Level 4 (bottom level): ++++++++++++++++++++++
and the one-line title prefixes:
= Document Title (level 0) =
== Section title (level 1) ==
=== Section title (level 2) ===
==== Section title (level 3) ====
===== Section title (level 4) =====
The buildroot manual is currenly using the two-line titles, but this has
multiple disadvantages:
- asciidoc also uses some of the underline symbols for other purposes (like
preformatted code, example blocks, ...), which makes it difficult to do
mass replacements, such as a planned follow-up patch that needs to move
all sections one level down.
- it is difficult to remember which level a given underline symbol (=-~^+)
corresponds to, while counting = signs is easy.
This patch changes all two-level titles to one-level titles in the manual.
The bulk of the change was done with the following Python script, except for
the level 1 titles (-----) as these underlines are also used for literal
code blocks.
This patch only changes the titles, no other changes. In
adding-packages-directory.txt, I did add missing newlines between some
titles and their content.
----------------------------------------------------------------------------
#!/usr/bin/env python
import sys
import mmap
import re
for input in sys.argv[1:]:
f = open(input, 'r+')
f.flush()
s = mmap.mmap(f.fileno(), 0)
# Level 0 (top level): ====================== =
# Level 1: ---------------------- ==
# Level 2: ~~~~~~~~~~~~~~~~~~~~~~ ===
# Level 3: ^^^^^^^^^^^^^^^^^^^^^^ ====
# Level 4 (bottom level): ++++++++++++++++++++++ =====
def replace_title(s, symbol, replacement):
pattern = re.compile(r'(.+\n)\%s{2,}\n' % symbol, re.MULTILINE)
return pattern.sub(r'%s \1' % replacement, s)
new = s
new = replace_title(new, '=', '=')
new = replace_title(new, '+', '=====')
new = replace_title(new, '^', '====')
new = replace_title(new, '~', '===')
#new = replace_title(new, '-', '==')
s.seek(0)
s.write(new)
s.resize(s.tell())
s.close()
f.close()
----------------------------------------------------------------------------
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2014-05-02 07:47:30 +02:00
|
|
|
=== How patches are applied
|
2012-11-11 04:14:56 +01:00
|
|
|
|
|
|
|
|
. Run the +<packagename>_PRE_PATCH_HOOKS+ commands if defined;
|
|
|
|
|
|
2012-11-16 05:54:19 +01:00
|
|
|
. Cleanup the build directory, removing any existing +*.rej+ files;
|
2012-11-11 04:14:56 +01:00
|
|
|
|
|
|
|
|
. If +<packagename>_PATCH+ is defined, then patches from these
|
|
|
|
|
tarballs are applied;
|
|
|
|
|
|
2013-12-18 11:25:02 +01:00
|
|
|
. If there are some +*.patch+ files in the package's Buildroot
|
|
|
|
|
directory or in a package subdirectory named +<packageversion>+,
|
|
|
|
|
then:
|
2012-11-11 04:14:56 +01:00
|
|
|
+
|
|
|
|
|
* If a +series+ file exists in the package directory, then patches are
|
|
|
|
|
applied according to the +series+ file;
|
|
|
|
|
+
|
2016-08-09 15:33:04 +02:00
|
|
|
* Otherwise, patch files matching +*.patch+ are applied in alphabetical
|
|
|
|
|
order.
|
2013-12-18 11:25:02 +01:00
|
|
|
So, to ensure they are applied in the right order, it is highly
|
|
|
|
|
recommended to name the patch files like this:
|
2016-08-09 15:33:04 +02:00
|
|
|
+<number>-<description>.patch+, where +<number>+ refers to the
|
|
|
|
|
'apply order'.
|
2012-11-11 04:14:56 +01:00
|
|
|
|
2013-12-18 11:25:02 +01:00
|
|
|
. If +BR2_GLOBAL_PATCH_DIR+ is defined, the directories will be
|
|
|
|
|
enumerated in the order they are specified. The patches are applied
|
|
|
|
|
as described in the previous step.
|
|
|
|
|
|
2012-11-11 04:14:56 +01:00
|
|
|
. Run the +<packagename>_POST_PATCH_HOOKS+ commands if defined.
|
|
|
|
|
|
|
|
|
|
If something goes wrong in the steps _3_ or _4_, then the build fails.
|
|
|
|
|
|
manual: use one-line titles instead of two-line titles (trivial)
Asciidoc supports two syntaxes for section titles: two-line titles (title
plus underline consisting of a particular symbol), and one-line titles
(title prefixed with a specific number of = signs).
The two-line title underlines are:
Level 0 (top level): ======================
Level 1: ----------------------
Level 2: ~~~~~~~~~~~~~~~~~~~~~~
Level 3: ^^^^^^^^^^^^^^^^^^^^^^
Level 4 (bottom level): ++++++++++++++++++++++
and the one-line title prefixes:
= Document Title (level 0) =
== Section title (level 1) ==
=== Section title (level 2) ===
==== Section title (level 3) ====
===== Section title (level 4) =====
The buildroot manual is currenly using the two-line titles, but this has
multiple disadvantages:
- asciidoc also uses some of the underline symbols for other purposes (like
preformatted code, example blocks, ...), which makes it difficult to do
mass replacements, such as a planned follow-up patch that needs to move
all sections one level down.
- it is difficult to remember which level a given underline symbol (=-~^+)
corresponds to, while counting = signs is easy.
This patch changes all two-level titles to one-level titles in the manual.
The bulk of the change was done with the following Python script, except for
the level 1 titles (-----) as these underlines are also used for literal
code blocks.
This patch only changes the titles, no other changes. In
adding-packages-directory.txt, I did add missing newlines between some
titles and their content.
----------------------------------------------------------------------------
#!/usr/bin/env python
import sys
import mmap
import re
for input in sys.argv[1:]:
f = open(input, 'r+')
f.flush()
s = mmap.mmap(f.fileno(), 0)
# Level 0 (top level): ====================== =
# Level 1: ---------------------- ==
# Level 2: ~~~~~~~~~~~~~~~~~~~~~~ ===
# Level 3: ^^^^^^^^^^^^^^^^^^^^^^ ====
# Level 4 (bottom level): ++++++++++++++++++++++ =====
def replace_title(s, symbol, replacement):
pattern = re.compile(r'(.+\n)\%s{2,}\n' % symbol, re.MULTILINE)
return pattern.sub(r'%s \1' % replacement, s)
new = s
new = replace_title(new, '=', '=')
new = replace_title(new, '+', '=====')
new = replace_title(new, '^', '====')
new = replace_title(new, '~', '===')
#new = replace_title(new, '-', '==')
s.seek(0)
s.write(new)
s.resize(s.tell())
s.close()
f.close()
----------------------------------------------------------------------------
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2014-05-02 07:47:30 +02:00
|
|
|
=== Format and licensing of the package patches
|
2012-11-11 04:14:56 +01:00
|
|
|
|
2016-02-01 23:19:53 +01:00
|
|
|
Patches are released under the same license as the software they apply
|
2016-03-01 12:01:04 +01:00
|
|
|
to (see xref:legal-info-buildroot[]).
|
2012-11-11 04:14:56 +01:00
|
|
|
|
2012-11-16 05:54:19 +01:00
|
|
|
A message explaining what the patch does, and why it is needed, should
|
|
|
|
|
be added in the header commentary of the patch.
|
2012-11-11 04:14:56 +01:00
|
|
|
|
2012-11-27 12:59:17 +01:00
|
|
|
You should add a +Signed-off-by+ statement in the header of the each
|
|
|
|
|
patch to help with keeping track of the changes and to certify that the
|
|
|
|
|
patch is released under the same license as the software that is modified.
|
2012-11-11 04:14:56 +01:00
|
|
|
|
2012-11-16 05:54:19 +01:00
|
|
|
If the software is under version control, it is recommended to use the
|
2012-11-27 12:59:17 +01:00
|
|
|
upstream SCM software to generate the patch set.
|
2012-11-11 04:14:56 +01:00
|
|
|
|
|
|
|
|
Otherwise, concatenate the header with the output of the
|
2012-11-27 12:59:17 +01:00
|
|
|
+diff -purN package-version.orig/ package-version/+ command.
|
2012-11-11 04:14:56 +01:00
|
|
|
|
2015-12-02 23:13:26 +01:00
|
|
|
If you update an existing patch (e.g. when bumping the package version),
|
|
|
|
|
make sure the existing From header and Signed-off-by tags are not
|
|
|
|
|
removed, but do update the rest of the patch comment when appropriate.
|
|
|
|
|
|
2012-11-11 04:14:56 +01:00
|
|
|
At the end, the patch should look like:
|
|
|
|
|
|
|
|
|
|
---------------
|
|
|
|
|
configure.ac: add C++ support test
|
|
|
|
|
|
2013-09-16 15:07:28 +02:00
|
|
|
Signed-off-by: John Doe <john.doe@noname.org>
|
2012-11-11 04:14:56 +01:00
|
|
|
|
|
|
|
|
--- configure.ac.orig
|
|
|
|
|
+++ configure.ac
|
|
|
|
|
@@ -40,2 +40,12 @@
|
|
|
|
|
|
|
|
|
|
AC_PROG_MAKE_SET
|
|
|
|
|
+
|
|
|
|
|
+AC_CACHE_CHECK([whether the C++ compiler works],
|
|
|
|
|
+ [rw_cv_prog_cxx_works],
|
|
|
|
|
+ [AC_LANG_PUSH([C++])
|
|
|
|
|
+ AC_LINK_IFELSE([AC_LANG_PROGRAM([], [])],
|
|
|
|
|
+ [rw_cv_prog_cxx_works=yes],
|
|
|
|
|
+ [rw_cv_prog_cxx_works=no])
|
|
|
|
|
+ AC_LANG_POP([C++])])
|
|
|
|
|
+
|
|
|
|
|
+AM_CONDITIONAL([CXX_WORKS], [test "x$rw_cv_prog_cxx_works" = "xyes"])
|
|
|
|
|
---------------
|
|
|
|
|
|
2023-04-03 16:41:03 +02:00
|
|
|
=== Additional patch documentation
|
2012-11-11 04:14:56 +01:00
|
|
|
|
2023-04-03 16:41:03 +02:00
|
|
|
Ideally, all patches should document an upstream patch or patch submission, when
|
|
|
|
|
applicable, via the +Upstream+ trailer.
|
2012-11-11 04:14:56 +01:00
|
|
|
|
2023-04-03 16:41:03 +02:00
|
|
|
When backporting an upstream patch that has been accepted into mainline, it is
|
|
|
|
|
preferred that the URL to the commit is referenced:
|
2012-11-11 04:14:56 +01:00
|
|
|
|
|
|
|
|
---------------
|
2023-04-03 16:41:03 +02:00
|
|
|
Upstream: <URL to upstream commit>
|
2012-11-11 04:14:56 +01:00
|
|
|
---------------
|
|
|
|
|
|
2023-04-03 16:41:03 +02:00
|
|
|
If a new issue is identified in Buildroot and upstream is generally affected by
|
|
|
|
|
the issue (it's not a Buildroot specific issue), users should submit the patch
|
|
|
|
|
upstream and provide a link to that submission when possible:
|
2012-11-11 04:14:56 +01:00
|
|
|
|
|
|
|
|
---------------
|
2023-04-03 16:41:03 +02:00
|
|
|
Upstream: <URL to upstream mailing list submission or merge request>
|
2012-11-11 04:14:56 +01:00
|
|
|
---------------
|
|
|
|
|
|
2023-04-03 16:41:03 +02:00
|
|
|
Patches that have been submitted but were denied upstream should note that and
|
|
|
|
|
include comments about why the patch is being used despite the upstream status.
|
|
|
|
|
|
|
|
|
|
Note: in any of the above scenarios, it is also sensible to add a few words
|
|
|
|
|
about any changes to the patch that may have been necessary.
|
|
|
|
|
|
|
|
|
|
If a patch does not apply upstream then this should be noted with a comment:
|
|
|
|
|
|
|
|
|
|
---------------
|
|
|
|
|
Upstream: N/A <additional information about why patch is Buildroot specific>
|
|
|
|
|
---------------
|
|
|
|
|
|
|
|
|
|
Adding this documentation helps streamline the patch review process during
|
|
|
|
|
package version updates.
|
