NetCube-Systems-Austria/kumquat-buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
3ab421080c
kumquat-buildroot/package/jpeg/Config.in

57 lines
1.3 KiB
Plaintext
Raw Normal View History

jpeg: rework jpeg-turbo simd support handling In preperation for adding more architectures to the jpeg-turbo simd handling, introduce a hidden BR2_PACKAGE_JPEG_SIMDS_SUPPORT symbol and use that to enable simd support and default to jpeg-turbo, instead of open coding it in both places. While we are at it, reword the help text to be more useful. Signed-off-by: Peter Korsgaard <peter@korsgaard.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2016-12-11 16:52:17 +01:00
# jpeg-turbo has simd support for some architectures
config BR2_PACKAGE_JPEG_SIMD_SUPPORT
package/jpeg: better indentation Use easier-to-read layout; fix leading spaces. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Peter Korsgaard <peter@korsgaard.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2016-12-11 19:14:23 +01:00
bool
default y if BR2_X86_CPU_HAS_MMX
default y if BR2_ARM_CPU_HAS_NEON
default y if BR2_POWERPC_CPU_HAS_ALTIVEC
default y if BR2_aarch64 || BR2_aarch64_be
jpeg: rework jpeg-turbo simd support handling In preperation for adding more architectures to the jpeg-turbo simd handling, introduce a hidden BR2_PACKAGE_JPEG_SIMDS_SUPPORT symbol and use that to enable simd support and default to jpeg-turbo, instead of open coding it in both places. While we are at it, reword the help text to be more useful. Signed-off-by: Peter Korsgaard <peter@korsgaard.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2016-12-11 16:52:17 +01:00
package/jpeg: properly indent in menuconfig Since there is a variable definition between the definition of BR2_PACKAGE_JPEG and the choice depending on it, the choice is not indented bewlo the "jpeg support" prompt, like we like to have: [*] jpeg support jpeg variant (jpeg-turbo) ---> Move the BR2_PACKAGE_JPEG right before the choice (really, move BR2_PACKAGE_JPEG_SIMD_SUPPORT before BR2_PACKAGE_JPEG, but diff finds the move of BR2_PACKAGE_JPEG is smaller to display): [*] jpeg support jpeg variant (jpeg-turbo) ---> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
2020-04-12 15:12:57 +02:00
config BR2_PACKAGE_JPEG
bool "jpeg support"
help
Select the desired JPEG library provider.
package: add selection between libjpeg and jpeg-turbo Introduce a virtual 'jpeg' package, which pulls in either libjpeg or jpeg-turbo depending on a choice selection. Rename jpeg package to libjpeg so we can reuse 'jpeg' for the virtual package, making the change transparent to existing users and all the packages using libjpeg. Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
2012-12-13 23:58:11 +01:00
if BR2_PACKAGE_JPEG
choice
prompt "jpeg variant"
jpeg: rework jpeg-turbo simd support handling In preperation for adding more architectures to the jpeg-turbo simd handling, introduce a hidden BR2_PACKAGE_JPEG_SIMDS_SUPPORT symbol and use that to enable simd support and default to jpeg-turbo, instead of open coding it in both places. While we are at it, reword the help text to be more useful. Signed-off-by: Peter Korsgaard <peter@korsgaard.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2016-12-11 16:52:17 +01:00
default BR2_PACKAGE_JPEG_TURBO if BR2_PACKAGE_JPEG_SIMD_SUPPORT
package: add selection between libjpeg and jpeg-turbo Introduce a virtual 'jpeg' package, which pulls in either libjpeg or jpeg-turbo depending on a choice selection. Rename jpeg package to libjpeg so we can reuse 'jpeg' for the virtual package, making the change transparent to existing users and all the packages using libjpeg. Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
2012-12-13 23:58:11 +01:00
help
jpeg: rework jpeg-turbo simd support handling In preperation for adding more architectures to the jpeg-turbo simd handling, introduce a hidden BR2_PACKAGE_JPEG_SIMDS_SUPPORT symbol and use that to enable simd support and default to jpeg-turbo, instead of open coding it in both places. While we are at it, reword the help text to be more useful. Signed-off-by: Peter Korsgaard <peter@korsgaard.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2016-12-11 16:52:17 +01:00
Select the normal libjpeg or libjpeg-turbo.
package: add selection between libjpeg and jpeg-turbo Introduce a virtual 'jpeg' package, which pulls in either libjpeg or jpeg-turbo depending on a choice selection. Rename jpeg package to libjpeg so we can reuse 'jpeg' for the virtual package, making the change transparent to existing users and all the packages using libjpeg. Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
2012-12-13 23:58:11 +01:00
config BR2_PACKAGE_LIBJPEG
merge help descriptions written by Tom Cameron
2004-12-24 10:39:23 +01:00
bool "jpeg"
package/jpeg: make it behave more like other virtual packages Currently, the virtual package jpeg is a special virtual package, as it offers a choice for its implementation, rather than letting the user enable them manually. In so doing, it defines its _HAS option as a 'def_bool y' rather than letting each implementation 'select' it. Since we are going to generate a list of virtual packages and their providers, this defeats the heuristic used to find providers. Coming with an alternate heuristic that also matches the jpeg package is quite complex, so better and easier to make it look more like any other virtual package. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Samuel Martin <s.martin49@gmail.com> Reviewed-by: Samuel Martin <s.martin49@gmail.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-06-08 16:15:08 +02:00
select BR2_PACKAGE_HAS_JPEG
final step in buildroot facelift
2004-10-09 08:13:40 +02:00
help
merge help descriptions written by Tom Cameron
2004-12-24 10:39:23 +01:00
The ubiquitous C library for manipulating JPEG images.
final step in buildroot facelift
2004-10-09 08:13:40 +02:00
merge help descriptions written by Tom Cameron
2004-12-24 10:39:23 +01:00
http://www.ijg.org/
package: add selection between libjpeg and jpeg-turbo Introduce a virtual 'jpeg' package, which pulls in either libjpeg or jpeg-turbo depending on a choice selection. Rename jpeg package to libjpeg so we can reuse 'jpeg' for the virtual package, making the change transparent to existing users and all the packages using libjpeg. Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
2012-12-13 23:58:11 +01:00
config BR2_PACKAGE_JPEG_TURBO
bool "jpeg-turbo"
package/jpeg: make it behave more like other virtual packages Currently, the virtual package jpeg is a special virtual package, as it offers a choice for its implementation, rather than letting the user enable them manually. In so doing, it defines its _HAS option as a 'def_bool y' rather than letting each implementation 'select' it. Since we are going to generate a list of virtual packages and their providers, this defeats the heuristic used to find providers. Coming with an alternate heuristic that also matches the jpeg package is quite complex, so better and easier to make it look more like any other virtual package. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Samuel Martin <s.martin49@gmail.com> Reviewed-by: Samuel Martin <s.martin49@gmail.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-06-08 16:15:08 +02:00
select BR2_PACKAGE_HAS_JPEG
package: add selection between libjpeg and jpeg-turbo Introduce a virtual 'jpeg' package, which pulls in either libjpeg or jpeg-turbo depending on a choice selection. Rename jpeg package to libjpeg so we can reuse 'jpeg' for the virtual package, making the change transparent to existing users and all the packages using libjpeg. Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
2012-12-13 23:58:11 +01:00
help
Libjpeg-turbo is a derivative of libjpeg that uses SIMD
instructions (MMX, SSE2, NEON) to accelerate baseline JPEG
compression and decompression on x86, x86-64, and ARM
systems.
http://www.libjpeg-turbo.org
core: allow br2-external trees to provide libjpeg Similar to toolchains, we now offer a way for br2-external trees to provide their libjpeg implementation, which gets included in the jpeg choice. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Vadim Kochan <vadim4j@gmail.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2019-07-29 22:20:01 +02:00
# libjpeg from br2-external trees, if any
source "$BR2_BASE_DIR/.br2-external.in.jpeg"
package: add selection between libjpeg and jpeg-turbo Introduce a virtual 'jpeg' package, which pulls in either libjpeg or jpeg-turbo depending on a choice selection. Rename jpeg package to libjpeg so we can reuse 'jpeg' for the virtual package, making the change transparent to existing users and all the packages using libjpeg. Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
2012-12-13 23:58:11 +01:00
endchoice
package/jpeg-turbo: allow installing tools Currently, the jpeg-turbo tools are forcibly removed, but they can be usefull (e.g. to test performance on the target, or to script batch conversions). Add an option to allow keeping them. Signed-off-by: Clément Péron <peron.clem@gmail.com> [yann.morin.1998@free.fr - move the option out of the choice - move the option to a Config.in.options - drop the default 'n', which is ... the default - use positive logic to define the hook - move definition of the hook in the conditional block - don't indent the hook assignment ] Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
2020-04-12 13:06:32 +02:00
source "package/jpeg-turbo/Config.in.options"
package/jpeg: convert to the virtual-package infrastructure Since this package is implemented via a choice rather than the usual separate-package providers, we only need BR2_PACKAGE_HAS_JPEG to be always defined when the 'jpeg' package is selected. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com> Cc: Mike Zick <minimod@morethan.org> Reviewed-by: Samuel Martin <s.martin49@gmail.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-04-05 17:21:54 +02:00
config BR2_PACKAGE_HAS_JPEG
package/jpeg: make it behave more like other virtual packages Currently, the virtual package jpeg is a special virtual package, as it offers a choice for its implementation, rather than letting the user enable them manually. In so doing, it defines its _HAS option as a 'def_bool y' rather than letting each implementation 'select' it. Since we are going to generate a list of virtual packages and their providers, this defeats the heuristic used to find providers. Coming with an alternate heuristic that also matches the jpeg package is quite complex, so better and easier to make it look more like any other virtual package. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Samuel Martin <s.martin49@gmail.com> Reviewed-by: Samuel Martin <s.martin49@gmail.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-06-08 16:15:08 +02:00
bool
package/jpeg: convert to the virtual-package infrastructure Since this package is implemented via a choice rather than the usual separate-package providers, we only need BR2_PACKAGE_HAS_JPEG to be always defined when the 'jpeg' package is selected. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com> Cc: Mike Zick <minimod@morethan.org> Reviewed-by: Samuel Martin <s.martin49@gmail.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-04-05 17:21:54 +02:00
package/libjpeg: switch to package-defined providers For the underlying reasons, see previous patch, titled: package/opengl/libegl: switch to package-defined providers Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Arnout Vandecappelle <arnout@mind.be> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Peter Korsgaard <jacmet@uclibc.org> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2013-12-20 23:27:58 +01:00
config BR2_PACKAGE_PROVIDES_JPEG
string
default "libjpeg" if BR2_PACKAGE_LIBJPEG
default "jpeg-turbo" if BR2_PACKAGE_JPEG_TURBO
package: add selection between libjpeg and jpeg-turbo Introduce a virtual 'jpeg' package, which pulls in either libjpeg or jpeg-turbo depending on a choice selection. Rename jpeg package to libjpeg so we can reuse 'jpeg' for the virtual package, making the change transparent to existing users and all the packages using libjpeg. Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
2012-12-13 23:58:11 +01:00
endif
Reference in New Issue Copy Permalink