2009-11-08 18:37:36 +01:00
|
|
|
################################################################################
|
|
|
|
|
# Generic package infrastructure
|
|
|
|
|
#
|
|
|
|
|
# This file implements an infrastructure that eases development of
|
2012-04-17 16:45:20 +02:00
|
|
|
# package .mk files. It should be used for packages that do not rely
|
|
|
|
|
# on a well-known build system for which Buildroot has a dedicated
|
|
|
|
|
# infrastructure (so far, Buildroot has special support for
|
|
|
|
|
# autotools-based and CMake-based packages).
|
2009-11-08 18:37:36 +01:00
|
|
|
#
|
|
|
|
|
# See the Buildroot documentation for details on the usage of this
|
|
|
|
|
# infrastructure
|
|
|
|
|
#
|
|
|
|
|
# In terms of implementation, this generic infrastructure requires the
|
|
|
|
|
# .mk file to specify:
|
|
|
|
|
#
|
2014-07-24 20:07:02 +02:00
|
|
|
# 1. Metadata information about the package: name, version,
|
2009-11-08 18:37:36 +01:00
|
|
|
# download URL, etc.
|
|
|
|
|
#
|
|
|
|
|
# 2. Description of the commands to be executed to configure, build
|
|
|
|
|
# and install the package
|
|
|
|
|
################################################################################
|
|
|
|
|
|
2013-11-11 16:03:27 +01:00
|
|
|
################################################################################
|
|
|
|
|
# Helper functions to catch start/end of each step
|
|
|
|
|
################################################################################
|
|
|
|
|
|
|
|
|
|
# Those two functions are called by each step below.
|
|
|
|
|
# They are responsible for calling all hooks defined in
|
|
|
|
|
# $(GLOBAL_INSTRUMENTATION_HOOKS) and pass each of them
|
|
|
|
|
# three arguments:
|
|
|
|
|
# $1: either 'start' or 'end'
|
|
|
|
|
# $2: the name of the step
|
|
|
|
|
# $3: the name of the package
|
|
|
|
|
|
|
|
|
|
# Start step
|
|
|
|
|
# $1: step name
|
|
|
|
|
define step_start
|
|
|
|
|
$(foreach hook,$(GLOBAL_INSTRUMENTATION_HOOKS),$(call $(hook),start,$(1),$($(PKG)_NAME))$(sep))
|
|
|
|
|
endef
|
|
|
|
|
|
|
|
|
|
# End step
|
|
|
|
|
# $1: step name
|
|
|
|
|
define step_end
|
|
|
|
|
$(foreach hook,$(GLOBAL_INSTRUMENTATION_HOOKS),$(call $(hook),end,$(1),$($(PKG)_NAME))$(sep))
|
|
|
|
|
endef
|
|
|
|
|
|
2013-11-11 16:03:28 +01:00
|
|
|
#######################################
|
|
|
|
|
# Actual steps hooks
|
|
|
|
|
|
|
|
|
|
# Time steps
|
|
|
|
|
define step_time
|
|
|
|
|
printf "%s:%-5.5s:%-20.20s: %s\n" \
|
|
|
|
|
"$$(date +%s)" "$(1)" "$(2)" "$(3)" \
|
|
|
|
|
>>"$(BUILD_DIR)/build-time.log"
|
|
|
|
|
endef
|
|
|
|
|
GLOBAL_INSTRUMENTATION_HOOKS += step_time
|
|
|
|
|
|
2015-10-17 15:33:42 +02:00
|
|
|
# Hooks to collect statistics about installed files
|
|
|
|
|
|
2017-10-28 17:30:58 +02:00
|
|
|
# The suffix is typically empty for the target variant, for legacy backward
|
|
|
|
|
# compatibility.
|
core/instrumentation: shave minutes off the build time
As part of the build, we run some instrumentation hooks to gather
statistics about the usage of the target/, staging/ and host/
directories, so that we can generate reports for the user, that
shows:
- for each file, what package installed it,
- for each package,the size that it installed.
In so doing, we run a double md5 pass on all files of the affected
directories (before/after installation). These passes were mostly invisible
when we were only scanning target/, but has greatly increased in time now
that we also scan staging/ and host/ (but only in the corresponding _CMDS,
of course).
This md5 was mostly aimed at catching packages that would "cheat" with
mtime/atime/ctime somehow. They can't really cheat on md5, though [0].
Timings however speak for themselves, with this defconfig (slightly
biggish-but-still-manageable build) [1].
host/ 20965 files 1.2GiB
staging/ 4715 files 333MiB
target/ 1801 files 44MiB
All instrumentation steps, using md5: 19min 27s
All instrumentation steps, using mtime: 14min 45s
No instrumentation step at all: 14min 31s
So, using mtime is an almost-5min improvement, i.e. about 25% faster,
while removing all instrumentation steps does not gain that much more...
So, we switch to using mtime, because in the end that's still good-enough
for our use-case: generating some graphs. It is not mission-critical, and
if a graph is slightly off, that's not a biggy. It can anyway be attributed
to a broken package's buildsystem, which should get fixed.
However, we lose the ability to track directories. Non-empty directories
can be tracked back by a bit of scripting, but empty directories are
simply not caught. If we were to also look for directories using mtime,
we would catch parents of installed files:
- /foo/bar/ exists
- a package installs /foo/bar/buz
- mtime of /foo/bar/ is changed to account for the new file in it.
So we do not track directories at all, and we lose empty directories.
The existing tracking was mostly happenstance, with the original
submission and comments not really accounting for a real use-case.
Now, we also change the way we handle symlinks. Previously, we would
hash the file pointed to by the symlink. Now, we only look at the mtime
of the symlink itself, which still detects modifications.
Eventually, this also means that we now no longer need to establish a
list before the install step; we can now simply run after the install
step, finding any files newer than the build stamp.
[0] Yeah, md5 is very weak, but we're not guarding against malicious
attacks, just about careless modifications.
[1] defconfig used for tests:
BR2_arm=y
BR2_cortex_a7=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_INIT_SYSTEMD=y
BR2_PACKAGE_MESA3D=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SWRAST=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VIRGL=y
BR2_PACKAGE_MESA3D_DRI_DRIVER_SWRAST=y
BR2_PACKAGE_MESA3D_OSMESA=y
BR2_PACKAGE_MESA3D_OPENGL_ES=y
BR2_PACKAGE_SYSTEMD_JOURNAL_GATEWAY=y
BR2_PACKAGE_SYSTEMD_BACKLIGHT=y
BR2_PACKAGE_SYSTEMD_BINFMT=y
BR2_PACKAGE_SYSTEMD_COREDUMP=y
BR2_PACKAGE_SYSTEMD_FIRSTBOOT=y
BR2_PACKAGE_SYSTEMD_HIBERNATE=y
BR2_PACKAGE_SYSTEMD_IMPORTD=y
BR2_PACKAGE_SYSTEMD_LOCALED=y
BR2_PACKAGE_SYSTEMD_LOGIND=y
BR2_PACKAGE_SYSTEMD_MACHINED=y
BR2_PACKAGE_SYSTEMD_POLKIT=y
BR2_PACKAGE_SYSTEMD_QUOTACHECK=y
BR2_PACKAGE_SYSTEMD_RANDOMSEED=y
BR2_PACKAGE_SYSTEMD_RFKILL=y
BR2_PACKAGE_SYSTEMD_SMACK_SUPPORT=y
BR2_PACKAGE_SYSTEMD_SYSUSERS=y
BR2_PACKAGE_SYSTEMD_VCONSOLE=y
[Peter: tweak commit message, use find -type l]
Reported-by: Trent Piepho <tpiepho@impinj.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Trent Piepho <tpiepho@impinj.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2018-03-15 21:35:08 +01:00
|
|
|
# $(1): package name
|
2017-10-28 17:30:58 +02:00
|
|
|
# $(2): base directory to search in
|
|
|
|
|
# $(3): suffix of file (optional)
|
core/instrumentation: shave minutes off the build time
As part of the build, we run some instrumentation hooks to gather
statistics about the usage of the target/, staging/ and host/
directories, so that we can generate reports for the user, that
shows:
- for each file, what package installed it,
- for each package,the size that it installed.
In so doing, we run a double md5 pass on all files of the affected
directories (before/after installation). These passes were mostly invisible
when we were only scanning target/, but has greatly increased in time now
that we also scan staging/ and host/ (but only in the corresponding _CMDS,
of course).
This md5 was mostly aimed at catching packages that would "cheat" with
mtime/atime/ctime somehow. They can't really cheat on md5, though [0].
Timings however speak for themselves, with this defconfig (slightly
biggish-but-still-manageable build) [1].
host/ 20965 files 1.2GiB
staging/ 4715 files 333MiB
target/ 1801 files 44MiB
All instrumentation steps, using md5: 19min 27s
All instrumentation steps, using mtime: 14min 45s
No instrumentation step at all: 14min 31s
So, using mtime is an almost-5min improvement, i.e. about 25% faster,
while removing all instrumentation steps does not gain that much more...
So, we switch to using mtime, because in the end that's still good-enough
for our use-case: generating some graphs. It is not mission-critical, and
if a graph is slightly off, that's not a biggy. It can anyway be attributed
to a broken package's buildsystem, which should get fixed.
However, we lose the ability to track directories. Non-empty directories
can be tracked back by a bit of scripting, but empty directories are
simply not caught. If we were to also look for directories using mtime,
we would catch parents of installed files:
- /foo/bar/ exists
- a package installs /foo/bar/buz
- mtime of /foo/bar/ is changed to account for the new file in it.
So we do not track directories at all, and we lose empty directories.
The existing tracking was mostly happenstance, with the original
submission and comments not really accounting for a real use-case.
Now, we also change the way we handle symlinks. Previously, we would
hash the file pointed to by the symlink. Now, we only look at the mtime
of the symlink itself, which still detects modifications.
Eventually, this also means that we now no longer need to establish a
list before the install step; we can now simply run after the install
step, finding any files newer than the build stamp.
[0] Yeah, md5 is very weak, but we're not guarding against malicious
attacks, just about careless modifications.
[1] defconfig used for tests:
BR2_arm=y
BR2_cortex_a7=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_INIT_SYSTEMD=y
BR2_PACKAGE_MESA3D=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SWRAST=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VIRGL=y
BR2_PACKAGE_MESA3D_DRI_DRIVER_SWRAST=y
BR2_PACKAGE_MESA3D_OSMESA=y
BR2_PACKAGE_MESA3D_OPENGL_ES=y
BR2_PACKAGE_SYSTEMD_JOURNAL_GATEWAY=y
BR2_PACKAGE_SYSTEMD_BACKLIGHT=y
BR2_PACKAGE_SYSTEMD_BINFMT=y
BR2_PACKAGE_SYSTEMD_COREDUMP=y
BR2_PACKAGE_SYSTEMD_FIRSTBOOT=y
BR2_PACKAGE_SYSTEMD_HIBERNATE=y
BR2_PACKAGE_SYSTEMD_IMPORTD=y
BR2_PACKAGE_SYSTEMD_LOCALED=y
BR2_PACKAGE_SYSTEMD_LOGIND=y
BR2_PACKAGE_SYSTEMD_MACHINED=y
BR2_PACKAGE_SYSTEMD_POLKIT=y
BR2_PACKAGE_SYSTEMD_QUOTACHECK=y
BR2_PACKAGE_SYSTEMD_RANDOMSEED=y
BR2_PACKAGE_SYSTEMD_RFKILL=y
BR2_PACKAGE_SYSTEMD_SMACK_SUPPORT=y
BR2_PACKAGE_SYSTEMD_SYSUSERS=y
BR2_PACKAGE_SYSTEMD_VCONSOLE=y
[Peter: tweak commit message, use find -type l]
Reported-by: Trent Piepho <tpiepho@impinj.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Trent Piepho <tpiepho@impinj.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2018-03-15 21:35:08 +01:00
|
|
|
define step_pkg_size_inner
|
2018-05-01 14:28:41 +02:00
|
|
|
@touch $(BUILD_DIR)/packages-file-list$(3).txt
|
|
|
|
|
$(SED) '/^$(1),/d' $(BUILD_DIR)/packages-file-list$(3).txt
|
core/instrumentation: shave minutes off the build time
As part of the build, we run some instrumentation hooks to gather
statistics about the usage of the target/, staging/ and host/
directories, so that we can generate reports for the user, that
shows:
- for each file, what package installed it,
- for each package,the size that it installed.
In so doing, we run a double md5 pass on all files of the affected
directories (before/after installation). These passes were mostly invisible
when we were only scanning target/, but has greatly increased in time now
that we also scan staging/ and host/ (but only in the corresponding _CMDS,
of course).
This md5 was mostly aimed at catching packages that would "cheat" with
mtime/atime/ctime somehow. They can't really cheat on md5, though [0].
Timings however speak for themselves, with this defconfig (slightly
biggish-but-still-manageable build) [1].
host/ 20965 files 1.2GiB
staging/ 4715 files 333MiB
target/ 1801 files 44MiB
All instrumentation steps, using md5: 19min 27s
All instrumentation steps, using mtime: 14min 45s
No instrumentation step at all: 14min 31s
So, using mtime is an almost-5min improvement, i.e. about 25% faster,
while removing all instrumentation steps does not gain that much more...
So, we switch to using mtime, because in the end that's still good-enough
for our use-case: generating some graphs. It is not mission-critical, and
if a graph is slightly off, that's not a biggy. It can anyway be attributed
to a broken package's buildsystem, which should get fixed.
However, we lose the ability to track directories. Non-empty directories
can be tracked back by a bit of scripting, but empty directories are
simply not caught. If we were to also look for directories using mtime,
we would catch parents of installed files:
- /foo/bar/ exists
- a package installs /foo/bar/buz
- mtime of /foo/bar/ is changed to account for the new file in it.
So we do not track directories at all, and we lose empty directories.
The existing tracking was mostly happenstance, with the original
submission and comments not really accounting for a real use-case.
Now, we also change the way we handle symlinks. Previously, we would
hash the file pointed to by the symlink. Now, we only look at the mtime
of the symlink itself, which still detects modifications.
Eventually, this also means that we now no longer need to establish a
list before the install step; we can now simply run after the install
step, finding any files newer than the build stamp.
[0] Yeah, md5 is very weak, but we're not guarding against malicious
attacks, just about careless modifications.
[1] defconfig used for tests:
BR2_arm=y
BR2_cortex_a7=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_INIT_SYSTEMD=y
BR2_PACKAGE_MESA3D=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SWRAST=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VIRGL=y
BR2_PACKAGE_MESA3D_DRI_DRIVER_SWRAST=y
BR2_PACKAGE_MESA3D_OSMESA=y
BR2_PACKAGE_MESA3D_OPENGL_ES=y
BR2_PACKAGE_SYSTEMD_JOURNAL_GATEWAY=y
BR2_PACKAGE_SYSTEMD_BACKLIGHT=y
BR2_PACKAGE_SYSTEMD_BINFMT=y
BR2_PACKAGE_SYSTEMD_COREDUMP=y
BR2_PACKAGE_SYSTEMD_FIRSTBOOT=y
BR2_PACKAGE_SYSTEMD_HIBERNATE=y
BR2_PACKAGE_SYSTEMD_IMPORTD=y
BR2_PACKAGE_SYSTEMD_LOCALED=y
BR2_PACKAGE_SYSTEMD_LOGIND=y
BR2_PACKAGE_SYSTEMD_MACHINED=y
BR2_PACKAGE_SYSTEMD_POLKIT=y
BR2_PACKAGE_SYSTEMD_QUOTACHECK=y
BR2_PACKAGE_SYSTEMD_RANDOMSEED=y
BR2_PACKAGE_SYSTEMD_RFKILL=y
BR2_PACKAGE_SYSTEMD_SMACK_SUPPORT=y
BR2_PACKAGE_SYSTEMD_SYSUSERS=y
BR2_PACKAGE_SYSTEMD_VCONSOLE=y
[Peter: tweak commit message, use find -type l]
Reported-by: Trent Piepho <tpiepho@impinj.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Trent Piepho <tpiepho@impinj.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2018-03-15 21:35:08 +01:00
|
|
|
cd $(2); \
|
|
|
|
|
find . \( -type f -o -type l \) \
|
|
|
|
|
-newer $($(PKG)_DIR)/.stamp_built \
|
|
|
|
|
-exec printf '$(1),%s\n' {} + \
|
|
|
|
|
>> $(BUILD_DIR)/packages-file-list$(3).txt
|
2015-10-17 15:33:42 +02:00
|
|
|
endef
|
|
|
|
|
|
|
|
|
|
define step_pkg_size
|
|
|
|
|
$(if $(filter install-target,$(2)),\
|
core/instrumentation: shave minutes off the build time
As part of the build, we run some instrumentation hooks to gather
statistics about the usage of the target/, staging/ and host/
directories, so that we can generate reports for the user, that
shows:
- for each file, what package installed it,
- for each package,the size that it installed.
In so doing, we run a double md5 pass on all files of the affected
directories (before/after installation). These passes were mostly invisible
when we were only scanning target/, but has greatly increased in time now
that we also scan staging/ and host/ (but only in the corresponding _CMDS,
of course).
This md5 was mostly aimed at catching packages that would "cheat" with
mtime/atime/ctime somehow. They can't really cheat on md5, though [0].
Timings however speak for themselves, with this defconfig (slightly
biggish-but-still-manageable build) [1].
host/ 20965 files 1.2GiB
staging/ 4715 files 333MiB
target/ 1801 files 44MiB
All instrumentation steps, using md5: 19min 27s
All instrumentation steps, using mtime: 14min 45s
No instrumentation step at all: 14min 31s
So, using mtime is an almost-5min improvement, i.e. about 25% faster,
while removing all instrumentation steps does not gain that much more...
So, we switch to using mtime, because in the end that's still good-enough
for our use-case: generating some graphs. It is not mission-critical, and
if a graph is slightly off, that's not a biggy. It can anyway be attributed
to a broken package's buildsystem, which should get fixed.
However, we lose the ability to track directories. Non-empty directories
can be tracked back by a bit of scripting, but empty directories are
simply not caught. If we were to also look for directories using mtime,
we would catch parents of installed files:
- /foo/bar/ exists
- a package installs /foo/bar/buz
- mtime of /foo/bar/ is changed to account for the new file in it.
So we do not track directories at all, and we lose empty directories.
The existing tracking was mostly happenstance, with the original
submission and comments not really accounting for a real use-case.
Now, we also change the way we handle symlinks. Previously, we would
hash the file pointed to by the symlink. Now, we only look at the mtime
of the symlink itself, which still detects modifications.
Eventually, this also means that we now no longer need to establish a
list before the install step; we can now simply run after the install
step, finding any files newer than the build stamp.
[0] Yeah, md5 is very weak, but we're not guarding against malicious
attacks, just about careless modifications.
[1] defconfig used for tests:
BR2_arm=y
BR2_cortex_a7=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_INIT_SYSTEMD=y
BR2_PACKAGE_MESA3D=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SWRAST=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VIRGL=y
BR2_PACKAGE_MESA3D_DRI_DRIVER_SWRAST=y
BR2_PACKAGE_MESA3D_OSMESA=y
BR2_PACKAGE_MESA3D_OPENGL_ES=y
BR2_PACKAGE_SYSTEMD_JOURNAL_GATEWAY=y
BR2_PACKAGE_SYSTEMD_BACKLIGHT=y
BR2_PACKAGE_SYSTEMD_BINFMT=y
BR2_PACKAGE_SYSTEMD_COREDUMP=y
BR2_PACKAGE_SYSTEMD_FIRSTBOOT=y
BR2_PACKAGE_SYSTEMD_HIBERNATE=y
BR2_PACKAGE_SYSTEMD_IMPORTD=y
BR2_PACKAGE_SYSTEMD_LOCALED=y
BR2_PACKAGE_SYSTEMD_LOGIND=y
BR2_PACKAGE_SYSTEMD_MACHINED=y
BR2_PACKAGE_SYSTEMD_POLKIT=y
BR2_PACKAGE_SYSTEMD_QUOTACHECK=y
BR2_PACKAGE_SYSTEMD_RANDOMSEED=y
BR2_PACKAGE_SYSTEMD_RFKILL=y
BR2_PACKAGE_SYSTEMD_SMACK_SUPPORT=y
BR2_PACKAGE_SYSTEMD_SYSUSERS=y
BR2_PACKAGE_SYSTEMD_VCONSOLE=y
[Peter: tweak commit message, use find -type l]
Reported-by: Trent Piepho <tpiepho@impinj.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Trent Piepho <tpiepho@impinj.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2018-03-15 21:35:08 +01:00
|
|
|
$(if $(filter end,$(1)),$(call step_pkg_size_inner,$(3),$(TARGET_DIR))))
|
2017-10-28 17:30:58 +02:00
|
|
|
$(if $(filter install-staging,$(2)),\
|
core/instrumentation: shave minutes off the build time
As part of the build, we run some instrumentation hooks to gather
statistics about the usage of the target/, staging/ and host/
directories, so that we can generate reports for the user, that
shows:
- for each file, what package installed it,
- for each package,the size that it installed.
In so doing, we run a double md5 pass on all files of the affected
directories (before/after installation). These passes were mostly invisible
when we were only scanning target/, but has greatly increased in time now
that we also scan staging/ and host/ (but only in the corresponding _CMDS,
of course).
This md5 was mostly aimed at catching packages that would "cheat" with
mtime/atime/ctime somehow. They can't really cheat on md5, though [0].
Timings however speak for themselves, with this defconfig (slightly
biggish-but-still-manageable build) [1].
host/ 20965 files 1.2GiB
staging/ 4715 files 333MiB
target/ 1801 files 44MiB
All instrumentation steps, using md5: 19min 27s
All instrumentation steps, using mtime: 14min 45s
No instrumentation step at all: 14min 31s
So, using mtime is an almost-5min improvement, i.e. about 25% faster,
while removing all instrumentation steps does not gain that much more...
So, we switch to using mtime, because in the end that's still good-enough
for our use-case: generating some graphs. It is not mission-critical, and
if a graph is slightly off, that's not a biggy. It can anyway be attributed
to a broken package's buildsystem, which should get fixed.
However, we lose the ability to track directories. Non-empty directories
can be tracked back by a bit of scripting, but empty directories are
simply not caught. If we were to also look for directories using mtime,
we would catch parents of installed files:
- /foo/bar/ exists
- a package installs /foo/bar/buz
- mtime of /foo/bar/ is changed to account for the new file in it.
So we do not track directories at all, and we lose empty directories.
The existing tracking was mostly happenstance, with the original
submission and comments not really accounting for a real use-case.
Now, we also change the way we handle symlinks. Previously, we would
hash the file pointed to by the symlink. Now, we only look at the mtime
of the symlink itself, which still detects modifications.
Eventually, this also means that we now no longer need to establish a
list before the install step; we can now simply run after the install
step, finding any files newer than the build stamp.
[0] Yeah, md5 is very weak, but we're not guarding against malicious
attacks, just about careless modifications.
[1] defconfig used for tests:
BR2_arm=y
BR2_cortex_a7=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_INIT_SYSTEMD=y
BR2_PACKAGE_MESA3D=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SWRAST=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VIRGL=y
BR2_PACKAGE_MESA3D_DRI_DRIVER_SWRAST=y
BR2_PACKAGE_MESA3D_OSMESA=y
BR2_PACKAGE_MESA3D_OPENGL_ES=y
BR2_PACKAGE_SYSTEMD_JOURNAL_GATEWAY=y
BR2_PACKAGE_SYSTEMD_BACKLIGHT=y
BR2_PACKAGE_SYSTEMD_BINFMT=y
BR2_PACKAGE_SYSTEMD_COREDUMP=y
BR2_PACKAGE_SYSTEMD_FIRSTBOOT=y
BR2_PACKAGE_SYSTEMD_HIBERNATE=y
BR2_PACKAGE_SYSTEMD_IMPORTD=y
BR2_PACKAGE_SYSTEMD_LOCALED=y
BR2_PACKAGE_SYSTEMD_LOGIND=y
BR2_PACKAGE_SYSTEMD_MACHINED=y
BR2_PACKAGE_SYSTEMD_POLKIT=y
BR2_PACKAGE_SYSTEMD_QUOTACHECK=y
BR2_PACKAGE_SYSTEMD_RANDOMSEED=y
BR2_PACKAGE_SYSTEMD_RFKILL=y
BR2_PACKAGE_SYSTEMD_SMACK_SUPPORT=y
BR2_PACKAGE_SYSTEMD_SYSUSERS=y
BR2_PACKAGE_SYSTEMD_VCONSOLE=y
[Peter: tweak commit message, use find -type l]
Reported-by: Trent Piepho <tpiepho@impinj.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Trent Piepho <tpiepho@impinj.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2018-03-15 21:35:08 +01:00
|
|
|
$(if $(filter end,$(1)),$(call step_pkg_size_inner,$(3),$(STAGING_DIR),-staging)))
|
2017-10-28 17:30:58 +02:00
|
|
|
$(if $(filter install-host,$(2)),\
|
core/instrumentation: shave minutes off the build time
As part of the build, we run some instrumentation hooks to gather
statistics about the usage of the target/, staging/ and host/
directories, so that we can generate reports for the user, that
shows:
- for each file, what package installed it,
- for each package,the size that it installed.
In so doing, we run a double md5 pass on all files of the affected
directories (before/after installation). These passes were mostly invisible
when we were only scanning target/, but has greatly increased in time now
that we also scan staging/ and host/ (but only in the corresponding _CMDS,
of course).
This md5 was mostly aimed at catching packages that would "cheat" with
mtime/atime/ctime somehow. They can't really cheat on md5, though [0].
Timings however speak for themselves, with this defconfig (slightly
biggish-but-still-manageable build) [1].
host/ 20965 files 1.2GiB
staging/ 4715 files 333MiB
target/ 1801 files 44MiB
All instrumentation steps, using md5: 19min 27s
All instrumentation steps, using mtime: 14min 45s
No instrumentation step at all: 14min 31s
So, using mtime is an almost-5min improvement, i.e. about 25% faster,
while removing all instrumentation steps does not gain that much more...
So, we switch to using mtime, because in the end that's still good-enough
for our use-case: generating some graphs. It is not mission-critical, and
if a graph is slightly off, that's not a biggy. It can anyway be attributed
to a broken package's buildsystem, which should get fixed.
However, we lose the ability to track directories. Non-empty directories
can be tracked back by a bit of scripting, but empty directories are
simply not caught. If we were to also look for directories using mtime,
we would catch parents of installed files:
- /foo/bar/ exists
- a package installs /foo/bar/buz
- mtime of /foo/bar/ is changed to account for the new file in it.
So we do not track directories at all, and we lose empty directories.
The existing tracking was mostly happenstance, with the original
submission and comments not really accounting for a real use-case.
Now, we also change the way we handle symlinks. Previously, we would
hash the file pointed to by the symlink. Now, we only look at the mtime
of the symlink itself, which still detects modifications.
Eventually, this also means that we now no longer need to establish a
list before the install step; we can now simply run after the install
step, finding any files newer than the build stamp.
[0] Yeah, md5 is very weak, but we're not guarding against malicious
attacks, just about careless modifications.
[1] defconfig used for tests:
BR2_arm=y
BR2_cortex_a7=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_INIT_SYSTEMD=y
BR2_PACKAGE_MESA3D=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SWRAST=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4=y
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VIRGL=y
BR2_PACKAGE_MESA3D_DRI_DRIVER_SWRAST=y
BR2_PACKAGE_MESA3D_OSMESA=y
BR2_PACKAGE_MESA3D_OPENGL_ES=y
BR2_PACKAGE_SYSTEMD_JOURNAL_GATEWAY=y
BR2_PACKAGE_SYSTEMD_BACKLIGHT=y
BR2_PACKAGE_SYSTEMD_BINFMT=y
BR2_PACKAGE_SYSTEMD_COREDUMP=y
BR2_PACKAGE_SYSTEMD_FIRSTBOOT=y
BR2_PACKAGE_SYSTEMD_HIBERNATE=y
BR2_PACKAGE_SYSTEMD_IMPORTD=y
BR2_PACKAGE_SYSTEMD_LOCALED=y
BR2_PACKAGE_SYSTEMD_LOGIND=y
BR2_PACKAGE_SYSTEMD_MACHINED=y
BR2_PACKAGE_SYSTEMD_POLKIT=y
BR2_PACKAGE_SYSTEMD_QUOTACHECK=y
BR2_PACKAGE_SYSTEMD_RANDOMSEED=y
BR2_PACKAGE_SYSTEMD_RFKILL=y
BR2_PACKAGE_SYSTEMD_SMACK_SUPPORT=y
BR2_PACKAGE_SYSTEMD_SYSUSERS=y
BR2_PACKAGE_SYSTEMD_VCONSOLE=y
[Peter: tweak commit message, use find -type l]
Reported-by: Trent Piepho <tpiepho@impinj.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Trent Piepho <tpiepho@impinj.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2018-03-15 21:35:08 +01:00
|
|
|
$(if $(filter end,$(1)),$(call step_pkg_size_inner,$(3),$(HOST_DIR),-host)))
|
2015-10-17 15:33:42 +02:00
|
|
|
endef
|
|
|
|
|
GLOBAL_INSTRUMENTATION_HOOKS += step_pkg_size
|
|
|
|
|
|
Makefile: add check of binaries architecture
As shown recently by the firejail example, it is easy to miss that a
package builds and installs binaries without actually cross-compiling
them: they are built for the host architecture instead of the target
architecture.
This commit adds a small helper script, check-bin-arch, called as a
GLOBAL_INSTRUMENTATION_HOOKS at the end of the target installation of
each package, to verify that the files installed by this package have
been built for the correct architecture.
Being called as a GLOBAL_INSTRUMENTATION_HOOKS allows the build to error
out right after the installation of the faulty package, and therefore
get autobuilder error detection properly assigned to this specific
package.
Example output with the firejail package enabled, when building for an
ARM target:
ERROR: architecture for ./usr/lib/firejail/libconnect.so is Advanced Micro Devices X86-64, should be ARM
ERROR: architecture for ./usr/bin/firejail is Advanced Micro Devices X86-64, should be ARM
ERROR: architecture for ./usr/lib/firejail/libtrace.so is Advanced Micro Devices X86-64, should be ARM
ERROR: architecture for ./usr/lib/firejail/libtracelog.so is Advanced Micro Devices X86-64, should be ARM
ERROR: architecture for ./usr/lib/firejail/ftee is Advanced Micro Devices X86-64, should be ARM
ERROR: architecture for ./usr/lib/firejail/faudit is Advanced Micro Devices X86-64, should be ARM
ERROR: architecture for ./usr/bin/firemon is Advanced Micro Devices X86-64, should be ARM
ERROR: architecture for ./usr/bin/firecfg is Advanced Micro Devices X86-64, should be ARM
Many thanks to Yann E. Morin and Arnout Vandecappelle for their reviews
and suggestions.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2017-03-19 14:07:52 +01:00
|
|
|
# Relies on step_pkg_size, so must be after
|
|
|
|
|
define check_bin_arch
|
|
|
|
|
$(if $(filter end-install-target,$(1)-$(2)),\
|
|
|
|
|
support/scripts/check-bin-arch -p $(3) \
|
|
|
|
|
-l $(BUILD_DIR)/packages-file-list.txt \
|
2018-03-07 22:51:23 +01:00
|
|
|
$(foreach i,$($(PKG)_BIN_ARCH_EXCLUDE),-i "$(i)") \
|
Makefile: add check of binaries architecture
As shown recently by the firejail example, it is easy to miss that a
package builds and installs binaries without actually cross-compiling
them: they are built for the host architecture instead of the target
architecture.
This commit adds a small helper script, check-bin-arch, called as a
GLOBAL_INSTRUMENTATION_HOOKS at the end of the target installation of
each package, to verify that the files installed by this package have
been built for the correct architecture.
Being called as a GLOBAL_INSTRUMENTATION_HOOKS allows the build to error
out right after the installation of the faulty package, and therefore
get autobuilder error detection properly assigned to this specific
package.
Example output with the firejail package enabled, when building for an
ARM target:
ERROR: architecture for ./usr/lib/firejail/libconnect.so is Advanced Micro Devices X86-64, should be ARM
ERROR: architecture for ./usr/bin/firejail is Advanced Micro Devices X86-64, should be ARM
ERROR: architecture for ./usr/lib/firejail/libtrace.so is Advanced Micro Devices X86-64, should be ARM
ERROR: architecture for ./usr/lib/firejail/libtracelog.so is Advanced Micro Devices X86-64, should be ARM
ERROR: architecture for ./usr/lib/firejail/ftee is Advanced Micro Devices X86-64, should be ARM
ERROR: architecture for ./usr/lib/firejail/faudit is Advanced Micro Devices X86-64, should be ARM
ERROR: architecture for ./usr/bin/firemon is Advanced Micro Devices X86-64, should be ARM
ERROR: architecture for ./usr/bin/firecfg is Advanced Micro Devices X86-64, should be ARM
Many thanks to Yann E. Morin and Arnout Vandecappelle for their reviews
and suggestions.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2017-03-19 14:07:52 +01:00
|
|
|
-r $(TARGET_READELF) \
|
|
|
|
|
-a $(BR2_READELF_ARCH_NAME))
|
|
|
|
|
endef
|
|
|
|
|
|
|
|
|
|
GLOBAL_INSTRUMENTATION_HOOKS += check_bin_arch
|
|
|
|
|
|
core: check host executables have appropriate RPATH
When we build our host programs, and they depend on a host library we
also build, we want to ensure that program actually uses that library at
runtime, and not the one from the system.
We currently ensure that in two ways:
- we add a RPATH tag that points to our host library directory,
- we export LD_LIBRARY_PATH to point to that same directory.
With these two in place, we're pretty much confident that our host
libraries will be used by our host programs.
However, it turns our that not all the host programs we build end up
with an RPATH tag:
- some packages do not use our $(HOST_LDFLAGS)
- some packages' build system are oblivious to those LDFLAGS
In this case, there are two situations:
- the program is not linked to one of our host libraries: it in fact
does not need an RPATH tag [0]
- the program actually uses one of our host libraries: in that case it
should have had an RPATH tag pointing to the host directory.
For libraries, they only need an RPATH if they depend on another library
that is not installed in the standard library path. However, any system
library will already be in the standard library path, and any library we
install ourselves is in $(HOST_DIR)/usr/lib so already in RPATH.
We add a new support script that checks that all ELF executables have
a proper DT_RPATH (or DT_RUNPATH) tag when they link to our host
libraries, and reports those file that are missing an RPATH. If a file
missing an RPATH is an executable, the script aborts; if only libraries
are are missing an RPATH, the script does not abort.
[0] Except if it were to dlopen() it, of course, but the only program
I'm aware of that does that is openssl, and it has a correct RPATH tag.
[Peter: reworded as suggested by Arnout, fix HOT_DIR typo in comment]
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Arnout Vandecappelle <arnout@mind.be>
Cc: Peter Korsgaard <jacmet@uclibc.org>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2015-11-13 22:48:51 +01:00
|
|
|
# This hook checks that host packages that need libraries that we build
|
|
|
|
|
# have a proper DT_RPATH or DT_RUNPATH tag
|
|
|
|
|
define check_host_rpath
|
|
|
|
|
$(if $(filter install-host,$(2)),\
|
|
|
|
|
$(if $(filter end,$(1)),support/scripts/check-host-rpath $(3) $(HOST_DIR)))
|
|
|
|
|
endef
|
|
|
|
|
GLOBAL_INSTRUMENTATION_HOOKS += check_host_rpath
|
|
|
|
|
|
2016-10-24 18:38:52 +02:00
|
|
|
define step_check_build_dir_one
|
|
|
|
|
if [ -d $(2) ]; then \
|
|
|
|
|
printf "%s: installs files in %s\n" $(1) $(2) >&2; \
|
|
|
|
|
exit 1; \
|
|
|
|
|
fi
|
|
|
|
|
endef
|
|
|
|
|
|
|
|
|
|
define step_check_build_dir
|
|
|
|
|
$(if $(filter install-staging,$(2)),\
|
|
|
|
|
$(if $(filter end,$(1)),$(call step_check_build_dir_one,$(3),$(STAGING_DIR)/$(O))))
|
|
|
|
|
$(if $(filter install-target,$(2)),\
|
|
|
|
|
$(if $(filter end,$(1)),$(call step_check_build_dir_one,$(3),$(TARGET_DIR)/$(O))))
|
|
|
|
|
endef
|
|
|
|
|
GLOBAL_INSTRUMENTATION_HOOKS += step_check_build_dir
|
|
|
|
|
|
2013-11-11 16:03:29 +01:00
|
|
|
# User-supplied script
|
2014-09-15 03:31:11 +02:00
|
|
|
ifneq ($(BR2_INSTRUMENTATION_SCRIPTS),)
|
2013-11-11 16:03:29 +01:00
|
|
|
define step_user
|
|
|
|
|
@$(foreach user_hook, $(BR2_INSTRUMENTATION_SCRIPTS), \
|
2014-03-10 21:51:33 +01:00
|
|
|
$(EXTRA_ENV) $(user_hook) "$(1)" "$(2)" "$(3)"$(sep))
|
2013-11-11 16:03:29 +01:00
|
|
|
endef
|
|
|
|
|
GLOBAL_INSTRUMENTATION_HOOKS += step_user
|
|
|
|
|
endif
|
|
|
|
|
|
2009-11-08 18:37:36 +01:00
|
|
|
################################################################################
|
|
|
|
|
# Implicit targets -- produce a stamp file for each step of a package build
|
|
|
|
|
################################################################################
|
|
|
|
|
|
|
|
|
|
# Retrieve the archive
|
|
|
|
|
$(BUILD_DIR)/%/.stamp_downloaded:
|
2018-04-28 22:53:04 +02:00
|
|
|
@$(call step_start,download)
|
2014-05-05 15:04:20 +02:00
|
|
|
$(foreach hook,$($(PKG)_PRE_DOWNLOAD_HOOKS),$(call $(hook))$(sep))
|
2009-11-08 18:37:36 +01:00
|
|
|
# Only show the download message if it isn't already downloaded
|
2015-04-26 11:51:11 +02:00
|
|
|
$(Q)for p in $($(PKG)_ALL_DOWNLOADS); do \
|
2018-04-02 15:09:26 +02:00
|
|
|
if test ! -e $($(PKG)_DL_DIR)/`basename $$p` ; then \
|
2015-03-29 19:33:18 +02:00
|
|
|
$(call MESSAGE,"Downloading") ; \
|
|
|
|
|
break ; \
|
|
|
|
|
fi ; \
|
|
|
|
|
done
|
2015-04-26 11:51:11 +02:00
|
|
|
$(foreach p,$($(PKG)_ALL_DOWNLOADS),$(call DOWNLOAD,$(p))$(sep))
|
2011-07-05 21:54:11 +02:00
|
|
|
$(foreach hook,$($(PKG)_POST_DOWNLOAD_HOOKS),$(call $(hook))$(sep))
|
2009-11-08 18:37:36 +01:00
|
|
|
$(Q)mkdir -p $(@D)
|
2018-04-28 22:53:04 +02:00
|
|
|
@$(call step_end,download)
|
2009-11-08 18:37:36 +01:00
|
|
|
$(Q)touch $@
|
|
|
|
|
|
core/legal-info: ensure legal-info works in off-line mode
Almost all packages which are saved for legal-info have their source
archives downloaded as part of 'make source', which makes an off-line
build completely possible [0].
However, for the pre-configured external toolchains, the source tarball
is different, as the main tarball is a binary package. And that source
tarball is only downloaded during the legal-info phase, which makes it
inconvenient for full off-line builds.
We fix that by adding a new rule, $(1)-legal-source which only
$(1)-all-source depends on, so that we only download it for a top-level
'make source', not as part of the standard download mechanism (i.e. only
what is really needed to build).
This new rule depends, like the normal download mechanism, on a stamp
file, so that we do not emit a spurious hash-check message on successive
runs of 'make source'.
This way, we can do a complete [0] off-line build and are still able to
generate legal-info, while at the same time we do not incur any download
overhead during a simple build.
Also, we previously downloaded the _ACTUAL_SOURCE_TARBALL when it was
not empty. However, since _ACTUAL_SOURCE_TARBALL defaults to the value
of _SOURCE, it can not be empty when _SOURCE is not. Thus, we'd get a
spurious report of a missing hash for the tarball, since it was not in
a standard package rule (configure, build, install..) and thus would
miss the PKG and PKGDIR variables to find the .hash file.
We fix that in this commit as well, by:
- setting PKG and PKGDIR just for the -legal-source rule;
- only downloading _ACTUAL_SOURCE_TARBALL if it is not empty *and* not
the same as _SOURCE (to avoid a second report about the hash).
[0] Save for nodejs which invarriably wants to download stuff at build
time. Sigh... :-( Fixing that is work for another time...
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Peter Korsgaard <jacmet@uclibc.org>
Tested-by: Luca Ceresoli <luca@lucaceresoli.net>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2016-05-07 18:14:38 +02:00
|
|
|
# Retrieve actual source archive, e.g. for prebuilt external toolchains
|
|
|
|
|
$(BUILD_DIR)/%/.stamp_actual_downloaded:
|
2018-04-28 22:53:04 +02:00
|
|
|
@$(call step_start,actual-download)
|
2018-04-03 08:56:16 +02:00
|
|
|
$(call DOWNLOAD,$($(PKG)_ACTUAL_SOURCE_SITE)/$($(PKG)_ACTUAL_SOURCE_TARBALL))
|
core/legal-info: ensure legal-info works in off-line mode
Almost all packages which are saved for legal-info have their source
archives downloaded as part of 'make source', which makes an off-line
build completely possible [0].
However, for the pre-configured external toolchains, the source tarball
is different, as the main tarball is a binary package. And that source
tarball is only downloaded during the legal-info phase, which makes it
inconvenient for full off-line builds.
We fix that by adding a new rule, $(1)-legal-source which only
$(1)-all-source depends on, so that we only download it for a top-level
'make source', not as part of the standard download mechanism (i.e. only
what is really needed to build).
This new rule depends, like the normal download mechanism, on a stamp
file, so that we do not emit a spurious hash-check message on successive
runs of 'make source'.
This way, we can do a complete [0] off-line build and are still able to
generate legal-info, while at the same time we do not incur any download
overhead during a simple build.
Also, we previously downloaded the _ACTUAL_SOURCE_TARBALL when it was
not empty. However, since _ACTUAL_SOURCE_TARBALL defaults to the value
of _SOURCE, it can not be empty when _SOURCE is not. Thus, we'd get a
spurious report of a missing hash for the tarball, since it was not in
a standard package rule (configure, build, install..) and thus would
miss the PKG and PKGDIR variables to find the .hash file.
We fix that in this commit as well, by:
- setting PKG and PKGDIR just for the -legal-source rule;
- only downloading _ACTUAL_SOURCE_TARBALL if it is not empty *and* not
the same as _SOURCE (to avoid a second report about the hash).
[0] Save for nodejs which invarriably wants to download stuff at build
time. Sigh... :-( Fixing that is work for another time...
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Peter Korsgaard <jacmet@uclibc.org>
Tested-by: Luca Ceresoli <luca@lucaceresoli.net>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2016-05-07 18:14:38 +02:00
|
|
|
$(Q)mkdir -p $(@D)
|
2018-04-28 22:53:04 +02:00
|
|
|
@$(call step_end,actual-download)
|
core/legal-info: ensure legal-info works in off-line mode
Almost all packages which are saved for legal-info have their source
archives downloaded as part of 'make source', which makes an off-line
build completely possible [0].
However, for the pre-configured external toolchains, the source tarball
is different, as the main tarball is a binary package. And that source
tarball is only downloaded during the legal-info phase, which makes it
inconvenient for full off-line builds.
We fix that by adding a new rule, $(1)-legal-source which only
$(1)-all-source depends on, so that we only download it for a top-level
'make source', not as part of the standard download mechanism (i.e. only
what is really needed to build).
This new rule depends, like the normal download mechanism, on a stamp
file, so that we do not emit a spurious hash-check message on successive
runs of 'make source'.
This way, we can do a complete [0] off-line build and are still able to
generate legal-info, while at the same time we do not incur any download
overhead during a simple build.
Also, we previously downloaded the _ACTUAL_SOURCE_TARBALL when it was
not empty. However, since _ACTUAL_SOURCE_TARBALL defaults to the value
of _SOURCE, it can not be empty when _SOURCE is not. Thus, we'd get a
spurious report of a missing hash for the tarball, since it was not in
a standard package rule (configure, build, install..) and thus would
miss the PKG and PKGDIR variables to find the .hash file.
We fix that in this commit as well, by:
- setting PKG and PKGDIR just for the -legal-source rule;
- only downloading _ACTUAL_SOURCE_TARBALL if it is not empty *and* not
the same as _SOURCE (to avoid a second report about the hash).
[0] Save for nodejs which invarriably wants to download stuff at build
time. Sigh... :-( Fixing that is work for another time...
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Peter Korsgaard <jacmet@uclibc.org>
Tested-by: Luca Ceresoli <luca@lucaceresoli.net>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2016-05-07 18:14:38 +02:00
|
|
|
$(Q)touch $@
|
|
|
|
|
|
2009-11-08 18:37:36 +01:00
|
|
|
# Unpack the archive
|
|
|
|
|
$(BUILD_DIR)/%/.stamp_extracted:
|
2013-11-11 16:03:27 +01:00
|
|
|
@$(call step_start,extract)
|
2009-11-08 18:37:36 +01:00
|
|
|
@$(call MESSAGE,"Extracting")
|
2014-05-05 15:04:20 +02:00
|
|
|
$(foreach hook,$($(PKG)_PRE_EXTRACT_HOOKS),$(call $(hook))$(sep))
|
2009-11-08 18:37:36 +01:00
|
|
|
$(Q)mkdir -p $(@D)
|
2011-07-05 21:53:52 +02:00
|
|
|
$($(PKG)_EXTRACT_CMDS)
|
2009-11-08 18:37:36 +01:00
|
|
|
# some packages have messed up permissions inside
|
2011-07-07 10:53:18 +02:00
|
|
|
$(Q)chmod -R +rw $(@D)
|
2009-11-08 18:37:36 +01:00
|
|
|
$(foreach hook,$($(PKG)_POST_EXTRACT_HOOKS),$(call $(hook))$(sep))
|
2013-11-11 16:03:27 +01:00
|
|
|
@$(call step_end,extract)
|
2015-11-03 20:06:03 +01:00
|
|
|
$(Q)touch $@
|
2009-11-08 18:37:36 +01:00
|
|
|
|
2011-09-29 21:57:37 +02:00
|
|
|
# Rsync the source directory if the <pkg>_OVERRIDE_SRCDIR feature is
|
|
|
|
|
# used.
|
|
|
|
|
$(BUILD_DIR)/%/.stamp_rsynced:
|
2018-04-28 22:53:04 +02:00
|
|
|
@$(call step_start,rsync)
|
2011-09-29 21:57:37 +02:00
|
|
|
@$(call MESSAGE,"Syncing from source dir $(SRCDIR)")
|
2014-05-05 15:04:20 +02:00
|
|
|
$(foreach hook,$($(PKG)_PRE_RSYNC_HOOKS),$(call $(hook))$(sep))
|
2016-12-11 19:12:45 +01:00
|
|
|
@test -d $(SRCDIR) || (echo "ERROR: $(SRCDIR) does not exist" ; exit 1)
|
2017-11-08 14:26:41 +01:00
|
|
|
rsync -au --chmod=u=rwX,go=rX $(RSYNC_VCS_EXCLUSIONS) $($(PKG)_OVERRIDE_SRCDIR_RSYNC_EXCLUSIONS) $(call qstrip,$(SRCDIR))/ $(@D)
|
2013-11-07 11:41:21 +01:00
|
|
|
$(foreach hook,$($(PKG)_POST_RSYNC_HOOKS),$(call $(hook))$(sep))
|
2018-04-28 22:53:04 +02:00
|
|
|
@$(call step_end,rsync)
|
2011-09-29 21:57:37 +02:00
|
|
|
$(Q)touch $@
|
|
|
|
|
|
2009-11-08 18:37:36 +01:00
|
|
|
# Patch
|
|
|
|
|
#
|
2011-07-05 21:53:57 +02:00
|
|
|
# The RAWNAME variable is the lowercased package name, which allows to
|
|
|
|
|
# find the package directory (typically package/<pkgname>) and the
|
|
|
|
|
# prefix of the patches
|
2013-12-18 11:25:01 +01:00
|
|
|
#
|
|
|
|
|
# For BR2_GLOBAL_PATCH_DIR, only generate if it is defined
|
2014-02-05 10:44:01 +01:00
|
|
|
$(BUILD_DIR)/%/.stamp_patched: PATCH_BASE_DIRS = $(PKGDIR)
|
2013-12-18 11:25:01 +01:00
|
|
|
$(BUILD_DIR)/%/.stamp_patched: PATCH_BASE_DIRS += $(addsuffix /$(RAWNAME),$(call qstrip,$(BR2_GLOBAL_PATCH_DIR)))
|
2009-11-08 18:37:36 +01:00
|
|
|
$(BUILD_DIR)/%/.stamp_patched:
|
2013-11-11 16:03:27 +01:00
|
|
|
@$(call step_start,patch)
|
2013-11-07 17:26:53 +01:00
|
|
|
@$(call MESSAGE,"Patching")
|
2011-09-19 22:10:52 +02:00
|
|
|
$(foreach hook,$($(PKG)_PRE_PATCH_HOOKS),$(call $(hook))$(sep))
|
2018-04-02 15:09:26 +02:00
|
|
|
$(foreach p,$($(PKG)_PATCH),$(APPLY_PATCHES) $(@D) $($(PKG)_DL_DIR) $(notdir $(p))$(sep))
|
2009-11-08 18:37:36 +01:00
|
|
|
$(Q)( \
|
rework patch model
At the Buildroot Developers Meeting (4-5 February 2013, in Brussels) a change
to the patch logic was discussed. See
http://elinux.org/Buildroot:DeveloperDaysFOSDEM2013
for details. In summary:
* For patches stored in the package directory, if
package/<pkg>/<version>/ does exist, apply package/<pkg>/<version>/*.patch,
otherwise, apply package/<pkg>/*.patch
* For patches stored in the global patches directory, if
$(GLOBAL_PATCH_DIR)/<pkg>/<version>/ does exist, apply
$(GLOBAL_PATCH_DIR)/<pkg>/<version>/*.patch, otherwise, apply
$(GLOBAL_PATCH_DIR)/<pkg>/*.patch
This patch adds the new BR2_GLOBAL_PATCH_DIR configuration item, and reworks
the generic package infrastructure to implement the new patch logic.
[Peter: fixup doc nits as pointed out by Thomas]
Signed-off-by: Simon Dawson <spdawson@gmail.com>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Tested-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
2013-03-18 00:13:47 +01:00
|
|
|
for D in $(PATCH_BASE_DIRS); do \
|
|
|
|
|
if test -d $${D}; then \
|
|
|
|
|
if test -d $${D}/$($(PKG)_VERSION); then \
|
2014-10-22 18:20:10 +02:00
|
|
|
$(APPLY_PATCHES) $(@D) $${D}/$($(PKG)_VERSION) \*.patch \*.patch.$(ARCH) || exit 1; \
|
rework patch model
At the Buildroot Developers Meeting (4-5 February 2013, in Brussels) a change
to the patch logic was discussed. See
http://elinux.org/Buildroot:DeveloperDaysFOSDEM2013
for details. In summary:
* For patches stored in the package directory, if
package/<pkg>/<version>/ does exist, apply package/<pkg>/<version>/*.patch,
otherwise, apply package/<pkg>/*.patch
* For patches stored in the global patches directory, if
$(GLOBAL_PATCH_DIR)/<pkg>/<version>/ does exist, apply
$(GLOBAL_PATCH_DIR)/<pkg>/<version>/*.patch, otherwise, apply
$(GLOBAL_PATCH_DIR)/<pkg>/*.patch
This patch adds the new BR2_GLOBAL_PATCH_DIR configuration item, and reworks
the generic package infrastructure to implement the new patch logic.
[Peter: fixup doc nits as pointed out by Thomas]
Signed-off-by: Simon Dawson <spdawson@gmail.com>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Tested-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
2013-03-18 00:13:47 +01:00
|
|
|
else \
|
2014-10-22 18:20:10 +02:00
|
|
|
$(APPLY_PATCHES) $(@D) $${D} \*.patch \*.patch.$(ARCH) || exit 1; \
|
2009-11-08 18:37:36 +01:00
|
|
|
fi; \
|
|
|
|
|
fi; \
|
rework patch model
At the Buildroot Developers Meeting (4-5 February 2013, in Brussels) a change
to the patch logic was discussed. See
http://elinux.org/Buildroot:DeveloperDaysFOSDEM2013
for details. In summary:
* For patches stored in the package directory, if
package/<pkg>/<version>/ does exist, apply package/<pkg>/<version>/*.patch,
otherwise, apply package/<pkg>/*.patch
* For patches stored in the global patches directory, if
$(GLOBAL_PATCH_DIR)/<pkg>/<version>/ does exist, apply
$(GLOBAL_PATCH_DIR)/<pkg>/<version>/*.patch, otherwise, apply
$(GLOBAL_PATCH_DIR)/<pkg>/*.patch
This patch adds the new BR2_GLOBAL_PATCH_DIR configuration item, and reworks
the generic package infrastructure to implement the new patch logic.
[Peter: fixup doc nits as pointed out by Thomas]
Signed-off-by: Simon Dawson <spdawson@gmail.com>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Tested-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
2013-03-18 00:13:47 +01:00
|
|
|
done; \
|
2009-11-08 18:37:36 +01:00
|
|
|
)
|
|
|
|
|
$(foreach hook,$($(PKG)_POST_PATCH_HOOKS),$(call $(hook))$(sep))
|
2013-11-11 16:03:27 +01:00
|
|
|
@$(call step_end,patch)
|
2015-11-03 20:06:03 +01:00
|
|
|
$(Q)touch $@
|
2009-11-08 18:37:36 +01:00
|
|
|
|
2014-10-21 10:42:54 +02:00
|
|
|
# Check that all directories specified in BR2_GLOBAL_PATCH_DIR exist.
|
|
|
|
|
$(foreach dir,$(call qstrip,$(BR2_GLOBAL_PATCH_DIR)),\
|
|
|
|
|
$(if $(wildcard $(dir)),,\
|
|
|
|
|
$(error BR2_GLOBAL_PATCH_DIR contains nonexistent directory $(dir))))
|
|
|
|
|
|
2009-11-08 18:37:36 +01:00
|
|
|
# Configure
|
|
|
|
|
$(BUILD_DIR)/%/.stamp_configured:
|
2013-11-11 16:03:27 +01:00
|
|
|
@$(call step_start,configure)
|
2009-11-08 18:37:36 +01:00
|
|
|
@$(call MESSAGE,"Configuring")
|
2014-05-05 15:04:20 +02:00
|
|
|
$(foreach hook,$($(PKG)_PRE_CONFIGURE_HOOKS),$(call $(hook))$(sep))
|
2009-11-08 18:37:36 +01:00
|
|
|
$($(PKG)_CONFIGURE_CMDS)
|
|
|
|
|
$(foreach hook,$($(PKG)_POST_CONFIGURE_HOOKS),$(call $(hook))$(sep))
|
2013-11-11 16:03:27 +01:00
|
|
|
@$(call step_end,configure)
|
2015-11-03 20:06:03 +01:00
|
|
|
$(Q)touch $@
|
2009-11-08 18:37:36 +01:00
|
|
|
|
|
|
|
|
# Build
|
|
|
|
|
$(BUILD_DIR)/%/.stamp_built::
|
2013-11-11 16:03:27 +01:00
|
|
|
@$(call step_start,build)
|
2009-11-08 18:37:36 +01:00
|
|
|
@$(call MESSAGE,"Building")
|
2014-05-05 15:04:20 +02:00
|
|
|
$(foreach hook,$($(PKG)_PRE_BUILD_HOOKS),$(call $(hook))$(sep))
|
2014-02-14 10:55:07 +01:00
|
|
|
+$($(PKG)_BUILD_CMDS)
|
2009-11-08 18:37:36 +01:00
|
|
|
$(foreach hook,$($(PKG)_POST_BUILD_HOOKS),$(call $(hook))$(sep))
|
2013-11-11 16:03:27 +01:00
|
|
|
@$(call step_end,build)
|
2015-11-03 20:06:03 +01:00
|
|
|
$(Q)touch $@
|
2009-11-08 18:37:36 +01:00
|
|
|
|
|
|
|
|
# Install to host dir
|
|
|
|
|
$(BUILD_DIR)/%/.stamp_host_installed:
|
2013-11-11 16:03:27 +01:00
|
|
|
@$(call step_start,install-host)
|
2011-07-18 12:49:25 +02:00
|
|
|
@$(call MESSAGE,"Installing to host directory")
|
2014-05-05 15:04:20 +02:00
|
|
|
$(foreach hook,$($(PKG)_PRE_INSTALL_HOOKS),$(call $(hook))$(sep))
|
2014-02-14 10:55:07 +01:00
|
|
|
+$($(PKG)_INSTALL_CMDS)
|
2009-11-08 18:37:36 +01:00
|
|
|
$(foreach hook,$($(PKG)_POST_INSTALL_HOOKS),$(call $(hook))$(sep))
|
2013-11-11 16:03:27 +01:00
|
|
|
@$(call step_end,install-host)
|
2015-11-03 20:06:03 +01:00
|
|
|
$(Q)touch $@
|
2009-11-08 18:37:36 +01:00
|
|
|
|
|
|
|
|
# Install to staging dir
|
2015-05-03 23:30:39 +02:00
|
|
|
#
|
|
|
|
|
# Some packages install libtool .la files alongside any installed
|
|
|
|
|
# libraries. These .la files sometimes refer to paths relative to the
|
|
|
|
|
# sysroot, which libtool will interpret as absolute paths to host
|
|
|
|
|
# libraries instead of the target libraries. Since this is not what we
|
|
|
|
|
# want, these paths are fixed by prefixing them with $(STAGING_DIR).
|
|
|
|
|
# As we configure with --prefix=/usr, this fix needs to be applied to
|
|
|
|
|
# any path that starts with /usr.
|
|
|
|
|
#
|
|
|
|
|
# To protect against the case that the output or staging directories or
|
|
|
|
|
# the pre-installed external toolchain themselves are under /usr, we first
|
|
|
|
|
# substitute away any occurrences of these directories with @BASE_DIR@,
|
|
|
|
|
# @STAGING_DIR@ and @TOOLCHAIN_EXTERNAL_INSTALL_DIR@ respectively.
|
|
|
|
|
#
|
|
|
|
|
# Note that STAGING_DIR can be outside BASE_DIR when the user sets
|
|
|
|
|
# BR2_HOST_DIR to a custom value. Note that TOOLCHAIN_EXTERNAL_INSTALL_DIR
|
|
|
|
|
# can be under @BASE_DIR@ when it's a downloaded toolchain, and can be
|
|
|
|
|
# empty when we use an internal toolchain.
|
|
|
|
|
#
|
2009-11-08 18:37:36 +01:00
|
|
|
$(BUILD_DIR)/%/.stamp_staging_installed:
|
2013-11-11 16:03:27 +01:00
|
|
|
@$(call step_start,install-staging)
|
2011-07-18 12:49:25 +02:00
|
|
|
@$(call MESSAGE,"Installing to staging directory")
|
2014-05-05 15:04:20 +02:00
|
|
|
$(foreach hook,$($(PKG)_PRE_INSTALL_STAGING_HOOKS),$(call $(hook))$(sep))
|
2014-02-14 10:55:07 +01:00
|
|
|
+$($(PKG)_INSTALL_STAGING_CMDS)
|
2009-11-08 18:37:36 +01:00
|
|
|
$(foreach hook,$($(PKG)_POST_INSTALL_STAGING_HOOKS),$(call $(hook))$(sep))
|
2013-02-07 13:35:03 +01:00
|
|
|
$(Q)if test -n "$($(PKG)_CONFIG_SCRIPTS)" ; then \
|
2013-01-30 03:46:40 +01:00
|
|
|
$(call MESSAGE,"Fixing package configuration files") ;\
|
2014-06-21 17:01:47 +02:00
|
|
|
$(SED) "s,$(BASE_DIR),@BASE_DIR@,g" \
|
2014-07-03 21:58:43 +02:00
|
|
|
-e "s,$(STAGING_DIR),@STAGING_DIR@,g" \
|
2014-06-21 17:01:47 +02:00
|
|
|
-e "s,^\(exec_\)\?prefix=.*,\1prefix=@STAGING_DIR@/usr,g" \
|
|
|
|
|
-e "s,-I/usr/,-I@STAGING_DIR@/usr/,g" \
|
|
|
|
|
-e "s,-L/usr/,-L@STAGING_DIR@/usr/,g" \
|
|
|
|
|
-e "s,@STAGING_DIR@,$(STAGING_DIR),g" \
|
|
|
|
|
-e "s,@BASE_DIR@,$(BASE_DIR),g" \
|
2013-02-07 13:35:03 +01:00
|
|
|
$(addprefix $(STAGING_DIR)/usr/bin/,$($(PKG)_CONFIG_SCRIPTS)) ;\
|
2013-01-30 03:46:40 +01:00
|
|
|
fi
|
2015-05-03 23:30:39 +02:00
|
|
|
@$(call MESSAGE,"Fixing libtool files")
|
|
|
|
|
$(Q)find $(STAGING_DIR)/usr/lib* -name "*.la" | xargs --no-run-if-empty \
|
|
|
|
|
$(SED) "s:$(BASE_DIR):@BASE_DIR@:g" \
|
|
|
|
|
-e "s:$(STAGING_DIR):@STAGING_DIR@:g" \
|
|
|
|
|
$(if $(TOOLCHAIN_EXTERNAL_INSTALL_DIR),\
|
|
|
|
|
-e "s:$(TOOLCHAIN_EXTERNAL_INSTALL_DIR):@TOOLCHAIN_EXTERNAL_INSTALL_DIR@:g") \
|
|
|
|
|
-e "s:\(['= ]\)/usr:\\1@STAGING_DIR@/usr:g" \
|
|
|
|
|
$(if $(TOOLCHAIN_EXTERNAL_INSTALL_DIR),\
|
|
|
|
|
-e "s:@TOOLCHAIN_EXTERNAL_INSTALL_DIR@:$(TOOLCHAIN_EXTERNAL_INSTALL_DIR):g") \
|
|
|
|
|
-e "s:@STAGING_DIR@:$(STAGING_DIR):g" \
|
|
|
|
|
-e "s:@BASE_DIR@:$(BASE_DIR):g"
|
2013-11-11 16:03:27 +01:00
|
|
|
@$(call step_end,install-staging)
|
2015-11-03 20:06:03 +01:00
|
|
|
$(Q)touch $@
|
2009-11-08 18:37:36 +01:00
|
|
|
|
2011-07-05 21:53:56 +02:00
|
|
|
# Install to images dir
|
|
|
|
|
$(BUILD_DIR)/%/.stamp_images_installed:
|
2013-11-11 16:03:27 +01:00
|
|
|
@$(call step_start,install-image)
|
2014-05-05 15:04:20 +02:00
|
|
|
$(foreach hook,$($(PKG)_PRE_INSTALL_IMAGES_HOOKS),$(call $(hook))$(sep))
|
2011-07-18 12:49:25 +02:00
|
|
|
@$(call MESSAGE,"Installing to images directory")
|
2014-02-14 10:55:07 +01:00
|
|
|
+$($(PKG)_INSTALL_IMAGES_CMDS)
|
2011-07-05 21:53:56 +02:00
|
|
|
$(foreach hook,$($(PKG)_POST_INSTALL_IMAGES_HOOKS),$(call $(hook))$(sep))
|
2013-11-11 16:03:27 +01:00
|
|
|
@$(call step_end,install-image)
|
2015-11-03 20:06:03 +01:00
|
|
|
$(Q)touch $@
|
2011-07-05 21:53:56 +02:00
|
|
|
|
2009-11-08 18:37:36 +01:00
|
|
|
# Install to target dir
|
|
|
|
|
$(BUILD_DIR)/%/.stamp_target_installed:
|
2013-11-11 16:03:27 +01:00
|
|
|
@$(call step_start,install-target)
|
2009-11-08 18:37:36 +01:00
|
|
|
@$(call MESSAGE,"Installing to target")
|
2014-05-05 15:04:20 +02:00
|
|
|
$(foreach hook,$($(PKG)_PRE_INSTALL_TARGET_HOOKS),$(call $(hook))$(sep))
|
2014-07-06 15:45:47 +02:00
|
|
|
+$($(PKG)_INSTALL_TARGET_CMDS)
|
2012-07-28 09:21:20 +02:00
|
|
|
$(if $(BR2_INIT_SYSTEMD),\
|
|
|
|
|
$($(PKG)_INSTALL_INIT_SYSTEMD))
|
|
|
|
|
$(if $(BR2_INIT_SYSV)$(BR2_INIT_BUSYBOX),\
|
|
|
|
|
$($(PKG)_INSTALL_INIT_SYSV))
|
2009-11-08 18:37:36 +01:00
|
|
|
$(foreach hook,$($(PKG)_POST_INSTALL_TARGET_HOOKS),$(call $(hook))$(sep))
|
2013-02-07 13:35:04 +01:00
|
|
|
$(Q)if test -n "$($(PKG)_CONFIG_SCRIPTS)" ; then \
|
|
|
|
|
$(RM) -f $(addprefix $(TARGET_DIR)/usr/bin/,$($(PKG)_CONFIG_SCRIPTS)) ; \
|
|
|
|
|
fi
|
2013-11-11 16:03:27 +01:00
|
|
|
@$(call step_end,install-target)
|
2015-11-03 20:06:03 +01:00
|
|
|
$(Q)touch $@
|
2009-11-08 18:37:36 +01:00
|
|
|
|
|
|
|
|
# Remove package sources
|
|
|
|
|
$(BUILD_DIR)/%/.stamp_dircleaned:
|
|
|
|
|
rm -Rf $(@D)
|
|
|
|
|
|
2014-05-15 19:37:03 +02:00
|
|
|
################################################################################
|
|
|
|
|
# virt-provides-single -- check that provider-pkg is the declared provider for
|
|
|
|
|
# the virtual package virt-pkg
|
|
|
|
|
#
|
|
|
|
|
# argument 1 is the lower-case name of the virtual package
|
|
|
|
|
# argument 2 is the upper-case name of the virtual package
|
|
|
|
|
# argument 3 is the lower-case name of the provider
|
|
|
|
|
#
|
|
|
|
|
# example:
|
|
|
|
|
# $(call virt-provides-single,libegl,LIBEGL,rpi-userland)
|
|
|
|
|
################################################################################
|
|
|
|
|
define virt-provides-single
|
|
|
|
|
ifneq ($$(call qstrip,$$(BR2_PACKAGE_PROVIDES_$(2))),$(3))
|
|
|
|
|
$$(error Configuration error: both "$(3)" and $$(BR2_PACKAGE_PROVIDES_$(2))\
|
|
|
|
|
are selected as providers for virtual package "$(1)". Only one provider can\
|
|
|
|
|
be selected at a time. Please fix your configuration)
|
|
|
|
|
endif
|
|
|
|
|
endef
|
|
|
|
|
|
2016-10-23 19:19:44 +02:00
|
|
|
define pkg-graph-depends
|
|
|
|
|
@$$(INSTALL) -d $$(GRAPHS_DIR)
|
|
|
|
|
@cd "$$(CONFIG_DIR)"; \
|
|
|
|
|
$$(TOPDIR)/support/scripts/graph-depends $$(BR2_GRAPH_DEPS_OPTS) \
|
|
|
|
|
-p $(1) $(2) -o $$(GRAPHS_DIR)/$$(@).dot
|
|
|
|
|
dot $$(BR2_GRAPH_DOT_OPTS) -T$$(BR_GRAPH_OUT) \
|
|
|
|
|
-o $$(GRAPHS_DIR)/$$(@).$$(BR_GRAPH_OUT) \
|
|
|
|
|
$$(GRAPHS_DIR)/$$(@).dot
|
|
|
|
|
endef
|
|
|
|
|
|
2009-11-08 18:37:36 +01:00
|
|
|
################################################################################
|
2012-07-03 00:07:08 +02:00
|
|
|
# inner-generic-package -- generates the make targets needed to build a
|
2009-11-08 18:37:36 +01:00
|
|
|
# generic package
|
|
|
|
|
#
|
|
|
|
|
# argument 1 is the lowercase package name
|
2014-07-24 20:57:41 +02:00
|
|
|
# argument 2 is the uppercase package name, including a HOST_ prefix
|
2009-11-08 18:37:36 +01:00
|
|
|
# for host packages
|
|
|
|
|
# argument 3 is the uppercase package name, without the HOST_ prefix
|
|
|
|
|
# for host packages
|
2014-02-05 10:44:03 +01:00
|
|
|
# argument 4 is the type (target or host)
|
2014-06-11 21:12:25 +02:00
|
|
|
#
|
|
|
|
|
# Note about variable and function references: inside all blocks that are
|
|
|
|
|
# evaluated with $(eval), which includes all 'inner-xxx-package' blocks,
|
|
|
|
|
# specific rules apply with respect to variable and function references.
|
|
|
|
|
# - Numbered variables (parameters to the block) can be referenced with a single
|
|
|
|
|
# dollar sign: $(1), $(2), $(3), etc.
|
|
|
|
|
# - pkgdir and pkgname should be referenced with a single dollar sign too. These
|
|
|
|
|
# functions rely on 'the most recently parsed makefile' which is supposed to
|
|
|
|
|
# be the package .mk file. If we defer the evaluation of these functions using
|
|
|
|
|
# double dollar signs, then they may be evaluated too late, when other
|
|
|
|
|
# makefiles have already been parsed. One specific case is when $$(pkgdir) is
|
|
|
|
|
# assigned to a variable using deferred evaluation with '=' and this variable
|
|
|
|
|
# is used in a target rule outside the eval'ed inner block. In this case, the
|
|
|
|
|
# pkgdir will be that of the last makefile parsed by buildroot, which is not
|
|
|
|
|
# the expected value. This mechanism is for example used for the TARGET_PATCH
|
|
|
|
|
# rule.
|
|
|
|
|
# - All other variables should be referenced with a double dollar sign:
|
|
|
|
|
# $$(TARGET_DIR), $$($(2)_VERSION), etc. Also all make functions should be
|
|
|
|
|
# referenced with a double dollar sign: $$(subst), $$(call), $$(filter-out),
|
|
|
|
|
# etc. This rule ensures that these variables and functions are only expanded
|
|
|
|
|
# during the $(eval) step, and not earlier. Otherwise, unintuitive and
|
|
|
|
|
# undesired behavior occurs with respect to these variables and functions.
|
|
|
|
|
#
|
2009-11-08 18:37:36 +01:00
|
|
|
################################################################################
|
|
|
|
|
|
2012-07-03 00:07:08 +02:00
|
|
|
define inner-generic-package
|
2009-11-08 18:37:36 +01:00
|
|
|
|
2018-03-31 11:05:51 +02:00
|
|
|
# When doing a package, we're definitely not doing a rootfs, but we
|
|
|
|
|
# may inherit it via the dependency chain, so we reset it.
|
|
|
|
|
$(1): ROOTFS=
|
|
|
|
|
|
2015-10-22 22:33:56 +02:00
|
|
|
# Ensure the package is only declared once, i.e. do not accept that a
|
|
|
|
|
# package be re-defined by a br2-external tree
|
|
|
|
|
ifneq ($(call strip,$(filter $(1),$(PACKAGES_ALL))),)
|
|
|
|
|
$$(error Package '$(1)' defined a second time in '$(pkgdir)'; \
|
|
|
|
|
previous definition was in '$$($(2)_PKGDIR)')
|
|
|
|
|
endif
|
|
|
|
|
PACKAGES_ALL += $(1)
|
|
|
|
|
|
2009-11-08 18:37:36 +01:00
|
|
|
# Define default values for various package-related variables, if not
|
|
|
|
|
# already defined. For some variables (version, source, site and
|
|
|
|
|
# subdir), if they are undefined, we try to see if a variable without
|
|
|
|
|
# the HOST_ prefix is defined. If so, we use such a variable, so that
|
2014-07-24 20:07:02 +02:00
|
|
|
# this information has only to be specified once, for both the
|
2009-11-08 18:37:36 +01:00
|
|
|
# target and host packages of a given .mk file.
|
|
|
|
|
|
2014-02-05 10:44:03 +01:00
|
|
|
$(2)_TYPE = $(4)
|
2009-11-08 18:37:36 +01:00
|
|
|
$(2)_NAME = $(1)
|
infra: consistently use double dollar signs inside inner-xxx-targets
The inner-xxx-targets in the buildroot package infrastructures are
evaluated using $(eval) which causes variable references to be a bit
different than in regular make code. As we want most references to be
expanded only at the time of the $(eval) we should not use standard
references $(VAR) but rather use double dollar signs $$(VAR). This includes
function references like $(call), $(subst), etc. The only exception is the
reference to pkgdir/pkgname and numbered variables, which are parameters to
the inner block: $(1), $(2), etc.
This patch introduces consistent usage of double-dollar signs throughout the
different inner-xxx-targets blocks.
In some cases, this would potentially cause circular references, in
particular when the value of HOST_FOO_VAR would be obtained from the
corresponding FOO_VAR if HOST_FOO_VAR is not defined. In these cases, a test
is added to check for a host package (the only case where such constructions
are relevant; these are not circular).
Benefits of these changes are:
- behavior of variables is now again as expected. For example, setting
$(2)_VERSION = virtual in pkg-virtual.mk will effectively work, while
originally it would cause very odd results.
- The output of 'make printvars' is now much more useful. This target shows
the value of all variables, and the expression that led to that value.
However, if the expression was coming from an inner-xxx-targets block, and
was using single dollar signs, it would show in printvars as
VAR = value (value)
while if double dollar signs are used, it would effectively look like
VAR = value (actual expression)
as is intended.
This improvement is for example effective for FOO_DL_VERSION, FOO_RAWNAME,
FOO_SITE_METHOD and FOO_MAKE.
The correctness of this patch has been verified using 'make printvars',
'make manual' and 'make legal-info' before and after applying this patch,
and comparing the output.
Insight-provided-by: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-06-11 21:12:24 +02:00
|
|
|
$(2)_RAWNAME = $$(patsubst host-%,%,$(1))
|
2015-10-22 22:33:56 +02:00
|
|
|
$(2)_PKGDIR = $(pkgdir)
|
2009-11-08 18:37:36 +01:00
|
|
|
|
2010-09-19 01:21:15 +02:00
|
|
|
# Keep the package version that may contain forward slashes in the _DL_VERSION
|
|
|
|
|
# variable, then replace all forward slashes ('/') by underscores ('_') to
|
|
|
|
|
# sanitize the package version that is used in paths, directory and file names.
|
|
|
|
|
# Forward slashes may appear in the package's version when pointing to a
|
|
|
|
|
# version control system branch or tag, for example remotes/origin/1_10_stable.
|
2015-04-23 01:08:08 +02:00
|
|
|
# Similar for spaces and colons (:) that may appear in date-based revisions for
|
|
|
|
|
# CVS.
|
2009-11-08 18:37:36 +01:00
|
|
|
ifndef $(2)_VERSION
|
2015-07-11 17:40:14 +02:00
|
|
|
ifdef $(3)_DL_VERSION
|
|
|
|
|
$(2)_DL_VERSION := $$($(3)_DL_VERSION)
|
|
|
|
|
else ifdef $(3)_VERSION
|
|
|
|
|
$(2)_DL_VERSION := $$($(3)_VERSION)
|
2009-11-08 18:37:36 +01:00
|
|
|
endif
|
2010-09-19 01:21:15 +02:00
|
|
|
else
|
2015-07-11 17:40:14 +02:00
|
|
|
$(2)_DL_VERSION := $$(strip $$($(2)_VERSION))
|
2009-11-08 18:37:36 +01:00
|
|
|
endif
|
2015-07-11 17:40:14 +02:00
|
|
|
$(2)_VERSION := $$(call sanitize,$$($(2)_DL_VERSION))
|
2009-11-08 18:37:36 +01:00
|
|
|
|
2015-07-19 15:15:28 +02:00
|
|
|
ifdef $(3)_OVERRIDE_SRCDIR
|
|
|
|
|
$(2)_OVERRIDE_SRCDIR ?= $$($(3)_OVERRIDE_SRCDIR)
|
|
|
|
|
endif
|
|
|
|
|
|
core: rename FOO_BASE_NAME to FOO_BASENAME to avoid clashes
In current Buildroot, clashes occur between the variables _NAME and
_BASE_NAME for two packages called foo and foo-base, i.e.
Package foo:
FOO_NAME = foo
FOO_BASE_NAME = foo-1.2.3
Package foo-base:
FOO_BASE_NAME = foo-base
FOO_BASE_BASE_NAME = foo-base-4.5.6
where variable FOO_BASE_NAME is clashing between these two packages.
Specific cases where this clash is already existing are:
- alljoyn-base
- alljoyn-tcl-base
- perl-xml-sax-base
The problem is generic and can occur for a number of variables in Buildroot.
A non-exhaustive list:
<pkg>_BASE and <pkg>_BASE_NAME
<pkg>_BASE_NAME and <pkg>_RAW_BASE_NAME
<pkg>_DIR and <pkg>_DL_DIR
<pkg>_VERSION and <pkg>_DL_VERSION
<pkg>_SOURCE and <pkg>_TARGET_SOURCE
<pkg>_INSTALL_IMAGES and <pkg>_TARGET_INSTALL_IMAGES (same for _STAGING and _TARGET)
<pkg>_LICENSE_FILES and <pkg>_MANIFEST_LICENSE_FILES
<pkg>_DEPENDENCIES and <pkg>_FINAL_DEPENDENCIES
One solution is to use another separator than '_' to separate the
package name from the rest of the variable name. For example, a double
underscore:
FOO__NAME
FOO__BASE_NAME
FOO_BASE__NAME
FOO_BASE__BASE_NAME
However, making that change for only this case means that the variable
naming is no longer consistent. And making the change for all variables has
a large impact, also on certain user scripts.
For now, keep it simple, and rename FOO_BASE_NAME into FOO_BASENAME, so that
the variables become:
FOO_NAME
FOO_BASENAME
FOO_BASE_NAME
FOO_BASE_BASENAME
For consistency, also adapt FOO_RAW_BASE_NAME. Since FOO_RAW_BASENAME would
still pose a conflict with a package called 'foo-raw', take the opportunity
to rename it into FOO_BASENAME_RAW instead, which does not pose a conflict
as we have no variable called FOO_RAW.
Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Reviewed-by: Sam Voss <sam.voss@rockwellcollins.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2018-02-06 13:59:23 +01:00
|
|
|
$(2)_BASENAME = $$(if $$($(2)_VERSION),$(1)-$$($(2)_VERSION),$(1))
|
|
|
|
|
$(2)_BASENAME_RAW = $$(if $$($(2)_VERSION),$$($(2)_RAWNAME)-$$($(2)_VERSION),$$($(2)_RAWNAME))
|
2018-04-02 16:57:56 +02:00
|
|
|
$(2)_DL_SUBDIR ?= $$($(2)_RAWNAME)
|
|
|
|
|
$(2)_DL_DIR = $$(DL_DIR)/$$($(2)_DL_SUBDIR)
|
core: rename FOO_BASE_NAME to FOO_BASENAME to avoid clashes
In current Buildroot, clashes occur between the variables _NAME and
_BASE_NAME for two packages called foo and foo-base, i.e.
Package foo:
FOO_NAME = foo
FOO_BASE_NAME = foo-1.2.3
Package foo-base:
FOO_BASE_NAME = foo-base
FOO_BASE_BASE_NAME = foo-base-4.5.6
where variable FOO_BASE_NAME is clashing between these two packages.
Specific cases where this clash is already existing are:
- alljoyn-base
- alljoyn-tcl-base
- perl-xml-sax-base
The problem is generic and can occur for a number of variables in Buildroot.
A non-exhaustive list:
<pkg>_BASE and <pkg>_BASE_NAME
<pkg>_BASE_NAME and <pkg>_RAW_BASE_NAME
<pkg>_DIR and <pkg>_DL_DIR
<pkg>_VERSION and <pkg>_DL_VERSION
<pkg>_SOURCE and <pkg>_TARGET_SOURCE
<pkg>_INSTALL_IMAGES and <pkg>_TARGET_INSTALL_IMAGES (same for _STAGING and _TARGET)
<pkg>_LICENSE_FILES and <pkg>_MANIFEST_LICENSE_FILES
<pkg>_DEPENDENCIES and <pkg>_FINAL_DEPENDENCIES
One solution is to use another separator than '_' to separate the
package name from the rest of the variable name. For example, a double
underscore:
FOO__NAME
FOO__BASE_NAME
FOO_BASE__NAME
FOO_BASE__BASE_NAME
However, making that change for only this case means that the variable
naming is no longer consistent. And making the change for all variables has
a large impact, also on certain user scripts.
For now, keep it simple, and rename FOO_BASE_NAME into FOO_BASENAME, so that
the variables become:
FOO_NAME
FOO_BASENAME
FOO_BASE_NAME
FOO_BASE_BASENAME
For consistency, also adapt FOO_RAW_BASE_NAME. Since FOO_RAW_BASENAME would
still pose a conflict with a package called 'foo-raw', take the opportunity
to rename it into FOO_BASENAME_RAW instead, which does not pose a conflict
as we have no variable called FOO_RAW.
Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Reviewed-by: Sam Voss <sam.voss@rockwellcollins.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2018-02-06 13:59:23 +01:00
|
|
|
$(2)_DIR = $$(BUILD_DIR)/$$($(2)_BASENAME)
|
2009-11-08 18:37:36 +01:00
|
|
|
|
2012-07-24 09:17:56 +02:00
|
|
|
ifndef $(2)_SUBDIR
|
|
|
|
|
ifdef $(3)_SUBDIR
|
|
|
|
|
$(2)_SUBDIR = $$($(3)_SUBDIR)
|
2012-07-22 15:28:34 +02:00
|
|
|
else
|
2012-07-24 09:17:56 +02:00
|
|
|
$(2)_SUBDIR ?=
|
2012-07-22 15:28:34 +02:00
|
|
|
endif
|
|
|
|
|
endif
|
|
|
|
|
|
2015-07-11 16:15:04 +02:00
|
|
|
ifndef $(2)_STRIP_COMPONENTS
|
|
|
|
|
ifdef $(3)_STRIP_COMPONENTS
|
|
|
|
|
$(2)_STRIP_COMPONENTS = $$($(3)_STRIP_COMPONENTS)
|
|
|
|
|
else
|
|
|
|
|
$(2)_STRIP_COMPONENTS ?= 1
|
|
|
|
|
endif
|
|
|
|
|
endif
|
|
|
|
|
|
2012-07-22 15:28:34 +02:00
|
|
|
$(2)_SRCDIR = $$($(2)_DIR)/$$($(2)_SUBDIR)
|
|
|
|
|
$(2)_BUILDDIR ?= $$($(2)_SRCDIR)
|
|
|
|
|
|
2011-09-29 21:57:37 +02:00
|
|
|
ifneq ($$($(2)_OVERRIDE_SRCDIR),)
|
|
|
|
|
$(2)_VERSION = custom
|
|
|
|
|
endif
|
|
|
|
|
|
2009-11-08 18:37:36 +01:00
|
|
|
ifndef $(2)_SOURCE
|
|
|
|
|
ifdef $(3)_SOURCE
|
infra: consistently use double dollar signs inside inner-xxx-targets
The inner-xxx-targets in the buildroot package infrastructures are
evaluated using $(eval) which causes variable references to be a bit
different than in regular make code. As we want most references to be
expanded only at the time of the $(eval) we should not use standard
references $(VAR) but rather use double dollar signs $$(VAR). This includes
function references like $(call), $(subst), etc. The only exception is the
reference to pkgdir/pkgname and numbered variables, which are parameters to
the inner block: $(1), $(2), etc.
This patch introduces consistent usage of double-dollar signs throughout the
different inner-xxx-targets blocks.
In some cases, this would potentially cause circular references, in
particular when the value of HOST_FOO_VAR would be obtained from the
corresponding FOO_VAR if HOST_FOO_VAR is not defined. In these cases, a test
is added to check for a host package (the only case where such constructions
are relevant; these are not circular).
Benefits of these changes are:
- behavior of variables is now again as expected. For example, setting
$(2)_VERSION = virtual in pkg-virtual.mk will effectively work, while
originally it would cause very odd results.
- The output of 'make printvars' is now much more useful. This target shows
the value of all variables, and the expression that led to that value.
However, if the expression was coming from an inner-xxx-targets block, and
was using single dollar signs, it would show in printvars as
VAR = value (value)
while if double dollar signs are used, it would effectively look like
VAR = value (actual expression)
as is intended.
This improvement is for example effective for FOO_DL_VERSION, FOO_RAWNAME,
FOO_SITE_METHOD and FOO_MAKE.
The correctness of this patch has been verified using 'make printvars',
'make manual' and 'make legal-info' before and after applying this patch,
and comparing the output.
Insight-provided-by: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-06-11 21:12:24 +02:00
|
|
|
$(2)_SOURCE = $$($(3)_SOURCE)
|
2016-07-03 11:49:49 +02:00
|
|
|
else ifdef $(2)_VERSION
|
core: rename FOO_BASE_NAME to FOO_BASENAME to avoid clashes
In current Buildroot, clashes occur between the variables _NAME and
_BASE_NAME for two packages called foo and foo-base, i.e.
Package foo:
FOO_NAME = foo
FOO_BASE_NAME = foo-1.2.3
Package foo-base:
FOO_BASE_NAME = foo-base
FOO_BASE_BASE_NAME = foo-base-4.5.6
where variable FOO_BASE_NAME is clashing between these two packages.
Specific cases where this clash is already existing are:
- alljoyn-base
- alljoyn-tcl-base
- perl-xml-sax-base
The problem is generic and can occur for a number of variables in Buildroot.
A non-exhaustive list:
<pkg>_BASE and <pkg>_BASE_NAME
<pkg>_BASE_NAME and <pkg>_RAW_BASE_NAME
<pkg>_DIR and <pkg>_DL_DIR
<pkg>_VERSION and <pkg>_DL_VERSION
<pkg>_SOURCE and <pkg>_TARGET_SOURCE
<pkg>_INSTALL_IMAGES and <pkg>_TARGET_INSTALL_IMAGES (same for _STAGING and _TARGET)
<pkg>_LICENSE_FILES and <pkg>_MANIFEST_LICENSE_FILES
<pkg>_DEPENDENCIES and <pkg>_FINAL_DEPENDENCIES
One solution is to use another separator than '_' to separate the
package name from the rest of the variable name. For example, a double
underscore:
FOO__NAME
FOO__BASE_NAME
FOO_BASE__NAME
FOO_BASE__BASE_NAME
However, making that change for only this case means that the variable
naming is no longer consistent. And making the change for all variables has
a large impact, also on certain user scripts.
For now, keep it simple, and rename FOO_BASE_NAME into FOO_BASENAME, so that
the variables become:
FOO_NAME
FOO_BASENAME
FOO_BASE_NAME
FOO_BASE_BASENAME
For consistency, also adapt FOO_RAW_BASE_NAME. Since FOO_RAW_BASENAME would
still pose a conflict with a package called 'foo-raw', take the opportunity
to rename it into FOO_BASENAME_RAW instead, which does not pose a conflict
as we have no variable called FOO_RAW.
Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Reviewed-by: Sam Voss <sam.voss@rockwellcollins.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2018-02-06 13:59:23 +01:00
|
|
|
$(2)_SOURCE ?= $$($(2)_BASENAME_RAW).tar.gz
|
2009-11-08 18:37:36 +01:00
|
|
|
endif
|
|
|
|
|
endif
|
|
|
|
|
|
2016-05-07 18:14:37 +02:00
|
|
|
# If FOO_ACTUAL_SOURCE_TARBALL is explicitly defined, it means FOO_SOURCE is
|
|
|
|
|
# indeed a binary (e.g. external toolchain) and FOO_ACTUAL_SOURCE_TARBALL/_SITE
|
|
|
|
|
# point to the actual sources tarball. Use the actual sources for legal-info.
|
|
|
|
|
# For most packages the FOO_SITE/FOO_SOURCE pair points to real source code,
|
|
|
|
|
# so these are the defaults for FOO_ACTUAL_*.
|
|
|
|
|
$(2)_ACTUAL_SOURCE_TARBALL ?= $$($(2)_SOURCE)
|
|
|
|
|
$(2)_ACTUAL_SOURCE_SITE ?= $$(call qstrip,$$($(2)_SITE))
|
|
|
|
|
|
2009-11-08 18:37:36 +01:00
|
|
|
ifndef $(2)_PATCH
|
|
|
|
|
ifdef $(3)_PATCH
|
infra: consistently use double dollar signs inside inner-xxx-targets
The inner-xxx-targets in the buildroot package infrastructures are
evaluated using $(eval) which causes variable references to be a bit
different than in regular make code. As we want most references to be
expanded only at the time of the $(eval) we should not use standard
references $(VAR) but rather use double dollar signs $$(VAR). This includes
function references like $(call), $(subst), etc. The only exception is the
reference to pkgdir/pkgname and numbered variables, which are parameters to
the inner block: $(1), $(2), etc.
This patch introduces consistent usage of double-dollar signs throughout the
different inner-xxx-targets blocks.
In some cases, this would potentially cause circular references, in
particular when the value of HOST_FOO_VAR would be obtained from the
corresponding FOO_VAR if HOST_FOO_VAR is not defined. In these cases, a test
is added to check for a host package (the only case where such constructions
are relevant; these are not circular).
Benefits of these changes are:
- behavior of variables is now again as expected. For example, setting
$(2)_VERSION = virtual in pkg-virtual.mk will effectively work, while
originally it would cause very odd results.
- The output of 'make printvars' is now much more useful. This target shows
the value of all variables, and the expression that led to that value.
However, if the expression was coming from an inner-xxx-targets block, and
was using single dollar signs, it would show in printvars as
VAR = value (value)
while if double dollar signs are used, it would effectively look like
VAR = value (actual expression)
as is intended.
This improvement is for example effective for FOO_DL_VERSION, FOO_RAWNAME,
FOO_SITE_METHOD and FOO_MAKE.
The correctness of this patch has been verified using 'make printvars',
'make manual' and 'make legal-info' before and after applying this patch,
and comparing the output.
Insight-provided-by: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-06-11 21:12:24 +02:00
|
|
|
$(2)_PATCH = $$($(3)_PATCH)
|
2009-11-08 18:37:36 +01:00
|
|
|
endif
|
|
|
|
|
endif
|
|
|
|
|
|
2018-05-02 21:50:38 +02:00
|
|
|
ifneq ($$(filter bzr cvs hg svn,$$($(2)_SITE_METHOD)),)
|
core/pkg-infra: set no-check-hash only for main download
Currently, when the main download if from an SCM, we exclude all
downloads from being hash-checked, on the assumption that we don't
have hashes for downloads from an SCM.
However, the exclusion is computed on the DOWNLOAD macro, which is
called for each download of a package, thus effectively disabling
hash checks for extra downloads, even though those are only ever
download with wget.
What we really wanted to do, in fact, was to exclude just the main
download.
We fix that by appending the main source file to the global list of
excluded files, from within the generic-package infra itself.
Reported-by: Luca Ceresoli <luca@lucaceresoli.net>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
Tested-by: Luca Ceresoli <luca@lucaceresoli.net>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
2018-04-25 21:41:52 +02:00
|
|
|
BR_NO_CHECK_HASH_FOR += $$($(2)_SOURCE)
|
|
|
|
|
endif
|
|
|
|
|
|
2015-04-26 11:51:11 +02:00
|
|
|
$(2)_ALL_DOWNLOADS = \
|
2018-05-03 22:17:57 +02:00
|
|
|
$$(if $$($(2)_SOURCE),$$($(2)_SITE_METHOD)+$$($(2)_SITE)/$$($(2)_SOURCE)) \
|
core/pkg-infra: don't enforce site-method for extra downloads
The site method only ever applies to the main download, while extra
downloads are always to be fetched with wget.
However, the site method is prepended to the URL from within the
DOWNLOAD macro (well, a variable evaluated in the DOWNLOAD macro),
which is called for each download of a package, thus effectively
prepending the site method to all downloads, even the extra ones (and
the patches).
We fix that by prepending the site method from within the
generic-package infra, so that it only applies to the main download.
For that, we move the main _SOURCE out of the foreach loop, so that
we can prepend the site-method to it, without impacting the other
downloads.
Reported-by: Luca Ceresoli <luca@lucaceresoli.net>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
Tested-by: Luca Ceresoli <luca@lucaceresoli.net>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
2018-04-25 21:41:53 +02:00
|
|
|
$$(foreach p,$$($(2)_PATCH) $$($(2)_EXTRA_DOWNLOADS),\
|
2015-04-26 11:51:11 +02:00
|
|
|
$$(if $$(findstring ://,$$(p)),$$(p),\
|
2015-10-03 19:22:18 +02:00
|
|
|
$$($(2)_SITE)/$$(p)))
|
2015-04-26 11:51:11 +02:00
|
|
|
|
2009-11-08 18:37:36 +01:00
|
|
|
ifndef $(2)_SITE
|
|
|
|
|
ifdef $(3)_SITE
|
infra: consistently use double dollar signs inside inner-xxx-targets
The inner-xxx-targets in the buildroot package infrastructures are
evaluated using $(eval) which causes variable references to be a bit
different than in regular make code. As we want most references to be
expanded only at the time of the $(eval) we should not use standard
references $(VAR) but rather use double dollar signs $$(VAR). This includes
function references like $(call), $(subst), etc. The only exception is the
reference to pkgdir/pkgname and numbered variables, which are parameters to
the inner block: $(1), $(2), etc.
This patch introduces consistent usage of double-dollar signs throughout the
different inner-xxx-targets blocks.
In some cases, this would potentially cause circular references, in
particular when the value of HOST_FOO_VAR would be obtained from the
corresponding FOO_VAR if HOST_FOO_VAR is not defined. In these cases, a test
is added to check for a host package (the only case where such constructions
are relevant; these are not circular).
Benefits of these changes are:
- behavior of variables is now again as expected. For example, setting
$(2)_VERSION = virtual in pkg-virtual.mk will effectively work, while
originally it would cause very odd results.
- The output of 'make printvars' is now much more useful. This target shows
the value of all variables, and the expression that led to that value.
However, if the expression was coming from an inner-xxx-targets block, and
was using single dollar signs, it would show in printvars as
VAR = value (value)
while if double dollar signs are used, it would effectively look like
VAR = value (actual expression)
as is intended.
This improvement is for example effective for FOO_DL_VERSION, FOO_RAWNAME,
FOO_SITE_METHOD and FOO_MAKE.
The correctness of this patch has been verified using 'make printvars',
'make manual' and 'make legal-info' before and after applying this patch,
and comparing the output.
Insight-provided-by: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-06-11 21:12:24 +02:00
|
|
|
$(2)_SITE = $$($(3)_SITE)
|
2009-11-08 18:37:36 +01:00
|
|
|
endif
|
|
|
|
|
endif
|
|
|
|
|
|
Implement basic non-wget download methods
Packages can now be sourced from Git and Subversion repositories. The
download method will be autodetected from the URI (git://, svn://, etc).
If the repository is accessed through http(s), you can force the
download method by setting a _SITE_METHOD variable to either 'git' or
'svn', respectively and without the quotes.
The package's _VERSION variable defines which commit, revision, tag or
branch should be checked out. For Git, it can be HEAD, a commit ID, a
tag name or branch name (anything that can be checked out with `git
checkout`). For Subversion, it must be a revision number, or HEAD.
Signed-off-by: Maxime Petazzoni <maxime.petazzoni@bulix.org>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2010-09-02 12:09:47 +02:00
|
|
|
ifndef $(2)_SITE_METHOD
|
|
|
|
|
ifdef $(3)_SITE_METHOD
|
infra: consistently use double dollar signs inside inner-xxx-targets
The inner-xxx-targets in the buildroot package infrastructures are
evaluated using $(eval) which causes variable references to be a bit
different than in regular make code. As we want most references to be
expanded only at the time of the $(eval) we should not use standard
references $(VAR) but rather use double dollar signs $$(VAR). This includes
function references like $(call), $(subst), etc. The only exception is the
reference to pkgdir/pkgname and numbered variables, which are parameters to
the inner block: $(1), $(2), etc.
This patch introduces consistent usage of double-dollar signs throughout the
different inner-xxx-targets blocks.
In some cases, this would potentially cause circular references, in
particular when the value of HOST_FOO_VAR would be obtained from the
corresponding FOO_VAR if HOST_FOO_VAR is not defined. In these cases, a test
is added to check for a host package (the only case where such constructions
are relevant; these are not circular).
Benefits of these changes are:
- behavior of variables is now again as expected. For example, setting
$(2)_VERSION = virtual in pkg-virtual.mk will effectively work, while
originally it would cause very odd results.
- The output of 'make printvars' is now much more useful. This target shows
the value of all variables, and the expression that led to that value.
However, if the expression was coming from an inner-xxx-targets block, and
was using single dollar signs, it would show in printvars as
VAR = value (value)
while if double dollar signs are used, it would effectively look like
VAR = value (actual expression)
as is intended.
This improvement is for example effective for FOO_DL_VERSION, FOO_RAWNAME,
FOO_SITE_METHOD and FOO_MAKE.
The correctness of this patch has been verified using 'make printvars',
'make manual' and 'make legal-info' before and after applying this patch,
and comparing the output.
Insight-provided-by: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-06-11 21:12:24 +02:00
|
|
|
$(2)_SITE_METHOD = $$($(3)_SITE_METHOD)
|
Implement basic non-wget download methods
Packages can now be sourced from Git and Subversion repositories. The
download method will be autodetected from the URI (git://, svn://, etc).
If the repository is accessed through http(s), you can force the
download method by setting a _SITE_METHOD variable to either 'git' or
'svn', respectively and without the quotes.
The package's _VERSION variable defines which commit, revision, tag or
branch should be checked out. For Git, it can be HEAD, a commit ID, a
tag name or branch name (anything that can be checked out with `git
checkout`). For Subversion, it must be a revision number, or HEAD.
Signed-off-by: Maxime Petazzoni <maxime.petazzoni@bulix.org>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2010-09-02 12:09:47 +02:00
|
|
|
else
|
|
|
|
|
# Try automatic detection using the scheme part of the URI
|
infra: consistently use double dollar signs inside inner-xxx-targets
The inner-xxx-targets in the buildroot package infrastructures are
evaluated using $(eval) which causes variable references to be a bit
different than in regular make code. As we want most references to be
expanded only at the time of the $(eval) we should not use standard
references $(VAR) but rather use double dollar signs $$(VAR). This includes
function references like $(call), $(subst), etc. The only exception is the
reference to pkgdir/pkgname and numbered variables, which are parameters to
the inner block: $(1), $(2), etc.
This patch introduces consistent usage of double-dollar signs throughout the
different inner-xxx-targets blocks.
In some cases, this would potentially cause circular references, in
particular when the value of HOST_FOO_VAR would be obtained from the
corresponding FOO_VAR if HOST_FOO_VAR is not defined. In these cases, a test
is added to check for a host package (the only case where such constructions
are relevant; these are not circular).
Benefits of these changes are:
- behavior of variables is now again as expected. For example, setting
$(2)_VERSION = virtual in pkg-virtual.mk will effectively work, while
originally it would cause very odd results.
- The output of 'make printvars' is now much more useful. This target shows
the value of all variables, and the expression that led to that value.
However, if the expression was coming from an inner-xxx-targets block, and
was using single dollar signs, it would show in printvars as
VAR = value (value)
while if double dollar signs are used, it would effectively look like
VAR = value (actual expression)
as is intended.
This improvement is for example effective for FOO_DL_VERSION, FOO_RAWNAME,
FOO_SITE_METHOD and FOO_MAKE.
The correctness of this patch has been verified using 'make printvars',
'make manual' and 'make legal-info' before and after applying this patch,
and comparing the output.
Insight-provided-by: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-06-11 21:12:24 +02:00
|
|
|
$(2)_SITE_METHOD = $$(call geturischeme,$$($(2)_SITE))
|
Implement basic non-wget download methods
Packages can now be sourced from Git and Subversion repositories. The
download method will be autodetected from the URI (git://, svn://, etc).
If the repository is accessed through http(s), you can force the
download method by setting a _SITE_METHOD variable to either 'git' or
'svn', respectively and without the quotes.
The package's _VERSION variable defines which commit, revision, tag or
branch should be checked out. For Git, it can be HEAD, a commit ID, a
tag name or branch name (anything that can be checked out with `git
checkout`). For Subversion, it must be a revision number, or HEAD.
Signed-off-by: Maxime Petazzoni <maxime.petazzoni@bulix.org>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2010-09-02 12:09:47 +02:00
|
|
|
endif
|
|
|
|
|
endif
|
|
|
|
|
|
2016-07-01 11:01:19 +02:00
|
|
|
# Do not accept to download git submodule if not using the git method
|
|
|
|
|
ifneq ($$($(2)_GIT_SUBMODULES),)
|
|
|
|
|
ifneq ($$($(2)_SITE_METHOD),git)
|
|
|
|
|
$$(error $(2) declares having git sub-modules, but does not use the \
|
|
|
|
|
'git' method (uses '$$($(2)_SITE_METHOD)' instead))
|
|
|
|
|
endif
|
|
|
|
|
endif
|
|
|
|
|
|
2011-09-29 21:57:40 +02:00
|
|
|
ifeq ($$($(2)_SITE_METHOD),local)
|
|
|
|
|
ifeq ($$($(2)_OVERRIDE_SRCDIR),)
|
2013-10-12 12:15:08 +02:00
|
|
|
$(2)_OVERRIDE_SRCDIR = $$($(2)_SITE)
|
2011-09-29 21:57:40 +02:00
|
|
|
endif
|
2018-05-23 11:01:08 +02:00
|
|
|
ifeq ($$($(2)_OVERRIDE_SRCDIR),)
|
|
|
|
|
$$(error $(1) has local site method, but `$(2)_SITE` is not defined)
|
|
|
|
|
endif
|
2011-09-29 21:57:40 +02:00
|
|
|
endif
|
|
|
|
|
|
2012-05-17 19:33:00 +02:00
|
|
|
ifndef $(2)_LICENSE
|
|
|
|
|
ifdef $(3)_LICENSE
|
infra: consistently use double dollar signs inside inner-xxx-targets
The inner-xxx-targets in the buildroot package infrastructures are
evaluated using $(eval) which causes variable references to be a bit
different than in regular make code. As we want most references to be
expanded only at the time of the $(eval) we should not use standard
references $(VAR) but rather use double dollar signs $$(VAR). This includes
function references like $(call), $(subst), etc. The only exception is the
reference to pkgdir/pkgname and numbered variables, which are parameters to
the inner block: $(1), $(2), etc.
This patch introduces consistent usage of double-dollar signs throughout the
different inner-xxx-targets blocks.
In some cases, this would potentially cause circular references, in
particular when the value of HOST_FOO_VAR would be obtained from the
corresponding FOO_VAR if HOST_FOO_VAR is not defined. In these cases, a test
is added to check for a host package (the only case where such constructions
are relevant; these are not circular).
Benefits of these changes are:
- behavior of variables is now again as expected. For example, setting
$(2)_VERSION = virtual in pkg-virtual.mk will effectively work, while
originally it would cause very odd results.
- The output of 'make printvars' is now much more useful. This target shows
the value of all variables, and the expression that led to that value.
However, if the expression was coming from an inner-xxx-targets block, and
was using single dollar signs, it would show in printvars as
VAR = value (value)
while if double dollar signs are used, it would effectively look like
VAR = value (actual expression)
as is intended.
This improvement is for example effective for FOO_DL_VERSION, FOO_RAWNAME,
FOO_SITE_METHOD and FOO_MAKE.
The correctness of this patch has been verified using 'make printvars',
'make manual' and 'make legal-info' before and after applying this patch,
and comparing the output.
Insight-provided-by: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-06-11 21:12:24 +02:00
|
|
|
$(2)_LICENSE = $$($(3)_LICENSE)
|
2012-05-17 19:33:00 +02:00
|
|
|
endif
|
|
|
|
|
endif
|
|
|
|
|
|
2012-11-02 00:25:40 +01:00
|
|
|
$(2)_LICENSE ?= unknown
|
|
|
|
|
|
2012-05-17 19:33:00 +02:00
|
|
|
ifndef $(2)_LICENSE_FILES
|
|
|
|
|
ifdef $(3)_LICENSE_FILES
|
infra: consistently use double dollar signs inside inner-xxx-targets
The inner-xxx-targets in the buildroot package infrastructures are
evaluated using $(eval) which causes variable references to be a bit
different than in regular make code. As we want most references to be
expanded only at the time of the $(eval) we should not use standard
references $(VAR) but rather use double dollar signs $$(VAR). This includes
function references like $(call), $(subst), etc. The only exception is the
reference to pkgdir/pkgname and numbered variables, which are parameters to
the inner block: $(1), $(2), etc.
This patch introduces consistent usage of double-dollar signs throughout the
different inner-xxx-targets blocks.
In some cases, this would potentially cause circular references, in
particular when the value of HOST_FOO_VAR would be obtained from the
corresponding FOO_VAR if HOST_FOO_VAR is not defined. In these cases, a test
is added to check for a host package (the only case where such constructions
are relevant; these are not circular).
Benefits of these changes are:
- behavior of variables is now again as expected. For example, setting
$(2)_VERSION = virtual in pkg-virtual.mk will effectively work, while
originally it would cause very odd results.
- The output of 'make printvars' is now much more useful. This target shows
the value of all variables, and the expression that led to that value.
However, if the expression was coming from an inner-xxx-targets block, and
was using single dollar signs, it would show in printvars as
VAR = value (value)
while if double dollar signs are used, it would effectively look like
VAR = value (actual expression)
as is intended.
This improvement is for example effective for FOO_DL_VERSION, FOO_RAWNAME,
FOO_SITE_METHOD and FOO_MAKE.
The correctness of this patch has been verified using 'make printvars',
'make manual' and 'make legal-info' before and after applying this patch,
and comparing the output.
Insight-provided-by: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-06-11 21:12:24 +02:00
|
|
|
$(2)_LICENSE_FILES = $$($(3)_LICENSE_FILES)
|
2012-05-17 19:33:00 +02:00
|
|
|
endif
|
|
|
|
|
endif
|
|
|
|
|
|
2012-11-02 10:25:41 +01:00
|
|
|
ifndef $(2)_REDISTRIBUTE
|
|
|
|
|
ifdef $(3)_REDISTRIBUTE
|
infra: consistently use double dollar signs inside inner-xxx-targets
The inner-xxx-targets in the buildroot package infrastructures are
evaluated using $(eval) which causes variable references to be a bit
different than in regular make code. As we want most references to be
expanded only at the time of the $(eval) we should not use standard
references $(VAR) but rather use double dollar signs $$(VAR). This includes
function references like $(call), $(subst), etc. The only exception is the
reference to pkgdir/pkgname and numbered variables, which are parameters to
the inner block: $(1), $(2), etc.
This patch introduces consistent usage of double-dollar signs throughout the
different inner-xxx-targets blocks.
In some cases, this would potentially cause circular references, in
particular when the value of HOST_FOO_VAR would be obtained from the
corresponding FOO_VAR if HOST_FOO_VAR is not defined. In these cases, a test
is added to check for a host package (the only case where such constructions
are relevant; these are not circular).
Benefits of these changes are:
- behavior of variables is now again as expected. For example, setting
$(2)_VERSION = virtual in pkg-virtual.mk will effectively work, while
originally it would cause very odd results.
- The output of 'make printvars' is now much more useful. This target shows
the value of all variables, and the expression that led to that value.
However, if the expression was coming from an inner-xxx-targets block, and
was using single dollar signs, it would show in printvars as
VAR = value (value)
while if double dollar signs are used, it would effectively look like
VAR = value (actual expression)
as is intended.
This improvement is for example effective for FOO_DL_VERSION, FOO_RAWNAME,
FOO_SITE_METHOD and FOO_MAKE.
The correctness of this patch has been verified using 'make printvars',
'make manual' and 'make legal-info' before and after applying this patch,
and comparing the output.
Insight-provided-by: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-06-11 21:12:24 +02:00
|
|
|
$(2)_REDISTRIBUTE = $$($(3)_REDISTRIBUTE)
|
2012-11-02 10:25:41 +01:00
|
|
|
endif
|
|
|
|
|
endif
|
|
|
|
|
|
|
|
|
|
$(2)_REDISTRIBUTE ?= YES
|
|
|
|
|
|
core: rename FOO_BASE_NAME to FOO_BASENAME to avoid clashes
In current Buildroot, clashes occur between the variables _NAME and
_BASE_NAME for two packages called foo and foo-base, i.e.
Package foo:
FOO_NAME = foo
FOO_BASE_NAME = foo-1.2.3
Package foo-base:
FOO_BASE_NAME = foo-base
FOO_BASE_BASE_NAME = foo-base-4.5.6
where variable FOO_BASE_NAME is clashing between these two packages.
Specific cases where this clash is already existing are:
- alljoyn-base
- alljoyn-tcl-base
- perl-xml-sax-base
The problem is generic and can occur for a number of variables in Buildroot.
A non-exhaustive list:
<pkg>_BASE and <pkg>_BASE_NAME
<pkg>_BASE_NAME and <pkg>_RAW_BASE_NAME
<pkg>_DIR and <pkg>_DL_DIR
<pkg>_VERSION and <pkg>_DL_VERSION
<pkg>_SOURCE and <pkg>_TARGET_SOURCE
<pkg>_INSTALL_IMAGES and <pkg>_TARGET_INSTALL_IMAGES (same for _STAGING and _TARGET)
<pkg>_LICENSE_FILES and <pkg>_MANIFEST_LICENSE_FILES
<pkg>_DEPENDENCIES and <pkg>_FINAL_DEPENDENCIES
One solution is to use another separator than '_' to separate the
package name from the rest of the variable name. For example, a double
underscore:
FOO__NAME
FOO__BASE_NAME
FOO_BASE__NAME
FOO_BASE__BASE_NAME
However, making that change for only this case means that the variable
naming is no longer consistent. And making the change for all variables has
a large impact, also on certain user scripts.
For now, keep it simple, and rename FOO_BASE_NAME into FOO_BASENAME, so that
the variables become:
FOO_NAME
FOO_BASENAME
FOO_BASE_NAME
FOO_BASE_BASENAME
For consistency, also adapt FOO_RAW_BASE_NAME. Since FOO_RAW_BASENAME would
still pose a conflict with a package called 'foo-raw', take the opportunity
to rename it into FOO_BASENAME_RAW instead, which does not pose a conflict
as we have no variable called FOO_RAW.
Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Reviewed-by: Sam Voss <sam.voss@rockwellcollins.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2018-02-06 13:59:23 +01:00
|
|
|
$(2)_REDIST_SOURCES_DIR = $$(REDIST_SOURCES_DIR_$$(call UPPERCASE,$(4)))/$$($(2)_BASENAME_RAW)
|
2016-05-07 18:14:29 +02:00
|
|
|
|
2014-02-14 10:55:04 +01:00
|
|
|
# When a target package is a toolchain dependency set this variable to
|
|
|
|
|
# 'NO' so the 'toolchain' dependency is not added to prevent a circular
|
2017-07-18 19:25:28 +02:00
|
|
|
# dependency.
|
|
|
|
|
# Similarly for the skeleton.
|
2014-02-14 10:55:04 +01:00
|
|
|
$(2)_ADD_TOOLCHAIN_DEPENDENCY ?= YES
|
2017-07-18 19:25:28 +02:00
|
|
|
$(2)_ADD_SKELETON_DEPENDENCY ?= YES
|
|
|
|
|
|
2012-11-02 10:25:41 +01:00
|
|
|
|
2014-02-14 10:55:04 +01:00
|
|
|
ifeq ($(4),target)
|
2017-07-18 19:25:28 +02:00
|
|
|
ifeq ($$($(2)_ADD_SKELETON_DEPENDENCY),YES)
|
2015-07-14 13:36:25 +02:00
|
|
|
$(2)_DEPENDENCIES += skeleton
|
|
|
|
|
endif
|
2014-02-14 10:55:04 +01:00
|
|
|
ifeq ($$($(2)_ADD_TOOLCHAIN_DEPENDENCY),YES)
|
|
|
|
|
$(2)_DEPENDENCIES += toolchain
|
|
|
|
|
endif
|
|
|
|
|
endif
|
2012-01-16 14:58:35 +01:00
|
|
|
|
2018-03-24 15:20:00 +01:00
|
|
|
ifneq ($(1),host-skeleton)
|
|
|
|
|
$(2)_DEPENDENCIES += host-skeleton
|
|
|
|
|
endif
|
|
|
|
|
|
2018-03-24 15:20:07 +01:00
|
|
|
ifeq ($(filter host-tar host-skeleton host-fakedate,$(1)),)
|
2018-03-24 15:20:03 +01:00
|
|
|
$(2)_EXTRACT_DEPENDENCIES += $(BR2_TAR_HOST_DEPENDENCY)
|
|
|
|
|
endif
|
|
|
|
|
|
2018-03-24 15:20:07 +01:00
|
|
|
ifeq ($(filter host-tar host-skeleton host-xz host-lzip host-fakedate,$(1)),)
|
2018-03-24 15:20:04 +01:00
|
|
|
$(2)_EXTRACT_DEPENDENCIES += $(BR2_XZCAT_HOST_DEPENDENCY)
|
|
|
|
|
endif
|
|
|
|
|
|
2018-03-24 15:20:07 +01:00
|
|
|
ifeq ($(filter host-tar host-skeleton host-xz host-lzip host-fakedate,$(1)),)
|
package/pkg-generic: handle host-lzip as an extract dependency
This moves the host-lzip dependency handling from
DEPENDENCY_HOST_PREREQ to an extract dependency.
To achieve that, check-host-lzip.mk fills in the
BR2_LZIP_HOST_DEPENDENCY with host-lzip if building a host-lzip is
needed. The name BR2_LZIP_HOST_DEPENDENCY has been chosen because it
matches the name BR2_CMAKE_HOST_DEPENDENCY already used in
check-host-cmake.mk.
The BR2_LZIP_HOST_DEPENDENCY is added to all packages, except:
- host-lzip, because we would otherwise depend on ourself.
- host-tar, because lzip itself is delivered as a tarball, so we need
to have host-lzip depend on host-tar, and not host-tar depend on
host-lzip
- host-skeleton, because we need to have host-lzip depend on
host-skeleton, and not the opposite.
We also mutually exclude host-lzip and host-xz from dependending on
each other, to avoid a circular dependency.
In addition, we modify lzip.mk to explicitly build host-lzip without
ccache. We generally took the approach of building host-ccache *after*
all the extractors have been built.
[Peter: fix s/host-tar/host-lzip/ typo, fix s/xz/lzip/ typo]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2018-03-24 15:20:05 +01:00
|
|
|
$(2)_EXTRACT_DEPENDENCIES += $(BR2_LZIP_HOST_DEPENDENCY)
|
|
|
|
|
endif
|
|
|
|
|
|
2018-03-24 15:20:06 +01:00
|
|
|
ifeq ($(BR2_CCACHE),y)
|
2018-03-24 15:20:07 +01:00
|
|
|
ifeq ($(filter host-tar host-skeleton host-xz host-lzip host-fakedate host-ccache,$(1)),)
|
2018-03-24 15:20:06 +01:00
|
|
|
$(2)_DEPENDENCIES += host-ccache
|
|
|
|
|
endif
|
|
|
|
|
endif
|
|
|
|
|
|
2018-03-24 15:20:07 +01:00
|
|
|
ifeq ($(BR2_REPRODUCIBLE),y)
|
|
|
|
|
ifeq ($(filter host-skeleton host-fakedate,$(1)),)
|
|
|
|
|
$(2)_DEPENDENCIES += host-fakedate
|
|
|
|
|
endif
|
|
|
|
|
endif
|
|
|
|
|
|
2014-06-01 12:28:54 +02:00
|
|
|
# Eliminate duplicates in dependencies
|
|
|
|
|
$(2)_FINAL_DEPENDENCIES = $$(sort $$($(2)_DEPENDENCIES))
|
package/pkg-generic: add the concept of extract dependency
Extract dependencies are dependencies that must be ready before the
extract step of a package, i.e for tools that are needed to extract
packages themselves. Current examples of such tools are host-tar,
host-lzip and host-xz.
They are currently handled through DEPENDENCIES_HOST_PREREQ. However,
this mechanism has a number of drawbacks:
- First and foremost, because host-tar/host-lzip/host-xz are not
listed in the dependencies of packages, the package infrastructure
does not know it should rsync them in the context of per-package
SDK.
- Second, there is no dependency handling *between* them. I.e, we
have no mechanism that says host-tar should be built before
host-lzip, while it is in fact the case: if you need to build
host-lzip, you need to extract a tarball, so you may need host-tar
if your system tarball is not capable enough.
For those reasons, it makes sense to add explicit support for "extract
dependencies" in the package infrastructure, through the
<pkg>_EXTRACT_DEPENDENCIES variable. It is unlikely this variable will
ever be used by a package .mk file, but it will be used internally by
the package infrastructure.
[Peter: fix typo in manual]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Tested-by: Matt Weber <matthew.weber@rockwellcollins.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2018-03-24 15:20:02 +01:00
|
|
|
$(2)_FINAL_EXTRACT_DEPENDENCIES = $$(sort $$($(2)_EXTRACT_DEPENDENCIES))
|
2015-03-14 15:25:17 +01:00
|
|
|
$(2)_FINAL_PATCH_DEPENDENCIES = $$(sort $$($(2)_PATCH_DEPENDENCIES))
|
package/pkg-generic: add the concept of extract dependency
Extract dependencies are dependencies that must be ready before the
extract step of a package, i.e for tools that are needed to extract
packages themselves. Current examples of such tools are host-tar,
host-lzip and host-xz.
They are currently handled through DEPENDENCIES_HOST_PREREQ. However,
this mechanism has a number of drawbacks:
- First and foremost, because host-tar/host-lzip/host-xz are not
listed in the dependencies of packages, the package infrastructure
does not know it should rsync them in the context of per-package
SDK.
- Second, there is no dependency handling *between* them. I.e, we
have no mechanism that says host-tar should be built before
host-lzip, while it is in fact the case: if you need to build
host-lzip, you need to extract a tarball, so you may need host-tar
if your system tarball is not capable enough.
For those reasons, it makes sense to add explicit support for "extract
dependencies" in the package infrastructure, through the
<pkg>_EXTRACT_DEPENDENCIES variable. It is unlikely this variable will
ever be used by a package .mk file, but it will be used internally by
the package infrastructure.
[Peter: fix typo in manual]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Tested-by: Matt Weber <matthew.weber@rockwellcollins.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2018-03-24 15:20:02 +01:00
|
|
|
$(2)_FINAL_ALL_DEPENDENCIES = \
|
|
|
|
|
$$(sort \
|
|
|
|
|
$$($(2)_FINAL_DEPENDENCIES) \
|
|
|
|
|
$$($(2)_FINAL_EXTRACT_DEPENDENCIES) \
|
|
|
|
|
$$($(2)_FINAL_PATCH_DEPENDENCIES))
|
2014-06-01 12:28:54 +02:00
|
|
|
|
2009-11-08 18:37:36 +01:00
|
|
|
$(2)_INSTALL_STAGING ?= NO
|
2011-07-05 21:53:56 +02:00
|
|
|
$(2)_INSTALL_IMAGES ?= NO
|
2009-11-08 18:37:36 +01:00
|
|
|
$(2)_INSTALL_TARGET ?= YES
|
|
|
|
|
|
|
|
|
|
# define sub-target stamps
|
|
|
|
|
$(2)_TARGET_INSTALL_TARGET = $$($(2)_DIR)/.stamp_target_installed
|
|
|
|
|
$(2)_TARGET_INSTALL_STAGING = $$($(2)_DIR)/.stamp_staging_installed
|
2011-07-05 21:53:56 +02:00
|
|
|
$(2)_TARGET_INSTALL_IMAGES = $$($(2)_DIR)/.stamp_images_installed
|
2009-11-08 18:37:36 +01:00
|
|
|
$(2)_TARGET_INSTALL_HOST = $$($(2)_DIR)/.stamp_host_installed
|
|
|
|
|
$(2)_TARGET_BUILD = $$($(2)_DIR)/.stamp_built
|
|
|
|
|
$(2)_TARGET_CONFIGURE = $$($(2)_DIR)/.stamp_configured
|
2011-09-29 21:57:37 +02:00
|
|
|
$(2)_TARGET_RSYNC = $$($(2)_DIR)/.stamp_rsynced
|
2009-11-08 18:37:36 +01:00
|
|
|
$(2)_TARGET_PATCH = $$($(2)_DIR)/.stamp_patched
|
|
|
|
|
$(2)_TARGET_EXTRACT = $$($(2)_DIR)/.stamp_extracted
|
2010-09-02 12:59:26 +02:00
|
|
|
$(2)_TARGET_SOURCE = $$($(2)_DIR)/.stamp_downloaded
|
core/legal-info: ensure legal-info works in off-line mode
Almost all packages which are saved for legal-info have their source
archives downloaded as part of 'make source', which makes an off-line
build completely possible [0].
However, for the pre-configured external toolchains, the source tarball
is different, as the main tarball is a binary package. And that source
tarball is only downloaded during the legal-info phase, which makes it
inconvenient for full off-line builds.
We fix that by adding a new rule, $(1)-legal-source which only
$(1)-all-source depends on, so that we only download it for a top-level
'make source', not as part of the standard download mechanism (i.e. only
what is really needed to build).
This new rule depends, like the normal download mechanism, on a stamp
file, so that we do not emit a spurious hash-check message on successive
runs of 'make source'.
This way, we can do a complete [0] off-line build and are still able to
generate legal-info, while at the same time we do not incur any download
overhead during a simple build.
Also, we previously downloaded the _ACTUAL_SOURCE_TARBALL when it was
not empty. However, since _ACTUAL_SOURCE_TARBALL defaults to the value
of _SOURCE, it can not be empty when _SOURCE is not. Thus, we'd get a
spurious report of a missing hash for the tarball, since it was not in
a standard package rule (configure, build, install..) and thus would
miss the PKG and PKGDIR variables to find the .hash file.
We fix that in this commit as well, by:
- setting PKG and PKGDIR just for the -legal-source rule;
- only downloading _ACTUAL_SOURCE_TARBALL if it is not empty *and* not
the same as _SOURCE (to avoid a second report about the hash).
[0] Save for nodejs which invarriably wants to download stuff at build
time. Sigh... :-( Fixing that is work for another time...
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Peter Korsgaard <jacmet@uclibc.org>
Tested-by: Luca Ceresoli <luca@lucaceresoli.net>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2016-05-07 18:14:38 +02:00
|
|
|
$(2)_TARGET_ACTUAL_SOURCE = $$($(2)_DIR)/.stamp_actual_downloaded
|
2009-11-08 18:37:36 +01:00
|
|
|
$(2)_TARGET_DIRCLEAN = $$($(2)_DIR)/.stamp_dircleaned
|
|
|
|
|
|
2011-07-05 21:53:52 +02:00
|
|
|
# default extract command
|
2011-07-05 21:53:53 +02:00
|
|
|
$(2)_EXTRACT_CMDS ?= \
|
2018-04-02 15:09:26 +02:00
|
|
|
$$(if $$($(2)_SOURCE),$$(INFLATE$$(suffix $$($(2)_SOURCE))) $$($(2)_DL_DIR)/$$($(2)_SOURCE) | \
|
2015-10-24 14:48:53 +02:00
|
|
|
$$(TAR) --strip-components=$$($(2)_STRIP_COMPONENTS) \
|
|
|
|
|
-C $$($(2)_DIR) \
|
|
|
|
|
$$(foreach x,$$($(2)_EXCLUDES),--exclude='$$(x)' ) \
|
|
|
|
|
$$(TAR_OPTIONS) -)
|
2011-07-05 21:53:52 +02:00
|
|
|
|
2014-05-05 15:04:20 +02:00
|
|
|
# pre/post-steps hooks
|
|
|
|
|
$(2)_PRE_DOWNLOAD_HOOKS ?=
|
2011-07-05 21:54:11 +02:00
|
|
|
$(2)_POST_DOWNLOAD_HOOKS ?=
|
2014-05-05 15:04:20 +02:00
|
|
|
$(2)_PRE_EXTRACT_HOOKS ?=
|
2009-11-08 18:37:36 +01:00
|
|
|
$(2)_POST_EXTRACT_HOOKS ?=
|
2014-05-05 15:04:20 +02:00
|
|
|
$(2)_PRE_RSYNC_HOOKS ?=
|
2013-11-07 11:41:21 +01:00
|
|
|
$(2)_POST_RSYNC_HOOKS ?=
|
2011-09-19 22:10:52 +02:00
|
|
|
$(2)_PRE_PATCH_HOOKS ?=
|
2009-11-08 18:37:36 +01:00
|
|
|
$(2)_POST_PATCH_HOOKS ?=
|
2010-11-04 03:50:24 +01:00
|
|
|
$(2)_PRE_CONFIGURE_HOOKS ?=
|
2009-11-08 18:37:36 +01:00
|
|
|
$(2)_POST_CONFIGURE_HOOKS ?=
|
2014-05-05 15:04:20 +02:00
|
|
|
$(2)_PRE_BUILD_HOOKS ?=
|
2009-11-08 18:37:36 +01:00
|
|
|
$(2)_POST_BUILD_HOOKS ?=
|
2014-05-05 15:04:20 +02:00
|
|
|
$(2)_PRE_INSTALL_HOOKS ?=
|
2009-11-08 18:37:36 +01:00
|
|
|
$(2)_POST_INSTALL_HOOKS ?=
|
2014-05-05 15:04:20 +02:00
|
|
|
$(2)_PRE_INSTALL_STAGING_HOOKS ?=
|
2009-11-08 18:37:36 +01:00
|
|
|
$(2)_POST_INSTALL_STAGING_HOOKS ?=
|
2014-05-05 15:04:20 +02:00
|
|
|
$(2)_PRE_INSTALL_TARGET_HOOKS ?=
|
2009-11-08 18:37:36 +01:00
|
|
|
$(2)_POST_INSTALL_TARGET_HOOKS ?=
|
2014-05-05 15:04:20 +02:00
|
|
|
$(2)_PRE_INSTALL_IMAGES_HOOKS ?=
|
2011-07-05 21:53:56 +02:00
|
|
|
$(2)_POST_INSTALL_IMAGES_HOOKS ?=
|
2014-05-05 15:04:20 +02:00
|
|
|
$(2)_PRE_LEGAL_INFO_HOOKS ?=
|
2012-11-03 07:52:16 +01:00
|
|
|
$(2)_POST_LEGAL_INFO_HOOKS ?=
|
2016-06-22 21:07:36 +02:00
|
|
|
$(2)_TARGET_FINALIZE_HOOKS ?=
|
fs: add pre- and post-command hooks
In some cases, the directory structure we want in the filesystem is not
exactly what we have in target/
For example, when systemd is used on a read-only rootfs, /var must be a
tmpfs. However, we may have packages that install stuff in there, and
set important rights (via the permission-table). So, at build time, we
need /var to be a symlink to the remanent location (/usr/share/factory)
while at runtime we need /var to be a directory.
One option would have been to have /var as a real directory even during
build time, and in a target-finalize hook, move everything out of there
and into the "factory" location. However, that's not possible because
it's too early: some packages may want to set ownership and/or acces
rights on directories or files in /var, and this is only done in the
fakeroot script, which is called only later during the assembling of the
filesystem images.
Also, there would have been no way to undo the tweak (i.e. we need to
restore the /var symlink so that subsequent builds continue to work) if
it were done as a target-finalize hook.
The only solution is to allow packages to register pre- and post-hooks
that are called right before and right after the rootfs commands are
executed, and inside in the fakeroot script.
We can however not re-use the BR2_ROOTFS_POST_FAKEROOT_SCRIPT feature
either because it is done before the filesystem command, but there is
nothing that is done after. Also, we don't want to add to, and modify a
user-supplied variable.
So, we introduce two new variables that packages can set to add the
commands they need to run to tweak the filesystem right at the last
moment.
Those hooks are not documented on-purpose; they are probably going to
only ever be used by systemd.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Reviewed-by: Romain Naour <romain.naour@gmail.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2017-08-02 00:52:22 +02:00
|
|
|
$(2)_ROOTFS_PRE_CMD_HOOKS ?=
|
2009-11-08 18:37:36 +01:00
|
|
|
|
2018-04-29 14:15:22 +02:00
|
|
|
ifeq ($$($(2)_TYPE),target)
|
|
|
|
|
ifneq ($$(HOST_$(2)_KCONFIG_VAR),)
|
|
|
|
|
$$(error "Package $(1) defines host variant before target variant!")
|
|
|
|
|
endif
|
|
|
|
|
endif
|
|
|
|
|
|
2009-11-08 18:37:36 +01:00
|
|
|
# human-friendly targets and target sequencing
|
|
|
|
|
$(1): $(1)-install
|
|
|
|
|
|
|
|
|
|
ifeq ($$($(2)_TYPE),host)
|
2010-09-02 00:20:28 +02:00
|
|
|
$(1)-install: $(1)-install-host
|
2009-11-08 18:37:36 +01:00
|
|
|
else
|
2011-07-05 21:53:56 +02:00
|
|
|
$(1)-install: $(1)-install-staging $(1)-install-target $(1)-install-images
|
2009-11-08 18:37:36 +01:00
|
|
|
endif
|
|
|
|
|
|
|
|
|
|
ifeq ($$($(2)_INSTALL_TARGET),YES)
|
2014-02-14 10:55:05 +01:00
|
|
|
$(1)-install-target: $$($(2)_TARGET_INSTALL_TARGET)
|
|
|
|
|
$$($(2)_TARGET_INSTALL_TARGET): $$($(2)_TARGET_BUILD)
|
2009-11-08 18:37:36 +01:00
|
|
|
else
|
|
|
|
|
$(1)-install-target:
|
|
|
|
|
endif
|
|
|
|
|
|
|
|
|
|
ifeq ($$($(2)_INSTALL_STAGING),YES)
|
2014-02-14 10:55:05 +01:00
|
|
|
$(1)-install-staging: $$($(2)_TARGET_INSTALL_STAGING)
|
|
|
|
|
$$($(2)_TARGET_INSTALL_STAGING): $$($(2)_TARGET_BUILD)
|
|
|
|
|
# Some packages use install-staging stuff for install-target
|
|
|
|
|
$$($(2)_TARGET_INSTALL_TARGET): $$($(2)_TARGET_INSTALL_STAGING)
|
2009-11-08 18:37:36 +01:00
|
|
|
else
|
|
|
|
|
$(1)-install-staging:
|
|
|
|
|
endif
|
|
|
|
|
|
2011-07-05 21:53:56 +02:00
|
|
|
ifeq ($$($(2)_INSTALL_IMAGES),YES)
|
2014-02-14 10:55:05 +01:00
|
|
|
$(1)-install-images: $$($(2)_TARGET_INSTALL_IMAGES)
|
|
|
|
|
$$($(2)_TARGET_INSTALL_IMAGES): $$($(2)_TARGET_BUILD)
|
2011-07-05 21:53:56 +02:00
|
|
|
else
|
|
|
|
|
$(1)-install-images:
|
|
|
|
|
endif
|
|
|
|
|
|
2017-03-26 17:05:43 +02:00
|
|
|
$(1)-install-host: $$($(2)_TARGET_INSTALL_HOST)
|
2014-02-14 10:55:05 +01:00
|
|
|
$$($(2)_TARGET_INSTALL_HOST): $$($(2)_TARGET_BUILD)
|
2009-11-08 18:37:36 +01:00
|
|
|
|
2014-02-14 10:55:05 +01:00
|
|
|
$(1)-build: $$($(2)_TARGET_BUILD)
|
|
|
|
|
$$($(2)_TARGET_BUILD): $$($(2)_TARGET_CONFIGURE)
|
|
|
|
|
|
2014-06-01 12:28:54 +02:00
|
|
|
# Since $(2)_FINAL_DEPENDENCIES are phony targets, they are always "newer"
|
2014-02-14 10:55:05 +01:00
|
|
|
# than $(2)_TARGET_CONFIGURE. This would force the configure step (and
|
|
|
|
|
# therefore the other steps as well) to be re-executed with every
|
2014-06-01 12:28:54 +02:00
|
|
|
# invocation of make. Therefore, make $(2)_FINAL_DEPENDENCIES an order-only
|
2014-02-14 10:55:05 +01:00
|
|
|
# dependency by using |.
|
2009-11-08 18:37:36 +01:00
|
|
|
|
2014-02-14 10:55:05 +01:00
|
|
|
$(1)-configure: $$($(2)_TARGET_CONFIGURE)
|
2014-06-01 12:28:54 +02:00
|
|
|
$$($(2)_TARGET_CONFIGURE): | $$($(2)_FINAL_DEPENDENCIES)
|
2009-11-08 18:37:36 +01:00
|
|
|
|
2014-02-14 10:55:03 +01:00
|
|
|
$$($(2)_TARGET_SOURCE) $$($(2)_TARGET_RSYNC): | dirs prepare
|
|
|
|
|
$$($(2)_TARGET_SOURCE) $$($(2)_TARGET_RSYNC): | dependencies
|
2009-11-08 18:37:36 +01:00
|
|
|
|
2011-09-29 21:57:37 +02:00
|
|
|
ifeq ($$($(2)_OVERRIDE_SRCDIR),)
|
|
|
|
|
# In the normal case (no package override), the sequence of steps is
|
|
|
|
|
# source, by downloading
|
|
|
|
|
# depends
|
|
|
|
|
# extract
|
|
|
|
|
# patch
|
|
|
|
|
# configure
|
2014-02-14 10:55:05 +01:00
|
|
|
$$($(2)_TARGET_CONFIGURE): $$($(2)_TARGET_PATCH)
|
2009-11-08 18:37:36 +01:00
|
|
|
|
2014-02-14 10:55:05 +01:00
|
|
|
$(1)-patch: $$($(2)_TARGET_PATCH)
|
|
|
|
|
$$($(2)_TARGET_PATCH): $$($(2)_TARGET_EXTRACT)
|
2015-03-14 15:25:17 +01:00
|
|
|
# Order-only dependency
|
|
|
|
|
$$($(2)_TARGET_PATCH): | $$(patsubst %,%-patch,$$($(2)_FINAL_PATCH_DEPENDENCIES))
|
2009-11-08 18:37:36 +01:00
|
|
|
|
2014-02-14 10:55:05 +01:00
|
|
|
$(1)-extract: $$($(2)_TARGET_EXTRACT)
|
|
|
|
|
$$($(2)_TARGET_EXTRACT): $$($(2)_TARGET_SOURCE)
|
package/pkg-generic: add the concept of extract dependency
Extract dependencies are dependencies that must be ready before the
extract step of a package, i.e for tools that are needed to extract
packages themselves. Current examples of such tools are host-tar,
host-lzip and host-xz.
They are currently handled through DEPENDENCIES_HOST_PREREQ. However,
this mechanism has a number of drawbacks:
- First and foremost, because host-tar/host-lzip/host-xz are not
listed in the dependencies of packages, the package infrastructure
does not know it should rsync them in the context of per-package
SDK.
- Second, there is no dependency handling *between* them. I.e, we
have no mechanism that says host-tar should be built before
host-lzip, while it is in fact the case: if you need to build
host-lzip, you need to extract a tarball, so you may need host-tar
if your system tarball is not capable enough.
For those reasons, it makes sense to add explicit support for "extract
dependencies" in the package infrastructure, through the
<pkg>_EXTRACT_DEPENDENCIES variable. It is unlikely this variable will
ever be used by a package .mk file, but it will be used internally by
the package infrastructure.
[Peter: fix typo in manual]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Tested-by: Matt Weber <matthew.weber@rockwellcollins.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2018-03-24 15:20:02 +01:00
|
|
|
$$($(2)_TARGET_EXTRACT): | $$($(2)_FINAL_EXTRACT_DEPENDENCIES)
|
2009-11-08 18:37:36 +01:00
|
|
|
|
2014-06-01 12:28:54 +02:00
|
|
|
$(1)-depends: $$($(2)_FINAL_DEPENDENCIES)
|
2010-05-06 10:05:43 +02:00
|
|
|
|
2011-09-29 21:57:37 +02:00
|
|
|
$(1)-source: $$($(2)_TARGET_SOURCE)
|
2015-03-29 19:33:24 +02:00
|
|
|
|
core/legal-info: ensure legal-info works in off-line mode
Almost all packages which are saved for legal-info have their source
archives downloaded as part of 'make source', which makes an off-line
build completely possible [0].
However, for the pre-configured external toolchains, the source tarball
is different, as the main tarball is a binary package. And that source
tarball is only downloaded during the legal-info phase, which makes it
inconvenient for full off-line builds.
We fix that by adding a new rule, $(1)-legal-source which only
$(1)-all-source depends on, so that we only download it for a top-level
'make source', not as part of the standard download mechanism (i.e. only
what is really needed to build).
This new rule depends, like the normal download mechanism, on a stamp
file, so that we do not emit a spurious hash-check message on successive
runs of 'make source'.
This way, we can do a complete [0] off-line build and are still able to
generate legal-info, while at the same time we do not incur any download
overhead during a simple build.
Also, we previously downloaded the _ACTUAL_SOURCE_TARBALL when it was
not empty. However, since _ACTUAL_SOURCE_TARBALL defaults to the value
of _SOURCE, it can not be empty when _SOURCE is not. Thus, we'd get a
spurious report of a missing hash for the tarball, since it was not in
a standard package rule (configure, build, install..) and thus would
miss the PKG and PKGDIR variables to find the .hash file.
We fix that in this commit as well, by:
- setting PKG and PKGDIR just for the -legal-source rule;
- only downloading _ACTUAL_SOURCE_TARBALL if it is not empty *and* not
the same as _SOURCE (to avoid a second report about the hash).
[0] Save for nodejs which invarriably wants to download stuff at build
time. Sigh... :-( Fixing that is work for another time...
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Peter Korsgaard <jacmet@uclibc.org>
Tested-by: Luca Ceresoli <luca@lucaceresoli.net>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2016-05-07 18:14:38 +02:00
|
|
|
$(1)-all-source: $(1)-legal-source
|
|
|
|
|
$(1)-legal-info: $(1)-legal-source
|
|
|
|
|
$(1)-legal-source: $(1)-source
|
|
|
|
|
|
|
|
|
|
# Only download the actual source if it differs from the 'main' archive
|
|
|
|
|
ifneq ($$($(2)_ACTUAL_SOURCE_TARBALL),)
|
|
|
|
|
ifneq ($$($(2)_ACTUAL_SOURCE_TARBALL),$$($(2)_SOURCE))
|
|
|
|
|
$(1)-legal-source: $$($(2)_TARGET_ACTUAL_SOURCE)
|
|
|
|
|
endif # actual sources != sources
|
|
|
|
|
endif # actual sources != ""
|
|
|
|
|
|
2015-03-29 19:33:24 +02:00
|
|
|
$(1)-external-deps:
|
|
|
|
|
@for p in $$($(2)_SOURCE) $$($(2)_PATCH) $$($(2)_EXTRA_DOWNLOADS) ; do \
|
|
|
|
|
echo `basename $$$$p` ; \
|
|
|
|
|
done
|
2011-09-29 21:57:37 +02:00
|
|
|
else
|
|
|
|
|
# In the package override case, the sequence of steps
|
|
|
|
|
# source, by rsyncing
|
|
|
|
|
# depends
|
|
|
|
|
# configure
|
2014-06-30 11:51:28 +02:00
|
|
|
|
|
|
|
|
# Use an order-only dependency so the "<pkg>-clean-for-rebuild" rule
|
|
|
|
|
# can remove the stamp file without triggering the configure step.
|
|
|
|
|
$$($(2)_TARGET_CONFIGURE): | $$($(2)_TARGET_RSYNC)
|
2011-09-29 21:57:37 +02:00
|
|
|
|
2014-06-01 12:28:54 +02:00
|
|
|
$(1)-depends: $$($(2)_FINAL_DEPENDENCIES)
|
2011-09-29 21:57:37 +02:00
|
|
|
|
2012-12-06 14:16:00 +01:00
|
|
|
$(1)-patch: $(1)-rsync
|
|
|
|
|
$(1)-extract: $(1)-rsync
|
|
|
|
|
|
2011-09-29 21:57:37 +02:00
|
|
|
$(1)-rsync: $$($(2)_TARGET_RSYNC)
|
|
|
|
|
|
2015-04-26 11:51:07 +02:00
|
|
|
$(1)-source:
|
core/legal-info: ensure legal-info works in off-line mode
Almost all packages which are saved for legal-info have their source
archives downloaded as part of 'make source', which makes an off-line
build completely possible [0].
However, for the pre-configured external toolchains, the source tarball
is different, as the main tarball is a binary package. And that source
tarball is only downloaded during the legal-info phase, which makes it
inconvenient for full off-line builds.
We fix that by adding a new rule, $(1)-legal-source which only
$(1)-all-source depends on, so that we only download it for a top-level
'make source', not as part of the standard download mechanism (i.e. only
what is really needed to build).
This new rule depends, like the normal download mechanism, on a stamp
file, so that we do not emit a spurious hash-check message on successive
runs of 'make source'.
This way, we can do a complete [0] off-line build and are still able to
generate legal-info, while at the same time we do not incur any download
overhead during a simple build.
Also, we previously downloaded the _ACTUAL_SOURCE_TARBALL when it was
not empty. However, since _ACTUAL_SOURCE_TARBALL defaults to the value
of _SOURCE, it can not be empty when _SOURCE is not. Thus, we'd get a
spurious report of a missing hash for the tarball, since it was not in
a standard package rule (configure, build, install..) and thus would
miss the PKG and PKGDIR variables to find the .hash file.
We fix that in this commit as well, by:
- setting PKG and PKGDIR just for the -legal-source rule;
- only downloading _ACTUAL_SOURCE_TARBALL if it is not empty *and* not
the same as _SOURCE (to avoid a second report about the hash).
[0] Save for nodejs which invarriably wants to download stuff at build
time. Sigh... :-( Fixing that is work for another time...
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Peter Korsgaard <jacmet@uclibc.org>
Tested-by: Luca Ceresoli <luca@lucaceresoli.net>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2016-05-07 18:14:38 +02:00
|
|
|
$(1)-legal-source:
|
2015-03-29 19:33:24 +02:00
|
|
|
|
|
|
|
|
$(1)-external-deps:
|
|
|
|
|
@echo "file://$$($(2)_OVERRIDE_SRCDIR)"
|
2011-09-29 21:57:37 +02:00
|
|
|
endif
|
|
|
|
|
|
2015-01-03 15:29:12 +01:00
|
|
|
$(1)-show-version:
|
|
|
|
|
@echo $$($(2)_VERSION)
|
|
|
|
|
|
2010-05-06 10:05:43 +02:00
|
|
|
$(1)-show-depends:
|
2015-04-26 11:51:00 +02:00
|
|
|
@echo $$($(2)_FINAL_ALL_DEPENDENCIES)
|
2009-11-08 18:37:36 +01:00
|
|
|
|
2018-03-31 18:35:43 +02:00
|
|
|
$(1)-show-recursive-depends:
|
|
|
|
|
@cd "$$(CONFIG_DIR)" && \
|
|
|
|
|
$$(TOPDIR)/support/scripts/graph-depends -p $(1) -f -q
|
|
|
|
|
|
2016-10-23 17:28:51 +02:00
|
|
|
$(1)-show-rdepends:
|
|
|
|
|
@echo $$($(2)_RDEPENDENCIES)
|
|
|
|
|
|
2018-03-31 18:35:43 +02:00
|
|
|
$(1)-show-recursive-rdepends:
|
|
|
|
|
@cd "$$(CONFIG_DIR)" && \
|
|
|
|
|
$$(TOPDIR)/support/scripts/graph-depends -p $(1) --reverse -f -q
|
|
|
|
|
|
2017-04-02 15:03:38 +02:00
|
|
|
$(1)-show-build-order: $$(patsubst %,%-show-build-order,$$($(2)_FINAL_ALL_DEPENDENCIES))
|
|
|
|
|
$$(info $(1))
|
|
|
|
|
|
2014-06-17 11:33:54 +02:00
|
|
|
$(1)-graph-depends: graph-depends-requirements
|
2016-10-23 19:19:44 +02:00
|
|
|
$(call pkg-graph-depends,$(1),--direct)
|
|
|
|
|
|
|
|
|
|
$(1)-graph-rdepends: graph-depends-requirements
|
|
|
|
|
$(call pkg-graph-depends,$(1),--reverse)
|
2013-12-28 18:39:12 +01:00
|
|
|
|
2015-04-26 11:51:00 +02:00
|
|
|
$(1)-all-source: $(1)-source
|
|
|
|
|
$(1)-all-source: $$(foreach p,$$($(2)_FINAL_ALL_DEPENDENCIES),$$(p)-all-source)
|
2015-03-29 19:33:25 +02:00
|
|
|
|
2015-04-26 11:51:00 +02:00
|
|
|
$(1)-all-external-deps: $(1)-external-deps
|
|
|
|
|
$(1)-all-external-deps: $$(foreach p,$$($(2)_FINAL_ALL_DEPENDENCIES),$$(p)-all-external-deps)
|
2015-03-29 19:33:25 +02:00
|
|
|
|
2015-04-26 11:51:00 +02:00
|
|
|
$(1)-all-legal-info: $(1)-legal-info
|
|
|
|
|
$(1)-all-legal-info: $$(foreach p,$$($(2)_FINAL_ALL_DEPENDENCIES),$$(p)-all-legal-info)
|
2015-03-29 19:33:25 +02:00
|
|
|
|
2009-11-08 18:37:36 +01:00
|
|
|
$(1)-dirclean: $$($(2)_TARGET_DIRCLEAN)
|
|
|
|
|
|
2014-11-28 16:25:04 +01:00
|
|
|
$(1)-clean-for-reinstall:
|
2011-09-29 21:57:39 +02:00
|
|
|
ifneq ($$($(2)_OVERRIDE_SRCDIR),)
|
|
|
|
|
rm -f $$($(2)_TARGET_RSYNC)
|
|
|
|
|
endif
|
|
|
|
|
rm -f $$($(2)_TARGET_INSTALL_STAGING)
|
|
|
|
|
rm -f $$($(2)_TARGET_INSTALL_TARGET)
|
2011-11-15 18:31:17 +01:00
|
|
|
rm -f $$($(2)_TARGET_INSTALL_IMAGES)
|
2011-09-29 21:57:39 +02:00
|
|
|
rm -f $$($(2)_TARGET_INSTALL_HOST)
|
|
|
|
|
|
2014-11-28 16:25:04 +01:00
|
|
|
$(1)-reinstall: $(1)-clean-for-reinstall $(1)
|
|
|
|
|
|
|
|
|
|
$(1)-clean-for-rebuild: $(1)-clean-for-reinstall
|
|
|
|
|
rm -f $$($(2)_TARGET_BUILD)
|
|
|
|
|
|
2013-05-13 17:25:41 +02:00
|
|
|
$(1)-rebuild: $(1)-clean-for-rebuild $(1)
|
2011-09-29 21:57:39 +02:00
|
|
|
|
|
|
|
|
$(1)-clean-for-reconfigure: $(1)-clean-for-rebuild
|
|
|
|
|
rm -f $$($(2)_TARGET_CONFIGURE)
|
|
|
|
|
|
2013-05-13 17:25:41 +02:00
|
|
|
$(1)-reconfigure: $(1)-clean-for-reconfigure $(1)
|
2011-09-29 21:57:39 +02:00
|
|
|
|
2009-11-08 18:37:36 +01:00
|
|
|
# define the PKG variable for all targets, containing the
|
|
|
|
|
# uppercase package variable prefix
|
|
|
|
|
$$($(2)_TARGET_INSTALL_TARGET): PKG=$(2)
|
|
|
|
|
$$($(2)_TARGET_INSTALL_STAGING): PKG=$(2)
|
2011-07-05 21:53:56 +02:00
|
|
|
$$($(2)_TARGET_INSTALL_IMAGES): PKG=$(2)
|
2015-09-27 13:34:50 +02:00
|
|
|
$$($(2)_TARGET_INSTALL_HOST): PKG=$(2)
|
2009-11-08 18:37:36 +01:00
|
|
|
$$($(2)_TARGET_BUILD): PKG=$(2)
|
|
|
|
|
$$($(2)_TARGET_CONFIGURE): PKG=$(2)
|
2015-09-27 13:34:50 +02:00
|
|
|
$$($(2)_TARGET_RSYNC): SRCDIR=$$($(2)_OVERRIDE_SRCDIR)
|
|
|
|
|
$$($(2)_TARGET_RSYNC): PKG=$(2)
|
2009-11-08 18:37:36 +01:00
|
|
|
$$($(2)_TARGET_PATCH): PKG=$(2)
|
infra: consistently use double dollar signs inside inner-xxx-targets
The inner-xxx-targets in the buildroot package infrastructures are
evaluated using $(eval) which causes variable references to be a bit
different than in regular make code. As we want most references to be
expanded only at the time of the $(eval) we should not use standard
references $(VAR) but rather use double dollar signs $$(VAR). This includes
function references like $(call), $(subst), etc. The only exception is the
reference to pkgdir/pkgname and numbered variables, which are parameters to
the inner block: $(1), $(2), etc.
This patch introduces consistent usage of double-dollar signs throughout the
different inner-xxx-targets blocks.
In some cases, this would potentially cause circular references, in
particular when the value of HOST_FOO_VAR would be obtained from the
corresponding FOO_VAR if HOST_FOO_VAR is not defined. In these cases, a test
is added to check for a host package (the only case where such constructions
are relevant; these are not circular).
Benefits of these changes are:
- behavior of variables is now again as expected. For example, setting
$(2)_VERSION = virtual in pkg-virtual.mk will effectively work, while
originally it would cause very odd results.
- The output of 'make printvars' is now much more useful. This target shows
the value of all variables, and the expression that led to that value.
However, if the expression was coming from an inner-xxx-targets block, and
was using single dollar signs, it would show in printvars as
VAR = value (value)
while if double dollar signs are used, it would effectively look like
VAR = value (actual expression)
as is intended.
This improvement is for example effective for FOO_DL_VERSION, FOO_RAWNAME,
FOO_SITE_METHOD and FOO_MAKE.
The correctness of this patch has been verified using 'make printvars',
'make manual' and 'make legal-info' before and after applying this patch,
and comparing the output.
Insight-provided-by: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-06-11 21:12:24 +02:00
|
|
|
$$($(2)_TARGET_PATCH): RAWNAME=$$(patsubst host-%,%,$(1))
|
2014-02-05 10:44:01 +01:00
|
|
|
$$($(2)_TARGET_PATCH): PKGDIR=$(pkgdir)
|
2009-11-08 18:37:36 +01:00
|
|
|
$$($(2)_TARGET_EXTRACT): PKG=$(2)
|
|
|
|
|
$$($(2)_TARGET_SOURCE): PKG=$(2)
|
2014-07-01 00:26:20 +02:00
|
|
|
$$($(2)_TARGET_SOURCE): PKGDIR=$(pkgdir)
|
core/legal-info: ensure legal-info works in off-line mode
Almost all packages which are saved for legal-info have their source
archives downloaded as part of 'make source', which makes an off-line
build completely possible [0].
However, for the pre-configured external toolchains, the source tarball
is different, as the main tarball is a binary package. And that source
tarball is only downloaded during the legal-info phase, which makes it
inconvenient for full off-line builds.
We fix that by adding a new rule, $(1)-legal-source which only
$(1)-all-source depends on, so that we only download it for a top-level
'make source', not as part of the standard download mechanism (i.e. only
what is really needed to build).
This new rule depends, like the normal download mechanism, on a stamp
file, so that we do not emit a spurious hash-check message on successive
runs of 'make source'.
This way, we can do a complete [0] off-line build and are still able to
generate legal-info, while at the same time we do not incur any download
overhead during a simple build.
Also, we previously downloaded the _ACTUAL_SOURCE_TARBALL when it was
not empty. However, since _ACTUAL_SOURCE_TARBALL defaults to the value
of _SOURCE, it can not be empty when _SOURCE is not. Thus, we'd get a
spurious report of a missing hash for the tarball, since it was not in
a standard package rule (configure, build, install..) and thus would
miss the PKG and PKGDIR variables to find the .hash file.
We fix that in this commit as well, by:
- setting PKG and PKGDIR just for the -legal-source rule;
- only downloading _ACTUAL_SOURCE_TARBALL if it is not empty *and* not
the same as _SOURCE (to avoid a second report about the hash).
[0] Save for nodejs which invarriably wants to download stuff at build
time. Sigh... :-( Fixing that is work for another time...
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Peter Korsgaard <jacmet@uclibc.org>
Tested-by: Luca Ceresoli <luca@lucaceresoli.net>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2016-05-07 18:14:38 +02:00
|
|
|
$$($(2)_TARGET_ACTUAL_SOURCE): PKG=$(2)
|
|
|
|
|
$$($(2)_TARGET_ACTUAL_SOURCE): PKGDIR=$(pkgdir)
|
2009-11-08 18:37:36 +01:00
|
|
|
$$($(2)_TARGET_DIRCLEAN): PKG=$(2)
|
|
|
|
|
|
2011-07-11 22:46:10 +02:00
|
|
|
# Compute the name of the Kconfig option that correspond to the
|
|
|
|
|
# package being enabled. We handle three cases: the special Linux
|
|
|
|
|
# kernel case, the bootloaders case, and the normal packages case.
|
|
|
|
|
ifeq ($(1),linux)
|
|
|
|
|
$(2)_KCONFIG_VAR = BR2_LINUX_KERNEL
|
core: add support for multiple br2-external trees
Currently, we only support at most one br2-external tree. Being able
to use more than one br2-external tree can be very useful.
A use-case would be for having a br2-external to contain the basic
packages, basic board defconfigs and board files, provided by one team
responsible for the "board-bringup", while other teams consume that
br2-external as a base, and complements it each with their own set of
packages, defconfigs and extra board files.
Another use-case would be for third-parties to provide their own
Buildroot packaging in a br2-external tree, along-side the archives for
their stuff.
Finally, another use-case is to be able to add FLOSS packages in a
br2-external tree, and proprietary packages in another. This allows
to not touch the Buildroot tree at all, and still be able to get in
compliance by providing only that br2-external tree(s) that contains
FLOSS packages, leaving aside the br2-external tree(s) with the
proprietary bits.
What we do is to treat BR2_EXTERNAL as a colon-separated (space-
separated also work, and we use that internally) list of paths, on which
we iterate to construct:
- the list of all br2-external names, BR2_EXTERNAL_NAMES,
- the per-br2-external tree BR2_EXTERNAL_$(NAME) variables, which
point each to the actual location of the corresponding tree,
- the list of paths to all the external.mk files, BR2_EXTERNAL_MKS,
- the space-separated list of absolute paths to the external trees,
BR2_EXTERNAL_DIRS.
Once we have all those variables, we replace references to BR2_EXTERNAL
with either one of those.
This cascades into how we display the list of defconfigs, so that it is
easy to see what br2-external tree provides what defconfigs. As
suggested by Arnout, tweak the comment from "User-provided configs" to
"External configs", on the assumption that some br2-external trees could
be provided by vendors, so not necessarily user-provided. Ditto the menu
in Kconfig, changed from "User-provided options" to "External options".
Now, when more than one br2-external tree is used, each gets its own
sub-menu in the "User-provided options" menu. The sub-menu is labelled
with that br2-external tree's name and the sub-menu's first item is a
comment with the path to that br2-external tree.
If there's only one br2-external tree, then there is no sub-menu; there
is a single comment that contains the name and path to the br2-external
tree.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Arnout Vandecappelle <arnout@mind.be>
Cc: Romain Naour <romain.naour@openwide.fr>
Cc: Julien CORJON <corjon.j@ecagroup.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2016-10-14 16:39:20 +02:00
|
|
|
else ifneq ($$(filter boot/% $$(foreach dir,$$(BR2_EXTERNAL_DIRS),$$(dir)/boot/%),$(pkgdir)),)
|
2011-07-11 22:46:10 +02:00
|
|
|
$(2)_KCONFIG_VAR = BR2_TARGET_$(2)
|
core: add support for multiple br2-external trees
Currently, we only support at most one br2-external tree. Being able
to use more than one br2-external tree can be very useful.
A use-case would be for having a br2-external to contain the basic
packages, basic board defconfigs and board files, provided by one team
responsible for the "board-bringup", while other teams consume that
br2-external as a base, and complements it each with their own set of
packages, defconfigs and extra board files.
Another use-case would be for third-parties to provide their own
Buildroot packaging in a br2-external tree, along-side the archives for
their stuff.
Finally, another use-case is to be able to add FLOSS packages in a
br2-external tree, and proprietary packages in another. This allows
to not touch the Buildroot tree at all, and still be able to get in
compliance by providing only that br2-external tree(s) that contains
FLOSS packages, leaving aside the br2-external tree(s) with the
proprietary bits.
What we do is to treat BR2_EXTERNAL as a colon-separated (space-
separated also work, and we use that internally) list of paths, on which
we iterate to construct:
- the list of all br2-external names, BR2_EXTERNAL_NAMES,
- the per-br2-external tree BR2_EXTERNAL_$(NAME) variables, which
point each to the actual location of the corresponding tree,
- the list of paths to all the external.mk files, BR2_EXTERNAL_MKS,
- the space-separated list of absolute paths to the external trees,
BR2_EXTERNAL_DIRS.
Once we have all those variables, we replace references to BR2_EXTERNAL
with either one of those.
This cascades into how we display the list of defconfigs, so that it is
easy to see what br2-external tree provides what defconfigs. As
suggested by Arnout, tweak the comment from "User-provided configs" to
"External configs", on the assumption that some br2-external trees could
be provided by vendors, so not necessarily user-provided. Ditto the menu
in Kconfig, changed from "User-provided options" to "External options".
Now, when more than one br2-external tree is used, each gets its own
sub-menu in the "User-provided options" menu. The sub-menu is labelled
with that br2-external tree's name and the sub-menu's first item is a
comment with the path to that br2-external tree.
If there's only one br2-external tree, then there is no sub-menu; there
is a single comment that contains the name and path to the br2-external
tree.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Arnout Vandecappelle <arnout@mind.be>
Cc: Romain Naour <romain.naour@openwide.fr>
Cc: Julien CORJON <corjon.j@ecagroup.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2016-10-14 16:39:20 +02:00
|
|
|
else ifneq ($$(filter toolchain/% $$(foreach dir,$$(BR2_EXTERNAL_DIRS),$$(dir)/toolchain/%),$(pkgdir)),)
|
2013-12-16 15:58:36 +01:00
|
|
|
$(2)_KCONFIG_VAR = BR2_$(2)
|
2011-07-11 22:46:10 +02:00
|
|
|
else
|
|
|
|
|
$(2)_KCONFIG_VAR = BR2_PACKAGE_$(2)
|
|
|
|
|
endif
|
|
|
|
|
|
2012-05-17 19:33:00 +02:00
|
|
|
# legal-info: declare dependencies and set values used later for the manifest
|
2012-11-02 10:25:41 +01:00
|
|
|
ifneq ($$($(2)_LICENSE_FILES),)
|
|
|
|
|
$(2)_MANIFEST_LICENSE_FILES = $$($(2)_LICENSE_FILES)
|
|
|
|
|
endif
|
|
|
|
|
|
core/legal-info: also save patches
Currently, the legal-info infra only saves the source archive of a
package. However, that's not enough as we may apply some patches on
packages sources.
We do suggest users to also redistribute the Buildroot sources as part
of their compliance distribution, so the patches bundled in Buildroot
would indeed be included in the compliance distribution.
However, that's still not enough, since we may download some patches, or
the user may use a global patch directory. Patches in there might not
end up in the compliance distribution, and there are risks of
non-conformity.
So, always include patches alongside the source archive.
To ensure reproducibility, we also generate a series file, so patches
can be re-applied in the correct order.
We get the list of patches to include from the list of patches that were
applied by the package infrastructure (via the apply-patches support
script). So, we need to get packages properly extracted and patched
before we can save their legal-info, not just in the case they define
_LICENSE_FILES.
Update the legal-info header accordingly.
Note: this means that, when a package is not patched and defines no
LICENSE_FILES, we will extract and patch it for nothing. There is no
easy way to know whether we have to patch a package or not. We can only
either duplicate the logic to detect patches (bad) or rely on the infra
actually patching the package. Also, a vast majority of packages are
either patched, or define _LICENSE_FILES, so it is best and easiest to
always extract and patch them prior to legal-info.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Luca Ceresoli <luca@lucaceresoli.net>
Tested-by: Luca Ceresoli <luca@lucaceresoli.net>
Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2016-05-07 18:14:33 +02:00
|
|
|
# We need to extract and patch a package to be able to retrieve its
|
|
|
|
|
# license files (if any) and the list of patches applied to it (if
|
|
|
|
|
# any).
|
2014-07-02 14:39:59 +02:00
|
|
|
$(1)-legal-info: $(1)-patch
|
2014-06-22 14:41:12 +02:00
|
|
|
|
2014-06-22 14:41:14 +02:00
|
|
|
# We only save the sources of packages we want to redistribute, that are
|
2016-03-05 00:39:13 +01:00
|
|
|
# non-overriden (local or true override).
|
2012-11-02 10:25:41 +01:00
|
|
|
ifeq ($$($(2)_REDISTRIBUTE),YES)
|
2016-03-05 00:39:12 +01:00
|
|
|
ifeq ($$($(2)_OVERRIDE_SRCDIR),)
|
2014-06-22 14:41:12 +02:00
|
|
|
# Packages that have a tarball need it downloaded beforehand
|
|
|
|
|
$(1)-legal-info: $(1)-source $$(REDIST_SOURCES_DIR_$$(call UPPERCASE,$(4)))
|
2012-05-17 19:33:00 +02:00
|
|
|
endif
|
|
|
|
|
endif
|
|
|
|
|
|
|
|
|
|
# legal-info: produce legally relevant info.
|
2017-06-26 00:03:38 +02:00
|
|
|
$(1)-legal-info: PKG=$(2)
|
2012-05-17 19:33:00 +02:00
|
|
|
$(1)-legal-info:
|
2017-06-26 00:03:38 +02:00
|
|
|
@$$(call MESSAGE,"Collecting legal info")
|
2012-05-17 19:33:00 +02:00
|
|
|
# Packages without a source are assumed to be part of Buildroot, skip them.
|
infra: consistently use double dollar signs inside inner-xxx-targets
The inner-xxx-targets in the buildroot package infrastructures are
evaluated using $(eval) which causes variable references to be a bit
different than in regular make code. As we want most references to be
expanded only at the time of the $(eval) we should not use standard
references $(VAR) but rather use double dollar signs $$(VAR). This includes
function references like $(call), $(subst), etc. The only exception is the
reference to pkgdir/pkgname and numbered variables, which are parameters to
the inner block: $(1), $(2), etc.
This patch introduces consistent usage of double-dollar signs throughout the
different inner-xxx-targets blocks.
In some cases, this would potentially cause circular references, in
particular when the value of HOST_FOO_VAR would be obtained from the
corresponding FOO_VAR if HOST_FOO_VAR is not defined. In these cases, a test
is added to check for a host package (the only case where such constructions
are relevant; these are not circular).
Benefits of these changes are:
- behavior of variables is now again as expected. For example, setting
$(2)_VERSION = virtual in pkg-virtual.mk will effectively work, while
originally it would cause very odd results.
- The output of 'make printvars' is now much more useful. This target shows
the value of all variables, and the expression that led to that value.
However, if the expression was coming from an inner-xxx-targets block, and
was using single dollar signs, it would show in printvars as
VAR = value (value)
while if double dollar signs are used, it would effectively look like
VAR = value (actual expression)
as is intended.
This improvement is for example effective for FOO_DL_VERSION, FOO_RAWNAME,
FOO_SITE_METHOD and FOO_MAKE.
The correctness of this patch has been verified using 'make printvars',
'make manual' and 'make legal-info' before and after applying this patch,
and comparing the output.
Insight-provided-by: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-06-11 21:12:24 +02:00
|
|
|
$$(foreach hook,$$($(2)_PRE_LEGAL_INFO_HOOKS),$$(call $$(hook))$$(sep))
|
|
|
|
|
ifneq ($$(call qstrip,$$($(2)_SOURCE)),)
|
2013-11-12 09:47:56 +01:00
|
|
|
|
2014-06-22 14:41:13 +02:00
|
|
|
# Save license files if defined
|
|
|
|
|
# We save the license files for any kind of package: normal, local,
|
|
|
|
|
# overridden, or non-redistributable alike.
|
|
|
|
|
# The reason to save license files even for no-redistribute packages
|
|
|
|
|
# is that the license still applies to the files distributed as part
|
|
|
|
|
# of the rootfs, even if the sources are not themselves redistributed.
|
|
|
|
|
ifeq ($$(call qstrip,$$($(2)_LICENSE_FILES)),)
|
core: rename FOO_BASE_NAME to FOO_BASENAME to avoid clashes
In current Buildroot, clashes occur between the variables _NAME and
_BASE_NAME for two packages called foo and foo-base, i.e.
Package foo:
FOO_NAME = foo
FOO_BASE_NAME = foo-1.2.3
Package foo-base:
FOO_BASE_NAME = foo-base
FOO_BASE_BASE_NAME = foo-base-4.5.6
where variable FOO_BASE_NAME is clashing between these two packages.
Specific cases where this clash is already existing are:
- alljoyn-base
- alljoyn-tcl-base
- perl-xml-sax-base
The problem is generic and can occur for a number of variables in Buildroot.
A non-exhaustive list:
<pkg>_BASE and <pkg>_BASE_NAME
<pkg>_BASE_NAME and <pkg>_RAW_BASE_NAME
<pkg>_DIR and <pkg>_DL_DIR
<pkg>_VERSION and <pkg>_DL_VERSION
<pkg>_SOURCE and <pkg>_TARGET_SOURCE
<pkg>_INSTALL_IMAGES and <pkg>_TARGET_INSTALL_IMAGES (same for _STAGING and _TARGET)
<pkg>_LICENSE_FILES and <pkg>_MANIFEST_LICENSE_FILES
<pkg>_DEPENDENCIES and <pkg>_FINAL_DEPENDENCIES
One solution is to use another separator than '_' to separate the
package name from the rest of the variable name. For example, a double
underscore:
FOO__NAME
FOO__BASE_NAME
FOO_BASE__NAME
FOO_BASE__BASE_NAME
However, making that change for only this case means that the variable
naming is no longer consistent. And making the change for all variables has
a large impact, also on certain user scripts.
For now, keep it simple, and rename FOO_BASE_NAME into FOO_BASENAME, so that
the variables become:
FOO_NAME
FOO_BASENAME
FOO_BASE_NAME
FOO_BASE_BASENAME
For consistency, also adapt FOO_RAW_BASE_NAME. Since FOO_RAW_BASENAME would
still pose a conflict with a package called 'foo-raw', take the opportunity
to rename it into FOO_BASENAME_RAW instead, which does not pose a conflict
as we have no variable called FOO_RAW.
Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Reviewed-by: Sam Voss <sam.voss@rockwellcollins.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2018-02-06 13:59:23 +01:00
|
|
|
$(Q)$$(call legal-warning-pkg,$$($(2)_BASENAME_RAW),cannot save license ($(2)_LICENSE_FILES not defined))
|
2014-06-22 14:41:13 +02:00
|
|
|
else
|
core: rename FOO_BASE_NAME to FOO_BASENAME to avoid clashes
In current Buildroot, clashes occur between the variables _NAME and
_BASE_NAME for two packages called foo and foo-base, i.e.
Package foo:
FOO_NAME = foo
FOO_BASE_NAME = foo-1.2.3
Package foo-base:
FOO_BASE_NAME = foo-base
FOO_BASE_BASE_NAME = foo-base-4.5.6
where variable FOO_BASE_NAME is clashing between these two packages.
Specific cases where this clash is already existing are:
- alljoyn-base
- alljoyn-tcl-base
- perl-xml-sax-base
The problem is generic and can occur for a number of variables in Buildroot.
A non-exhaustive list:
<pkg>_BASE and <pkg>_BASE_NAME
<pkg>_BASE_NAME and <pkg>_RAW_BASE_NAME
<pkg>_DIR and <pkg>_DL_DIR
<pkg>_VERSION and <pkg>_DL_VERSION
<pkg>_SOURCE and <pkg>_TARGET_SOURCE
<pkg>_INSTALL_IMAGES and <pkg>_TARGET_INSTALL_IMAGES (same for _STAGING and _TARGET)
<pkg>_LICENSE_FILES and <pkg>_MANIFEST_LICENSE_FILES
<pkg>_DEPENDENCIES and <pkg>_FINAL_DEPENDENCIES
One solution is to use another separator than '_' to separate the
package name from the rest of the variable name. For example, a double
underscore:
FOO__NAME
FOO__BASE_NAME
FOO_BASE__NAME
FOO_BASE__BASE_NAME
However, making that change for only this case means that the variable
naming is no longer consistent. And making the change for all variables has
a large impact, also on certain user scripts.
For now, keep it simple, and rename FOO_BASE_NAME into FOO_BASENAME, so that
the variables become:
FOO_NAME
FOO_BASENAME
FOO_BASE_NAME
FOO_BASE_BASENAME
For consistency, also adapt FOO_RAW_BASE_NAME. Since FOO_RAW_BASENAME would
still pose a conflict with a package called 'foo-raw', take the opportunity
to rename it into FOO_BASENAME_RAW instead, which does not pose a conflict
as we have no variable called FOO_RAW.
Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Reviewed-by: Sam Voss <sam.voss@rockwellcollins.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2018-02-06 13:59:23 +01:00
|
|
|
$(Q)$$(foreach F,$$($(2)_LICENSE_FILES),$$(call legal-license-file,$$($(2)_RAWNAME),$$($(2)_BASENAME_RAW),$$($(2)_PKGDIR),$$(F),$$($(2)_DIR)/$$(F),$$(call UPPERCASE,$(4)))$$(sep))
|
2014-06-22 14:41:13 +02:00
|
|
|
endif # license files
|
|
|
|
|
|
2012-11-02 10:25:41 +01:00
|
|
|
ifeq ($$($(2)_SITE_METHOD),local)
|
2012-05-17 19:33:00 +02:00
|
|
|
# Packages without a tarball: don't save and warn
|
2014-06-22 14:41:15 +02:00
|
|
|
@$$(call legal-warning-nosource,$$($(2)_RAWNAME),local)
|
2013-11-12 09:47:56 +01:00
|
|
|
|
2012-12-03 01:05:51 +01:00
|
|
|
else ifneq ($$($(2)_OVERRIDE_SRCDIR),)
|
2014-06-22 14:41:15 +02:00
|
|
|
@$$(call legal-warning-nosource,$$($(2)_RAWNAME),override)
|
2013-11-12 09:47:56 +01:00
|
|
|
|
2012-05-17 19:33:00 +02:00
|
|
|
else
|
|
|
|
|
# Other packages
|
2013-11-12 09:47:56 +01:00
|
|
|
|
2012-11-02 10:25:41 +01:00
|
|
|
ifeq ($$($(2)_REDISTRIBUTE),YES)
|
2016-05-07 18:14:34 +02:00
|
|
|
# Save the source tarball and any extra downloads, but not
|
|
|
|
|
# patches, as they are handled specially afterwards.
|
|
|
|
|
$$(foreach e,$$($(2)_ACTUAL_SOURCE_TARBALL) $$(notdir $$($(2)_EXTRA_DOWNLOADS)),\
|
|
|
|
|
$$(Q)support/scripts/hardlink-or-copy \
|
2018-04-02 15:09:26 +02:00
|
|
|
$$($(2)_DL_DIR)/$$(e) \
|
2016-05-07 18:14:34 +02:00
|
|
|
$$($(2)_REDIST_SOURCES_DIR)$$(sep))
|
core/legal-info: also save patches
Currently, the legal-info infra only saves the source archive of a
package. However, that's not enough as we may apply some patches on
packages sources.
We do suggest users to also redistribute the Buildroot sources as part
of their compliance distribution, so the patches bundled in Buildroot
would indeed be included in the compliance distribution.
However, that's still not enough, since we may download some patches, or
the user may use a global patch directory. Patches in there might not
end up in the compliance distribution, and there are risks of
non-conformity.
So, always include patches alongside the source archive.
To ensure reproducibility, we also generate a series file, so patches
can be re-applied in the correct order.
We get the list of patches to include from the list of patches that were
applied by the package infrastructure (via the apply-patches support
script). So, we need to get packages properly extracted and patched
before we can save their legal-info, not just in the case they define
_LICENSE_FILES.
Update the legal-info header accordingly.
Note: this means that, when a package is not patched and defines no
LICENSE_FILES, we will extract and patch it for nothing. There is no
easy way to know whether we have to patch a package or not. We can only
either duplicate the logic to detect patches (bad) or rely on the infra
actually patching the package. Also, a vast majority of packages are
either patched, or define _LICENSE_FILES, so it is best and easiest to
always extract and patch them prior to legal-info.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Luca Ceresoli <luca@lucaceresoli.net>
Tested-by: Luca Ceresoli <luca@lucaceresoli.net>
Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2016-05-07 18:14:33 +02:00
|
|
|
# Save patches and generate the series file
|
|
|
|
|
$$(Q)while read f; do \
|
|
|
|
|
support/scripts/hardlink-or-copy \
|
|
|
|
|
$$$${f} \
|
|
|
|
|
$$($(2)_REDIST_SOURCES_DIR) || exit 1; \
|
|
|
|
|
printf "%s\n" "$$$${f##*/}" >>$$($(2)_REDIST_SOURCES_DIR)/series || exit 1; \
|
|
|
|
|
done <$$($(2)_DIR)/.applied_patches_list
|
2013-11-12 09:47:56 +01:00
|
|
|
endif # redistribute
|
|
|
|
|
|
|
|
|
|
endif # other packages
|
2015-10-03 23:18:18 +02:00
|
|
|
@$$(call legal-manifest,$$($(2)_RAWNAME),$$($(2)_VERSION),$$($(2)_LICENSE),$$($(2)_MANIFEST_LICENSE_FILES),$$($(2)_ACTUAL_SOURCE_TARBALL),$$($(2)_ACTUAL_SOURCE_SITE),$$(call UPPERCASE,$(4)))
|
infra: consistently use double dollar signs inside inner-xxx-targets
The inner-xxx-targets in the buildroot package infrastructures are
evaluated using $(eval) which causes variable references to be a bit
different than in regular make code. As we want most references to be
expanded only at the time of the $(eval) we should not use standard
references $(VAR) but rather use double dollar signs $$(VAR). This includes
function references like $(call), $(subst), etc. The only exception is the
reference to pkgdir/pkgname and numbered variables, which are parameters to
the inner block: $(1), $(2), etc.
This patch introduces consistent usage of double-dollar signs throughout the
different inner-xxx-targets blocks.
In some cases, this would potentially cause circular references, in
particular when the value of HOST_FOO_VAR would be obtained from the
corresponding FOO_VAR if HOST_FOO_VAR is not defined. In these cases, a test
is added to check for a host package (the only case where such constructions
are relevant; these are not circular).
Benefits of these changes are:
- behavior of variables is now again as expected. For example, setting
$(2)_VERSION = virtual in pkg-virtual.mk will effectively work, while
originally it would cause very odd results.
- The output of 'make printvars' is now much more useful. This target shows
the value of all variables, and the expression that led to that value.
However, if the expression was coming from an inner-xxx-targets block, and
was using single dollar signs, it would show in printvars as
VAR = value (value)
while if double dollar signs are used, it would effectively look like
VAR = value (actual expression)
as is intended.
This improvement is for example effective for FOO_DL_VERSION, FOO_RAWNAME,
FOO_SITE_METHOD and FOO_MAKE.
The correctness of this patch has been verified using 'make printvars',
'make manual' and 'make legal-info' before and after applying this patch,
and comparing the output.
Insight-provided-by: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-06-11 21:12:24 +02:00
|
|
|
endif # ifneq ($$(call qstrip,$$($(2)_SOURCE)),)
|
|
|
|
|
$$(foreach hook,$$($(2)_POST_LEGAL_INFO_HOOKS),$$(call $$(hook))$$(sep))
|
2012-05-17 19:33:00 +02:00
|
|
|
|
2009-11-08 18:37:36 +01:00
|
|
|
# add package to the general list of targets if requested by the buildroot
|
|
|
|
|
# configuration
|
2011-07-11 22:46:10 +02:00
|
|
|
ifeq ($$($$($(2)_KCONFIG_VAR)),y)
|
2010-12-24 15:57:29 +01:00
|
|
|
|
2014-05-15 19:37:03 +02:00
|
|
|
# Ensure the calling package is the declared provider for all the virtual
|
|
|
|
|
# packages it claims to be an implementation of.
|
|
|
|
|
ifneq ($$($(2)_PROVIDES),)
|
|
|
|
|
$$(foreach pkg,$$($(2)_PROVIDES),\
|
|
|
|
|
$$(eval $$(call virt-provides-single,$$(pkg),$$(call UPPERCASE,$$(pkg)),$(1))$$(sep)))
|
|
|
|
|
endif
|
|
|
|
|
|
2016-10-23 17:28:51 +02:00
|
|
|
# Register package as a reverse-dependencies of all its dependencies
|
|
|
|
|
$$(eval $$(foreach p,$$($(2)_FINAL_ALL_DEPENDENCIES),\
|
|
|
|
|
$$(call UPPERCASE,$$(p))_RDEPENDENCIES += $(1)$$(sep)))
|
|
|
|
|
|
2014-10-05 11:35:14 +02:00
|
|
|
# Ensure unified variable name conventions between all packages Some
|
|
|
|
|
# of the variables are used by more than one infrastructure; so,
|
|
|
|
|
# rather than duplicating the checks in each infrastructure, we check
|
|
|
|
|
# all variables here in pkg-generic, even though pkg-generic should
|
|
|
|
|
# have no knowledge of infra-specific variables.
|
2014-09-27 21:32:49 +02:00
|
|
|
$(eval $(call check-deprecated-variable,$(2)_MAKE_OPT,$(2)_MAKE_OPTS))
|
|
|
|
|
$(eval $(call check-deprecated-variable,$(2)_INSTALL_OPT,$(2)_INSTALL_OPTS))
|
|
|
|
|
$(eval $(call check-deprecated-variable,$(2)_INSTALL_TARGET_OPT,$(2)_INSTALL_TARGET_OPTS))
|
|
|
|
|
$(eval $(call check-deprecated-variable,$(2)_INSTALL_STAGING_OPT,$(2)_INSTALL_STAGING_OPTS))
|
|
|
|
|
$(eval $(call check-deprecated-variable,$(2)_INSTALL_HOST_OPT,$(2)_INSTALL_HOST_OPTS))
|
|
|
|
|
$(eval $(call check-deprecated-variable,$(2)_AUTORECONF_OPT,$(2)_AUTORECONF_OPTS))
|
|
|
|
|
$(eval $(call check-deprecated-variable,$(2)_CONF_OPT,$(2)_CONF_OPTS))
|
|
|
|
|
$(eval $(call check-deprecated-variable,$(2)_BUILD_OPT,$(2)_BUILD_OPTS))
|
|
|
|
|
$(eval $(call check-deprecated-variable,$(2)_GETTEXTIZE_OPT,$(2)_GETTEXTIZE_OPTS))
|
|
|
|
|
$(eval $(call check-deprecated-variable,$(2)_KCONFIG_OPT,$(2)_KCONFIG_OPTS))
|
|
|
|
|
|
2015-04-12 18:37:48 +02:00
|
|
|
PACKAGES += $(1)
|
2014-05-22 14:35:40 +02:00
|
|
|
|
|
|
|
|
ifneq ($$($(2)_PERMISSIONS),)
|
2012-01-11 18:53:38 +01:00
|
|
|
PACKAGES_PERMISSIONS_TABLE += $$($(2)_PERMISSIONS)$$(sep)
|
2014-05-22 14:35:40 +02:00
|
|
|
endif
|
|
|
|
|
ifneq ($$($(2)_DEVICES),)
|
2012-01-11 18:53:38 +01:00
|
|
|
PACKAGES_DEVICES_TABLE += $$($(2)_DEVICES)$$(sep)
|
2014-05-22 14:35:40 +02:00
|
|
|
endif
|
|
|
|
|
ifneq ($$($(2)_USERS),)
|
2013-04-12 09:14:18 +02:00
|
|
|
PACKAGES_USERS += $$($(2)_USERS)$$(sep)
|
2014-05-22 14:35:40 +02:00
|
|
|
endif
|
2016-06-22 21:07:36 +02:00
|
|
|
TARGET_FINALIZE_HOOKS += $$($(2)_TARGET_FINALIZE_HOOKS)
|
fs: add pre- and post-command hooks
In some cases, the directory structure we want in the filesystem is not
exactly what we have in target/
For example, when systemd is used on a read-only rootfs, /var must be a
tmpfs. However, we may have packages that install stuff in there, and
set important rights (via the permission-table). So, at build time, we
need /var to be a symlink to the remanent location (/usr/share/factory)
while at runtime we need /var to be a directory.
One option would have been to have /var as a real directory even during
build time, and in a target-finalize hook, move everything out of there
and into the "factory" location. However, that's not possible because
it's too early: some packages may want to set ownership and/or acces
rights on directories or files in /var, and this is only done in the
fakeroot script, which is called only later during the assembling of the
filesystem images.
Also, there would have been no way to undo the tweak (i.e. we need to
restore the /var symlink so that subsequent builds continue to work) if
it were done as a target-finalize hook.
The only solution is to allow packages to register pre- and post-hooks
that are called right before and right after the rootfs commands are
executed, and inside in the fakeroot script.
We can however not re-use the BR2_ROOTFS_POST_FAKEROOT_SCRIPT feature
either because it is done before the filesystem command, but there is
nothing that is done after. Also, we don't want to add to, and modify a
user-supplied variable.
So, we introduce two new variables that packages can set to add the
commands they need to run to tweak the filesystem right at the last
moment.
Those hooks are not documented on-purpose; they are probably going to
only ever be used by systemd.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Reviewed-by: Romain Naour <romain.naour@gmail.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2017-08-02 00:52:22 +02:00
|
|
|
ROOTFS_PRE_CMD_HOOKS += $$($(2)_ROOTFS_PRE_CMD_HOOKS)
|
2010-12-24 15:57:29 +01:00
|
|
|
|
|
|
|
|
ifeq ($$($(2)_SITE_METHOD),svn)
|
|
|
|
|
DL_TOOLS_DEPENDENCIES += svn
|
|
|
|
|
else ifeq ($$($(2)_SITE_METHOD),git)
|
|
|
|
|
DL_TOOLS_DEPENDENCIES += git
|
|
|
|
|
else ifeq ($$($(2)_SITE_METHOD),bzr)
|
|
|
|
|
DL_TOOLS_DEPENDENCIES += bzr
|
2011-10-19 09:25:40 +02:00
|
|
|
else ifeq ($$($(2)_SITE_METHOD),scp)
|
|
|
|
|
DL_TOOLS_DEPENDENCIES += scp ssh
|
2011-10-19 09:25:47 +02:00
|
|
|
else ifeq ($$($(2)_SITE_METHOD),hg)
|
|
|
|
|
DL_TOOLS_DEPENDENCIES += hg
|
2013-09-11 14:12:04 +02:00
|
|
|
else ifeq ($$($(2)_SITE_METHOD),cvs)
|
|
|
|
|
DL_TOOLS_DEPENDENCIES += cvs
|
2010-12-24 15:57:29 +01:00
|
|
|
endif # SITE_METHOD
|
|
|
|
|
|
2017-02-12 21:15:38 +01:00
|
|
|
DL_TOOLS_DEPENDENCIES += $$(call extractor-dependency,$$($(2)_SOURCE))
|
2011-12-04 20:23:04 +01:00
|
|
|
|
2015-03-29 19:33:28 +02:00
|
|
|
# Ensure all virtual targets are PHONY. Listed alphabetically.
|
|
|
|
|
.PHONY: $(1) \
|
|
|
|
|
$(1)-all-external-deps \
|
|
|
|
|
$(1)-all-legal-info \
|
|
|
|
|
$(1)-all-source \
|
|
|
|
|
$(1)-build \
|
|
|
|
|
$(1)-clean-for-rebuild \
|
|
|
|
|
$(1)-clean-for-reconfigure \
|
|
|
|
|
$(1)-clean-for-reinstall \
|
|
|
|
|
$(1)-configure \
|
|
|
|
|
$(1)-depends \
|
|
|
|
|
$(1)-dirclean \
|
|
|
|
|
$(1)-external-deps \
|
|
|
|
|
$(1)-extract \
|
|
|
|
|
$(1)-graph-depends \
|
|
|
|
|
$(1)-install \
|
|
|
|
|
$(1)-install-host \
|
|
|
|
|
$(1)-install-images \
|
|
|
|
|
$(1)-install-staging \
|
|
|
|
|
$(1)-install-target \
|
|
|
|
|
$(1)-legal-info \
|
core/legal-info: ensure legal-info works in off-line mode
Almost all packages which are saved for legal-info have their source
archives downloaded as part of 'make source', which makes an off-line
build completely possible [0].
However, for the pre-configured external toolchains, the source tarball
is different, as the main tarball is a binary package. And that source
tarball is only downloaded during the legal-info phase, which makes it
inconvenient for full off-line builds.
We fix that by adding a new rule, $(1)-legal-source which only
$(1)-all-source depends on, so that we only download it for a top-level
'make source', not as part of the standard download mechanism (i.e. only
what is really needed to build).
This new rule depends, like the normal download mechanism, on a stamp
file, so that we do not emit a spurious hash-check message on successive
runs of 'make source'.
This way, we can do a complete [0] off-line build and are still able to
generate legal-info, while at the same time we do not incur any download
overhead during a simple build.
Also, we previously downloaded the _ACTUAL_SOURCE_TARBALL when it was
not empty. However, since _ACTUAL_SOURCE_TARBALL defaults to the value
of _SOURCE, it can not be empty when _SOURCE is not. Thus, we'd get a
spurious report of a missing hash for the tarball, since it was not in
a standard package rule (configure, build, install..) and thus would
miss the PKG and PKGDIR variables to find the .hash file.
We fix that in this commit as well, by:
- setting PKG and PKGDIR just for the -legal-source rule;
- only downloading _ACTUAL_SOURCE_TARBALL if it is not empty *and* not
the same as _SOURCE (to avoid a second report about the hash).
[0] Save for nodejs which invarriably wants to download stuff at build
time. Sigh... :-( Fixing that is work for another time...
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Peter Korsgaard <jacmet@uclibc.org>
Tested-by: Luca Ceresoli <luca@lucaceresoli.net>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2016-05-07 18:14:38 +02:00
|
|
|
$(1)-legal-source \
|
2015-03-29 19:33:28 +02:00
|
|
|
$(1)-patch \
|
|
|
|
|
$(1)-rebuild \
|
|
|
|
|
$(1)-reconfigure \
|
|
|
|
|
$(1)-reinstall \
|
|
|
|
|
$(1)-rsync \
|
|
|
|
|
$(1)-show-depends \
|
|
|
|
|
$(1)-show-version \
|
2017-10-25 22:09:51 +02:00
|
|
|
$(1)-source
|
2015-03-29 19:33:28 +02:00
|
|
|
|
2016-07-03 11:50:01 +02:00
|
|
|
ifneq ($$($(2)_SOURCE),)
|
|
|
|
|
ifeq ($$($(2)_SITE),)
|
|
|
|
|
$$(error $(2)_SITE cannot be empty when $(2)_SOURCE is not)
|
|
|
|
|
endif
|
|
|
|
|
endif
|
|
|
|
|
|
2015-10-03 19:22:17 +02:00
|
|
|
ifeq ($$(patsubst %/,ERROR,$$($(2)_SITE)),ERROR)
|
|
|
|
|
$$(error $(2)_SITE ($$($(2)_SITE)) cannot have a trailing slash)
|
|
|
|
|
endif
|
|
|
|
|
|
2016-06-04 18:30:47 +02:00
|
|
|
ifneq ($$($(2)_HELP_CMDS),)
|
|
|
|
|
HELP_PACKAGES += $(2)
|
|
|
|
|
endif
|
|
|
|
|
|
2011-07-11 22:46:10 +02:00
|
|
|
endif # $(2)_KCONFIG_VAR
|
2012-07-03 00:07:08 +02:00
|
|
|
endef # inner-generic-package
|
2009-11-08 18:37:36 +01:00
|
|
|
|
|
|
|
|
################################################################################
|
2012-07-03 00:07:08 +02:00
|
|
|
# generic-package -- the target generator macro for generic packages
|
2009-11-08 18:37:36 +01:00
|
|
|
################################################################################
|
|
|
|
|
|
|
|
|
|
# In the case of target packages, keep the package name "pkg"
|
2014-02-05 10:44:03 +01:00
|
|
|
generic-package = $(call inner-generic-package,$(pkgname),$(call UPPERCASE,$(pkgname)),$(call UPPERCASE,$(pkgname)),target)
|
2012-07-03 00:05:46 +02:00
|
|
|
# In the case of host packages, turn the package name "pkg" into "host-pkg"
|
2014-02-05 10:44:03 +01:00
|
|
|
host-generic-package = $(call inner-generic-package,host-$(pkgname),$(call UPPERCASE,host-$(pkgname)),$(call UPPERCASE,$(pkgname)),host)
|
2009-11-08 18:37:36 +01:00
|
|
|
|
|
|
|
|
# :mode=makefile:
|
